[Koha-bugs] [Bug 20696] Remove a few ugly "eq undef" comparisons

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri May 18 09:38:52 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20696

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75224|0                           |1
        is obsolete|                            |

--- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 75402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75402&action=edit
Bug 20696: Fix a few ugly "eq undef" comparisons in Search.pm

Comparisons like $a eq undef should normally raise a warning like:
    Use of uninitialized value in string eq at ...
But unfortunately we still suppress warnings here and there.

Test plan:
[1] Just read this patch and confirm the small changes.
[2] Git grep on "eq undef" and do not find other occurrences.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Passes test plan and QA tools. Searching works correctly.

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list