[Koha-bugs] [Bug 20120] Prevent writeoffs of more than the amount owed for a fee

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri May 18 16:44:19 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

--- Comment #31 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #30)
> (In reply to Kyle M Hall from comment #29)
> > (In reply to Jonathan Druart from comment #27)
> > > How do we get the redirect? Sounds like impossible as we have the JS check.
> > 
> > Never rely on client side validation ; )
> 
> Yes you are right, the problem is that it does not work.
> It's easy to get the redirect:
>   98     $amount=999;
> 
> Then you see:
> https://screenshots.firefox.com/8sNfHqHqxHpnMt45/pro.kohadev.org

I don't get why you are failing qa for something that has nothing to do with my
code. Did you even test it? If you fake a larger amount, then try to overpay
the real amount, my code will prevent the payment from going though as
expected.

I seriously don't understand how you can say it doesn't work. Please post a
video demonstration. Your screenshot gives no useful information.

Setting back to PQA for now.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list