[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Tue May 22 15:26:38 CEST 2018
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421
Owen Leonard <oleonard at myacpl.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #17 from Owen Leonard <oleonard at myacpl.org> ---
The QA tool shows some issues with this:
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
FAIL forbidden patterns
forbidden pattern: Do not use line breaks inside template tags
(bug 18675) (line 62)
forbidden pattern: Do *not* include full path to js files, use
the Asset TT plugin (bug 20538) (line 890)
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
FAIL forbidden patterns
forbidden pattern: Do not use line breaks inside template tags
(bug 18675) (line 25)
I notice in results.tt:
[% Asset.js("prog/js/coce.js") %]
should be
[% Asset.js("js/coce.js") %]
I'd also like to see this modified to use the term "staff client" instead of
"intranet," according to our terminology guidelines:
https://wiki.koha-community.org/wiki/Terminology
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list