[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #39 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Alex Arnaud from comment #38)
> (In reply to David Gustafsson from comment #37)
> > Created attachment 75458 [details] [review] [review]
> > Change search field weight field to decimal and add column declaration to
> > DBIx results source
> 
> Hello David,
> 
> You provide changes on Koha/Schema/Result/SearchField.pm. This should be
> done in a dedicated patch. RM will ignore it.
> 
> Also, you replaced the input type number with a input text. This cause
> errors when typing non-numeric characters in. You can use a input number
> with step=0.1 to increment decimal numbers.
> 
> Need to fail QA

Input number for decimals can be problematic for translations in my experience.
Please test for example with de-DE if the value is correctly stored (it will
force a decimal comma instead of . on input, which is inconsistent with our
other input fields right now)

-- 
You are receiving this mail because:
You are watching all bug changes.