[Koha-bugs] [Bug 19113] Barcode value builder not working with numeric branchcode

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19113

--- Comment #9 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 75509
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75509
Bug 19113: Barcode value builder not working with numeric branchcode

Review of attachment 75509:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19113&attachment=75509)
-----------------------------------------------------------------

::: C4/Barcodes/ValueBuilder.pm
@@ +49,4 @@
>      my $month = $args->{mon};
>      my $query = "SELECT MAX(CAST(SUBSTRING(barcode,-4) AS signed)) AS number FROM items WHERE barcode REGEXP ?";
>      my $sth = C4::Context->dbh->prepare($query);
> +    $sth->execute("^[-a-zA-Z0-9]{1,}$year$month");

If this regexp is wrong, there are several other places it is wrong too. See
C4/Barcodes/hbyymmincr.pm db_max for example.

See also line 142:
This format is deprecated and SHOULD NOT BE USED.

-- 
You are receiving this mail because:
You are watching all bug changes.