[Koha-bugs] [Bug 11512] Only allow to override maximum number of holds from staff as other overrides would never be filled

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri May 25 13:04:06 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11512

Stefan Berndtsson <stefan.berndtsson at ub.gu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stefan.berndtsson at ub.gu.se

--- Comment #14 from Stefan Berndtsson <stefan.berndtsson at ub.gu.se> ---
(In reply to Marcel de Rooy from comment #11)
> Currently in Koha, if you choose to force a hold from the staff side that
> would contravened the current issuing rules, that hold will never be filled,
> as it is always skipped over by CheckReserves.
> 
> This patch disallows overrideing except for tooManyReserves which are the
> only overridden holds that will be trapped.

>From what I can see in the code, this isn't actually true. CheckReserves does
not include neither LOST nor WITHDRAWN in its checks. In fact, we use the LOST
part here.

When longoverdue.pl marks a book as LOST, our staff adds a reserve to that
item, so that they will be notified if it is returned. With the code prior to
this patch,
this works perfectly fine since we have the AllowHoldPolicyOverride set and
returning a LOST item fills the hold.

We've also used a similiar thing with withdrawn, but that's not as critical, so
I won't argue against that one.

The assumption that this is always skipped is not valid, unless I've missed
something.

We can patch things temporarily, but some sort of option for better override
selectability would probably be useful here.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list