[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

--- Comment #53 from Ere Maijala <ere.maijala at helsinki.fi> ---
David,

$serialization_format needs a default value in the code, I think (but see
below). Otherwise, unless you go and save the
ElasticsearchMARCSerializationFormat pref once, the search results show up
empty and you'll get a lot of "uninitialized value" warnings from the following
line:

if ($serialization_format eq 'base64ISO2709') {


I also believe that "$record->as_usmarc()" will carp and set the record length
to 99999 if the record ends up being too long. If you made reading the index
autodetect between ISO2709 and MARCXML, you could use MARCXML as the fallback
format when ->as_usmarc() carps. So the ISO2709 format would be used whenever
possible and MARCXML would only be used for large records. And you could get
rid of the ElasticsearchMARCSerializationFormat pref. This would be my
preferred method at the moment, since ISO2709 saves time and space but large
records need to be supported.

-- 
You are receiving this mail because:
You are watching all bug changes.