[Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Keywords|                            |NeedsMoreQA

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I have not tested it, just had a quick look.

1.
This:
  Koha::Biblio->may_article_request
shows that Koha::Biblio is not the right place to put it. Koha::Object class
should not have class methods.

2. In Koha::IssuingRules, $class_or_self must be named $class

3. The cache is cleared in a very lazy way :)

4. Maybe we do not need may_article_request, but only
guess_article_requestable_itemtypes?

-- 
You are receiving this mail because:
You are watching all bug changes.