[Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon May 28 22:06:06 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
+my $report_rec = Koha::Reports->find( $report_name ? { 'name' => $report_name
} : { 'id' => $report_id } );

This is wrong: there is no saved_sql.name column, and saved_sql.report_name is
not a uniq key (so you should ->search instead of find).

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list