[Koha-bugs] [Bug 20798] Client side validation for for fund selection prevents adding only some records to a basket

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20798

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #75615|0                           |1
        is obsolete|                            |

--- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 75620
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75620&action=edit
Bug 20798: Client side validation for for fund selection prevents adding only
some records to a basket

Bug 19453 "fixed" the fund validation that never actually worked. This
validation should be removed altogether instead. It is overly simplistic and
simply checks to see if each record in the batch has a fund selected regardless
of whether that record will be imported or not.

In addition, the code completely ignores items generated by
MarcItemFieldsToOrder such that even if items on that page have a fund
selected, the javascript forces the librarian to make a selection from the
left-hand fund pulldown even though it will not be used.

Considering this bad validation is basically 'new' as it never worked before,
the most sensible course of action would be to 'undo' the change and remove the
validation.

Test Plan:
1) Add records to a basket from an import batch
2) Select only some of those items in the batch
3) Note Koha will not let you import them unless you set funds for *all*
   records in the batch
4) Apply this patch
5) Note Koha no longer forces a budget to be selected in the pulldown

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.