From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 00:06:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Oct 2018 23:06:55 +0000
Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582
--- Comment #23 from David Cook ---
(In reply to Julian Maurice from comment #21)
> I don't think we can, psgi.input is defined only when running in a PSGI
> environment (app run by starman for instance) and $c->req->env is an empty
> hashref when the app is run by morbo or hypnotoad.
Ahhh, I see. I forgot about morbo and hypnotoad. Neither CGI nor PSGI, they're
totally bespoke Mojolicious web servers it seems? I guess that's why they would
be more optimized for Mojolicious...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 00:09:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Oct 2018 23:09:01 +0000
Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582
--- Comment #24 from David Cook ---
(In reply to Julian Maurice from comment #22)
> Created attachment 81687 [details] [review]
> Bug 20582: Handle multipart content-type
>
> Mojo::Message::Request's body attribute does not contain anything when
> the content-type is multipart/*
> We have to rebuild the multipart body for CGI scripts
>
> Test plan:
> 1. Go to Tools ? Upload and try to upload a file
Seems such a shame that Mojolicious doesn't just provide the actual original
body of the message...
I was just idly curious about this bug so I'll leave testing to Jerome.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 00:12:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Oct 2018 23:12:10 +0000
Subject: [Koha-bugs] [Bug 20525] Add --timezone switch to koha-create
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20525
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 00:20:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Oct 2018 23:20:27 +0000
Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for
callnumber ranges
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--- Comment #29 from David Cook ---
I am so confused by this bug.
Isn't the inventory already sorting by call number?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 00:46:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Oct 2018 23:46:17 +0000
Subject: [Koha-bugs] [Bug 21732] If an item is marked as lost,
any outstanding transfers upon it should be cancelled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732
--- Comment #13 from Alex Buckley ---
Created attachment 81782
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81782&action=edit
Bug 21732: (follow-up) Added tests to t/db_dependent/Circulation.t
Tests check:
* If transfer is deleted when item is marked as lost with the
LostItemCancelOutstandingTransfer enabled and disabled
* If the items holdingbranch changes when item with transfers on it is
marked as lost.
Also added call to ModItem() when transfers are deleted (if the
LostItemCancelOutstandingTransfers syspref is enabled and a transfer did
exist on the item) to set the items holdingbranch to the transfer source
branch so the 'from' library is responsible for the lost item.
Sponsored-By: Brimbank Library, Australia
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 00:48:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Oct 2018 23:48:51 +0000
Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for
callnumber ranges
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915
--- Comment #30 from Carl ---
Yes, it's sorted by call number but that does not sort correctly. It should be
sorted by items.cn_sort which will sort correctly.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 00:50:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Oct 2018 23:50:30 +0000
Subject: [Koha-bugs] [Bug 21732] If an item is marked as lost,
any outstanding transfers upon it should be cancelled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732
Alex Buckley changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--- Comment #14 from Alex Buckley ---
Hi there
I have added tests to t/db_dependent/Circulation.t and a change of the items
holdingbranch to the 'from' branch when the syspref is enabled.
I am not sure what data inconsistencies script you are referring to Jonathan?
I will set this to 'Needs signoff' for now as I have addressed Martin's point
in comment #3 and Katrin's point in comment #9.
Please let me know if you'd like me to make further changes.
Cheers,
Alex
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 00:52:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 31 Oct 2018 23:52:19 +0000
Subject: [Koha-bugs] [Bug 18926] Web installer doesn't work with plack
enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18926
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--- Comment #2 from David Cook ---
I think I've run the web installer on Plack and it has upgraded but it does get
stuck in a loop.
Once I restart Plack, then everything is fine.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 03:37:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 02:37:42 +0000
Subject: [Koha-bugs] [Bug 21662] Missing Developers from history
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662
--- Comment #9 from Liz Rea ---
That's right, that page is updated daily from Master.
I've fixed the encoding - the database had been installed in latin1, it's now
UTF8.
Cheers,
Liz
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 03:57:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 02:57:03 +0000
Subject: [Koha-bugs] [Bug 18677] issue_id is not added to accountlines for
lost item fees
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677
--- Comment #17 from M. Tompsett ---
(In reply to Jonathan Druart from comment #16)
> There is only 1 call, from C4::Circulation::LostItem, the occurrence in
> C4::Overdues is part of a comment
So it is. Still, I thought the general thrust of development was to move
towards the Koha namespace, and if not, perhaps hashref the parameter list, so
that at least it gets closer to our coding guidelines.
https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL16:_Hashrefs_should_be_used_as_arguments
Also, that comment in C4::Overdues makes me wonder about a tiny refactor / move
into the Koha name space. But perhaps that is beyond the scope of this.
Changing the parameter to a hashref should be a simple enough fix. Though, I do
think putting the lookup in the function, rather than in the calling function,
and thus avoid the need to change the parameter list, is probably better. Less
files affected. Less is more.
It's not like chargelostitems is called for the same thing multiple times, is
it? If it is, the external look up and hashref parameter is probably preferred.
After all, we don't want to slow things down either.
To summarize: if there are no speed issues caused by a double call, then moving
the look up into the function is the preferred fix. If there is a speed issue,
then hashref'ing the parameter list and leaving it external is preferred.
Just my take on it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 04:52:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 03:52:15 +0000
Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for
callnumber ranges
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915
--- Comment #31 from David Cook ---
(In reply to Carl from comment #30)
> Yes, it's sorted by call number but that does not sort correctly. It should
> be sorted by items.cn_sort which will sort correctly.
I am certain that I just looked at this a couple months ago and it was using
the normalized call numbers.
I had an issue where the normalized call numbers were wrong for old records,
but after re-generating the values, all was well. Let me see if I can find any
details on that issue I had...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 04:53:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 03:53:43 +0000
Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for
callnumber ranges
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915
--- Comment #32 from David Cook ---
Here we go...
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21447
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 04:56:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 03:56:04 +0000
Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for
callnumber ranges
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915
--- Comment #33 from David Cook ---
(In reply to David Cook from comment #32)
> Here we go...
>
> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21447
I wish that I had written that bug report better.
In hindsight, I think maybe #19915 fixes the underlying problem that I
observed, which means that both the list view and export views should be fixed
after these changes...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 06:12:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 05:12:48 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79039|0 |1
is obsolete| |
--- Comment #203 from David Cook ---
Created attachment 81783
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81783&action=edit
Bug 10662: Build OAI-PMH Harvesting Client
This patch adds an OAI-PMH harvesting client to Koha.
The client runs as a daemon in the background. Users interact with the client
via the Koha web user interface, which communicates with the daemon via a unix
socket
using a simple JSON-based protocol.
The harvester ingests MARCXML. You can harvest other metadata formats, but you
must use a XSLT to transform them into MARCXML, if you want them to be imported
into Koha.
You can supply your own download and import modules via the
oai-pmh-harvester.yaml
configuration file, but the default modules supplied in this patch should
be good enough for your purposes. If they're not, raise a Bugzilla issue.
There is a cleanup_database.pl addition, because high volume harvesting
will cause the oai_harvester_import_queue table to fill quickly. This table
is not required for adding/updating records. It's mostly just for general
monitoring and audit purposes.
Signed-off-by: Andreas Hedstr?m Mace
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 06:13:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 05:13:00 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
--- Comment #204 from David Cook ---
Created attachment 81784
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81784&action=edit
Bug 10662: (QA follow-up) addressing qa test tool output
I've done the following in this follow-up:
- Added missing POD
- Replaced DBIC use with Koha::Object[s]
- Replaced DataTables with KohaTable
- Fixed database charset and collation
- Moved Javascript to bottom of templates
- Fixed a syntax error in rewrite-config.PL
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 06:14:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 05:14:47 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--- Comment #205 from David Cook ---
Do I change it to Signed Off or back to Needs Signoff?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 06:16:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 05:16:18 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
--- Comment #206 from David Cook ---
Btw, there will be some QA test tool failures, but they should all be false and
stem from this issue: https://gitlab.com/koha-community/qa-test-tools/issues/4
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 08:06:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 07:06:44 +0000
Subject: [Koha-bugs] [Bug 21744] New: Getting Error 500 e trying to Upload
patron images
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21744
Bug ID: 21744
Summary: Getting Error 500 e trying to Upload patron images
Change sponsored?: ---
Product: Koha
Version: 17.11
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: bugs.koha-community.org
Assignee: koha-bugs at lists.koha-community.org
Reporter: harjinder.nagi at serosoft.in
QA Contact: testopia at bugs.koha-community.org
Created attachment 81785
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81785&action=edit
attached document contains the images
Getting Error 500 e trying to Upload patron images
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 08:38:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 07:38:57 +0000
Subject: [Koha-bugs] [Bug 21662] Missing Developers from history
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662
--- Comment #10 from Martin Renvoize ---
Excellent, thanks Liz
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:07:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 08:07:57 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
--- Comment #207 from Josef Moravec ---
What is the intention on commented out code in
koha-tmpl/intranet-tmpl/prog/en/modules/tools/oai-pmh-harvester/dashboard.tt in
table with saved_requests?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:11:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 08:11:05 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
--- Comment #208 from Josef Moravec ---
In tables for history and requests you have column import_matcher_code, that is
bad I think, you should always use matcher_id and make it foreign key to
marc_matchers.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:14:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 08:14:23 +0000
Subject: [Koha-bugs] [Bug 21744] Getting Error 500 e trying to Upload patron
images
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21744
Harjinder Singh Nagi changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P5 - low |P3
--- Comment #1 from Harjinder Singh Nagi ---
Library: Unitedworld School of Law
Koha version: 17.11.05.000
Apache version: Server version: Apache/2.4.18 (Ubuntu)
Registration date: 04/05/2018
Expiration date: 04/08/2026
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:17:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 08:17:02 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #186 from Joonas Kylm?l? ---
Comment on attachment 78690
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78690
Bug 19893 - Alternative optimized indexing for Elasticsearch
Review of attachment 78690:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19893&attachment=78690)
-----------------------------------------------------------------
::: Koha/SearchEngine/Elasticsearch.pm
@@ +34,5 @@
> use Try::Tiny;
> use YAML::Syck;
>
> +use List::Util qw( sum0 reduce );
> +use Search::Elasticsearch;
use Search::Elasticsearch; is already defined above
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:17:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 08:17:18 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #187 from Joonas Kylm?l? ---
Comment on attachment 81284
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81284
Bug 19893: Add pods, remove syspref, add tests for serialization format
Review of attachment 81284:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19893&attachment=81284)
-----------------------------------------------------------------
::: Koha/SearchEngine/Elasticsearch.pm
@@ +329,5 @@
> +The source data from a MARC record field.
> +
> +=item C<$record_document>
> +
> +Hashref representing the Elasticsearch document on which mappings should be applied.
extra space between "the Elasticsearch"
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:22:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 08:22:31 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #188 from Joonas Kylm?l? ---
Comment on attachment 78690
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78690
Bug 19893 - Alternative optimized indexing for Elasticsearch
Review of attachment 78690:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19893&attachment=78690)
-----------------------------------------------------------------
::: Koha/SearchEngine/Elasticsearch.pm
@@ +333,5 @@
> + }
> + push @{$record_document->{$target}}, $_data;
> + }
> + }
> + foreach my $record (@{$records}) {
Instead of stacking multiple for loops here, we can move this block to its own
function, maybe called marc_record_to_document. This should make it easier to
understand the code as the for loop would be then named and code doesn't go
horizontally off the screen, right?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:25:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 08:25:06 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
--- Comment #209 from Josef Moravec ---
Created attachment 81786
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81786&action=edit
Encoding problem + datatable
In submitted requests table I encountered a encoding problem:
"Knihovna ?st??" should be "Knihovna ?st?".
Also, the heading of datatable is usually formatted in one line, see patron
circulation history for example.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:29:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 08:29:02 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |oleonard at myacpl.org
--- Comment #210 from Josef Moravec ---
(In reply to Josef Moravec from comment #209)
> Created attachment 81786 [details]
> Encoding problem + datatable
>
> In submitted requests table I encountered a encoding problem:
>
> "Knihovna ?st??" should be "Knihovna ?st?".
>
> Also, the heading of datatable is usually formatted in one line, see patron
> circulation history for example.
I am adding Owen because of the datatable styling.
Owen, what would you suggest?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:43:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 08:43:01 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
--- Comment #211 from Josef Moravec ---
Comment on attachment 81783
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81783
Bug 10662: Build OAI-PMH Harvesting Client
Review of attachment 81783:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10662&attachment=81783)
-----------------------------------------------------------------
::: Koha/OAI/Harvester/Worker/Download/Stream.pm
@@ +111,5 @@
> + }
> +
> + #NOTE: Prepare database statement handle
> + my $dbh = C4::Context->dbh;
> + my $sql = "insert into oai_harvester_import_queue (uuid,result) VALUES (?,?)";
You should not use SQL in Koha modules, use
Koha::OAI::Harvester::ImportQueue->new in place of execution of this statement
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:50:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 08:50:28 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #189 from Joonas Kylm?l? ---
Comment on attachment 81284
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81284
Bug 19893: Add pods, remove syspref, add tests for serialization format
Review of attachment 81284:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19893&attachment=81284)
-----------------------------------------------------------------
::: Koha/SearchEngine/Elasticsearch.pm
@@ +484,5 @@
>
> +Get mappings, an internal data structure later used by L<_process_mappings($mappings, $data, $record_document)>
> +to process MARC target data, for a MARC mapping.
> +
> +The returned C<$mappings> is to to be confused with mappings provided by C<_foreach_mapping>, rather this
Should be:
The returned C<$mappings> is not to be confused with mappings provided by
C<_foreach_mapping>, rather this
(notice also the extra whitespace)
@@ +515,5 @@
> +Elasticsearch document target field type.
> +
> +=item C<$range>
> +
> +An optinal range as a string on the format "-" or "",
Should be:
An optional range as a string in the format "-" or "",
@@ +517,5 @@
> +=item C<$range>
> +
> +An optinal range as a string on the format "-" or "",
> +where "" and "" are integers specifying a range that will be used
> +for extracting a substing from MARC data as Elasticsearch field target value.
substing -> substring
@@ +522,5 @@
> +
> +The first character position is "1", and the range is inclusive,
> +so "1-3" means the first three characters of MARC data.
> +
> +If only "" is provided only one character as position "" will
as position -> at position
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:52:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 08:52:22 +0000
Subject: [Koha-bugs] [Bug 21682] Stock Rotation: Update DB is failing with
strict_sql_modes ON
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21682
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #81769|0 |1
is obsolete| |
--- Comment #23 from Martin Renvoize ---
Created attachment 81787
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81787&action=edit
Bug 21682: Corrections for strict sql in stockrotationrotas
Test Plan:
1) Ensure you're database is prior to version 18.06.00.040
2) Ensure 'strict_sql_modes' is enabled
3) Run updatedatabase
4) See no errors during upgrade
5) Run a fresh install
6) Note no errors during database installation
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:52:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 08:52:25 +0000
Subject: [Koha-bugs] [Bug 21682] Stock Rotation: Update DB is failing with
strict_sql_modes ON
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21682
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #81770|0 |1
is obsolete| |
--- Comment #24 from Martin Renvoize ---
Created attachment 81788
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81788&action=edit
Bug 21682: Add update DB entry for existing installs
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:52:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 08:52:41 +0000
Subject: [Koha-bugs] [Bug 21682] Stock Rotation: Update DB is failing with
strict_sql_modes ON
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21682
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #25 from Martin Renvoize ---
Works for me
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:59:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 08:59:35 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
--- Comment #212 from Josef Moravec ---
Koha/Schema/Result/*.pm changes should be in its own patch, as they are
generated. Could you split it please?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 10:04:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 09:04:06 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
--- Comment #213 from Josef Moravec ---
There are still COLLATE utf8_unicode_ci in column definitions in atomic update
and kohastrusture.sql
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 10:13:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 09:13:31 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #190 from Joonas Kylm?l? ---
Comment on attachment 81284
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81284
Bug 19893: Add pods, remove syspref, add tests for serialization format
Review of attachment 81284:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19893&attachment=81284)
-----------------------------------------------------------------
::: Koha/SearchEngine/Elasticsearch.pm
@@ +310,5 @@
> return $self->_sort_fields_accessor();
> }
>
> +=head2 _process_mappings($mappings, $data, $record_document)
> +
Missing example usage
@@ +480,4 @@
> return \@record_documents;
> }
>
> +=head2 _field_mappings($facet, $suggestible, $sort, $target_name, $target_type, $range)
This POD is missing example usage:
my @mappings = $self->_field_mappings($facet, $suggestible, $sort,
$target_name, $target_type, $range)
This will be somewhat useful to know what the function returns.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 10:15:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 09:15:09 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
--- Comment #214 from Josef Moravec ---
Created attachment 81789
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81789&action=edit
Bug 10662: (QA follow-up) Fix plural in pod and use statements
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 10:15:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 09:15:16 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
--- Comment #215 from Josef Moravec ---
Created attachment 81790
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81790&action=edit
Bug 10662: (QA follow-up) Enhance marc matchers description
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 10:37:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 09:37:48 +0000
Subject: [Koha-bugs] [Bug 21316] Adding controlfields to the ACQ framework
causes issues when adding to basket
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21316
Marjorie Barry-Vila changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |marjorie.barry-vila at collect
| |o.ca
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 10:47:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 09:47:05 +0000
Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules',
use for 'max_holds' rules
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887
--- Comment #146 from Martin Renvoize ---
Ack, of course.. this is where NULL being meaningful is bad :(.
Hmm, in a few other projects I enforced via relations and made sure I had a
'hidden' default to replace anywhere I'd want a NULL.. but I think that would
be a pretty drastic change.. I'll ponder for a while.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:12:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 11:12:08 +0000
Subject: [Koha-bugs] [Bug 21728] Update C4::Reserves::ChargeReserveFee to
use Koha::Account->add_debit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728
--- Comment #1 from Martin Renvoize ---
Created attachment 81791
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81791&action=edit
Bug 21728: Use Koha::Account->add_debit in ChargeReserveFee
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:21:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 11:21:02 +0000
Subject: [Koha-bugs] [Bug 20996] Fix API response time on ILL request
endpoint
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|7317 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:21:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 11:21:02 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
Circulation and OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|20996 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
[Bug 20996] Fix API response time on ILL request endpoint
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:20:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 11:20:51 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #191 from Joonas Kylm?l? ---
Comment on attachment 81284
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81284
Bug 19893: Add pods, remove syspref, add tests for serialization format
Review of attachment 81284:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19893&attachment=81284)
-----------------------------------------------------------------
::: Koha/SearchEngine/Elasticsearch.pm
@@ +592,5 @@
> +rules keyed by MARC field tags holding all the mapping rules for that particular tag.
> +
> +We can then iterate through all MARC fields for each record and apply all relevant
> +rules once per fields instead of retreiving fields multiple times for each mapping rule
> +wich is terribly slow.
wich -> which
@@ +605,5 @@
> +sub _get_marc_mapping_rules {
> + my ($self) = @_;
> +
> + my $marcflavour = lc C4::Context->preference('marcflavour');
> + my @rules;
There are now two definitions for rules variable. Let's remove this first one.
@@ +699,4 @@
> push @{$rules->{leader}}, @mappings;
> }
> else {
> + die("Invalid MARC field: $marc_field");
https://wiki.koha-community.org/wiki/Coding_Guidelines#Perl says "Instead of
die or croak when meeting unfavorable conditions in our code, we should raise
exceptions via Koha::Exceptions. "
There is also "die("Unmatched opening parenthesis for $marc_field");" and maybe
others that need to be fixed
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:21:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 11:21:20 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
Circulation and OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|20600 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600
[Bug 20600] Provide the ability for users to filter ILL requests
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:21:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 11:21:20 +0000
Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL
requests
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Depends on|7317 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:21:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 11:21:35 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
Circulation and OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|20581 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581
[Bug 20581] Allow manual selection of custom ILL request statuses
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:21:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 11:21:35 +0000
Subject: [Koha-bugs] [Bug 20581] Allow manual selection of custom ILL
request statuses
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|7317 |
CC| |martin.renvoize at ptfs-europe
| |.com
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:22:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 11:22:08 +0000
Subject: [Koha-bugs] [Bug 20639] Allow setting a default/single backend for
OPAC driven requests
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|7317 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:22:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 11:22:08 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
Circulation and OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|20639 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639
[Bug 20639] Allow setting a default/single backend for OPAC driven requests
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:22:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 11:22:16 +0000
Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request
events
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|7317 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:22:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 11:22:16 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
Circulation and OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|20750 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
[Bug 20750] Allow timestamped auditing of ILL request events
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:22:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 11:22:23 +0000
Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans
workflow
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|7317 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:22:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 11:22:23 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
Circulation and OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|18837 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837
[Bug 18837] Add an unmediated Interlibrary Loans workflow
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:22:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 11:22:29 +0000
Subject: [Koha-bugs] [Bug 20563] ILL request list gives no indication of
source and/or target
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Depends on|7317 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:22:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 11:22:29 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
Circulation and OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|20563 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563
[Bug 20563] ILL request list gives no indication of source and/or target
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:41:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 11:41:13 +0000
Subject: [Koha-bugs] [Bug 21540] Move bibliographic framework strings out of
database
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21540
--- Comment #4 from Katrin Fischer ---
I think you can't say they are not translatable, but you require a web
installer in your language and that would be required with a changed process as
well.
What is asked for here was multi-language... and that is much harder.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:50:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 11:50:34 +0000
Subject: [Koha-bugs] [Bug 20966] Add column configuration to table of orders
in a basket
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:50:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 11:50:38 +0000
Subject: [Koha-bugs] [Bug 20966] Add column configuration to table of orders
in a basket
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #80404|0 |1
is obsolete| |
--- Comment #16 from Katrin Fischer ---
Created attachment 81792
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81792&action=edit
Bug 20966: Add column configuration to table of orders in a basket
This patch adds column configuration to the table of orders in a basket.
It replaces the "Show all details" checkbox which previously was used to
show the hidden "tax included" columns. Now those columns are hidden by
default in the columns configuration file.
To test, apply the patch and view a basket with multiple orders. Test
all DataTables functionality (paging, sorting, filtering) including
showing and hiding columns.
Test with both an open and a closed basket.
Signed-off-by: Claire Gravely
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:50:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 11:50:43 +0000
Subject: [Koha-bugs] [Bug 20966] Add column configuration to table of orders
in a basket
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #81636|0 |1
is obsolete| |
--- Comment #17 from Katrin Fischer ---
Created attachment 81793
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81793&action=edit
Bug 20966: (follow-up) Add template variable filter; Fix table export
This patch makes to corrections:
1. The "$raw" filter has been added to the column configuration
2. The columns configuration now specifies which columns are exported in
Copy, Excel, etc. operations.
To test, apply the patch and test the various table export buttons on a
both a closed and open basket. Confirm that the 'Modify' and 'Cancel'
columns are not exported.
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:54:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 11:54:16 +0000
Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after
allocation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844
--- Comment #29 from Alex Buckley ---
Hi Martin
Thanks for your feedback.
I have tested and looked through the code calls in /circ/pendingreserves.pl,
/tools/batchMod.pl and misc/cronjobs/longoverdue.pl
I have noticed they are not consistent in their current handling of the
reserves on lost items.
* /circ/pendingreserves.pl - This cancels non-waiting item level reserves when
item is marked as lost. Doesn't show allocated (waiting) holds.
* /tools/batchMod.pl - Doesn?t cancel item-level or allocated bib-level
reserves.
* /misc/cronjob/longoverdue.pl - Doesn't cancel non-waiting (un-allocated)
reserves
It would be good to have a consistent approach throughout Koha for dealing with
reserves on lost items.
A question do you think it would be best to split this patch up so it is only
dealing with allocated (waiting) holds. This would alter the behavior of the
patches on the bug report which check for reserve type of 'waiting' or
'reserved'.
Then we would only need to add reserve handling to /tools/batchMod.pl as
longoverdue.pl and pendingreserves.pl don't touch waiting reserves.
Amending longoverdue.pl and pendingreserves.pl could go in another bug report
building on this to handle un-allocated holds, just to prevent too much scope
creep on this bug report?
Cheers,
Alex
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:57:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 11:57:22 +0000
Subject: [Koha-bugs] [Bug 21282] Ordered/spent lists should use prices
including tax for calculations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21282
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #81003|0 |1
is obsolete| |
--- Comment #5 from Katrin Fischer ---
Created attachment 81794
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81794&action=edit
Bug 21282: Sync ordered and spent values with acqui home
The order list for each fund calculates using the ecost tax excl., but
it should be tax incl.
At the moment this means that the sum on the start page table and the
order list don't match up.
Test plan:
- Create and receive orders
- Values on acqui home and ordered/spent should be the same
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:57:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 11:57:18 +0000
Subject: [Koha-bugs] [Bug 21282] Ordered/spent lists should use prices
including tax for calculations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21282
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:58:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 11:58:43 +0000
Subject: [Koha-bugs] [Bug 21427] Format prices on ordered/spent lists
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21427
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |21282
--- Comment #8 from Katrin Fischer ---
21282 adds a bit of filters. Waiting for that one.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21282
[Bug 21282] Ordered/spent lists should use prices including tax for
calculations
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:58:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 11:58:43 +0000
Subject: [Koha-bugs] [Bug 21282] Ordered/spent lists should use prices
including tax for calculations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21282
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |21427
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21427
[Bug 21427] Format prices on ordered/spent lists
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:00:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 12:00:58 +0000
Subject: [Koha-bugs] [Bug 21745] New: Checkin of withdrawn items marked
successful via SIP2 when BlockReturnOfWithdrawnItems is enabled
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21745
Bug ID: 21745
Summary: Checkin of withdrawn items marked successful via SIP2
when BlockReturnOfWithdrawnItems is enabled
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: SIP2
Assignee: koha-bugs at lists.koha-community.org
Reporter: nick at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
CC: colin.campbell at ptfs-europe.com
To recreate:
1 - Mark an item withdrawn
2 - Set up sip server:
https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup
3 - Set 'BlockReturnOfWithdrawnItems' to block
4 - Use the sip_cli_emulator to checkin the withdrawn item
5 - There is no error in the checkin
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:19:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 12:19:15 +0000
Subject: [Koha-bugs] [Bug 21158] Add cronjob references to the system
preference descriptions if a cronjob is required
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:19:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 12:19:19 +0000
Subject: [Koha-bugs] [Bug 21158] Add cronjob references to the system
preference descriptions if a cronjob is required
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #81608|0 |1
is obsolete| |
--- Comment #5 from Katrin Fischer ---
Created attachment 81795
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81795&action=edit
Bug 21158: Add cronjob references to the system preference descriptions if a
cronjob is required
This patch adds references to cronjobs in the description of some system
preferences.
The following system preference description were modified:
- StaticHoldsQueueWeight
- ExpireReservesMaxPickUpDelay
- AutoResumeSuspendedHolds
- finesMode
- DefaultLongOverdueLostValue
- DefaultLongOverdueChargeValue
- PatronSelfRegistrationExpireTemporaryAccountsDelay
- PatronSelfRegistrationVerifyByEmail
- EnhancedMessagingPreferences
- NewItemsDefaultLocation
- InProcessingToShelvingCart
- ReturnToShelvingCart
- ReturnToShelvingCart
- AuthorityMergeLimit
- OpacBrowser
- OpacCloud
- UsageStats
- PurgeSuggestionsOlderThan
- MembershipExpiryDaysNotice
To test, check the above mentioned system preferences to make sure the sentence
is there and it is correct.
Followed test plan and patch is as described
Signed-off-by: Alex Buckley
Signed-off-by: Katrin Fischer
https://bugs.koha-community.org/show_bug.cgi?id=12258
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:19:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 12:19:23 +0000
Subject: [Koha-bugs] [Bug 21158] Add cronjob references to the system
preference descriptions if a cronjob is required
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158
--- Comment #6 from Katrin Fischer ---
Created attachment 81796
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81796&action=edit
Bug 12258: (QA follow-up) Add some missing rrrrrrs
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:29:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 12:29:09 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #192 from Joonas Kylm?l? ---
Comment on attachment 78690
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78690
Bug 19893 - Alternative optimized indexing for Elasticsearch
Review of attachment 78690:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19893&attachment=78690)
-----------------------------------------------------------------
::: Koha/SearchEngine/Elasticsearch.pm
@@ +464,5 @@
> +
> + if ($type eq 'sum') {
> + push @{$rules->{sum}}, $name;
> + }
> + elsif($type eq 'boolean') {
missing space after elsif
::: t/Koha/SearchEngine/Elasticsearch.t
@@ +219,5 @@
> + );
> + }
> + });
> +
> + my $see = Koha::SearchEngine::Elasticsearch->new({ index => 'biblios' });
Should use $Koha::SearchEngine::BIBLIOS_INDEX
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:30:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 12:30:44 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #193 from Joonas Kylm?l? ---
Comment on attachment 78692
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78692
Bug 19893: Add index status
Review of attachment 78692:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19893&attachment=78692)
-----------------------------------------------------------------
::: admin/searchengine/elasticsearch/mappings.pl
@@ +47,4 @@
>
> my $marc_type = lc C4::Context->preference('marcflavour');
>
> +my @index_names = ('biblios', 'authorities');
Should use $Koha::SearchEngine::BIBLIOS_INDEX and
$Koha::SearchEngine::AUTHORITIES_INDEX
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:33:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 12:33:49 +0000
Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given
subscription
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:35:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 12:35:05 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
--- Comment #216 from Josef Moravec ---
The Refresh import history button does not work, there is an error in js
console:
TypeError: history_table.ajax is undefined
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:35:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 12:35:42 +0000
Subject: [Koha-bugs] [Bug 21745] Checkin of withdrawn items marked
successful via SIP2 when BlockReturnOfWithdrawnItems is enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21745
--- Comment #1 from Nick Clemens ---
Some more details:
C4/SIP/ILS/Transaction/Checkin.pm does set a 'CV' field to 99 if the item is
withdrawn - this doesn't cause a screen message, or set the 'ok' flag to 0
C4/SIP/ILS.pm does not check the CV for 99, or check the value of
'BlockReturnOfLostItems'
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:38:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 12:38:54 +0000
Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given
subscription
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467
--- Comment #34 from Katrin Fischer ---
QA tools are green, but there is a problem with the tests. I will continue
testing, hoping for a quick follow-up:
kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove
t/db_dependent/Acquisition.t
t/db_dependent/Acquisition.t .. 70/71 DBD::mysql::db do failed: Out of range
value for column 'tax_value_on_ordering' at row 1 [for Statement "
UPDATE aqorders
SET
tax_value_on_ordering = quantity * ecost_tax_excluded *
tax_rate_on_ordering,
tax_value_on_receiving = quantity * unitprice_tax_excluded *
tax_rate_on_receiving
WHERE ordernumber = ?
"] at /home/vagrant/kohaclone/C4/Acquisition.pm line 1484.
# No tests run!
t/db_dependent/Acquisition.t .. 71/71
# Failed test 'No tests run for subtest "ModReceiveOrder and subscription"'
# at t/db_dependent/Acquisition.t line 748.
DBD::mysql::db do failed: Out of range value for column 'tax_value_on_ordering'
at row 1 [for Statement "
UPDATE aqorders
SET
tax_value_on_ordering = quantity * ecost_tax_excluded *
tax_rate_on_ordering,
tax_value_on_receiving = quantity * unitprice_tax_excluded *
tax_rate_on_receiving
WHERE ordernumber = ?
"] at /home/vagrant/kohaclone/C4/Acquisition.pm line 1484.
# Looks like your test exited with 255 just after 71.
t/db_dependent/Acquisition.t .. Dubious, test returned 255 (wstat 65280,
0xff00)
Failed 1/71 subtests
Test Summary Report
-------------------
t/db_dependent/Acquisition.t (Wstat: 65280 Tests: 71 Failed: 1)
Failed test: 71
Non-zero exit status: 255
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:49:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 12:49:08 +0000
Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for
callnumber ranges
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #72988|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:49:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 12:49:15 +0000
Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for
callnumber ranges
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #72989|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:53:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 12:53:26 +0000
Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given
subscription
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467
--- Comment #35 from Jonathan Druart ---
Created attachment 81797
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81797&action=edit
Bug 21467: Prevent tests to fail
The following error is raised if TestBuilder generates too big numbers:
Out of range value for column 'tax_value_on_ordering'
UPDATE aqorders
SET
tax_value_on_ordering = quantity * ecost_tax_excluded *
tax_rate_on_ordering,
tax_value_on_receiving = quantity * unitprice_tax_excluded *
tax_rate_on_receiving
WHERE ordernumber = ?
"] at /home/vagrant/kohaclone/C4/Acquisition.pm line 1484.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:56:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 12:56:41 +0000
Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given
subscription
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467
--- Comment #36 from Katrin Fischer ---
Created attachment 81798
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81798&action=edit
Bug 21467: (QA follow-up) Move hint a little bit
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:03:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 13:03:44 +0000
Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given
subscription
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467
--- Comment #37 from Jonathan Druart ---
Created attachment 81799
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81799&action=edit
Bug 21467: (follow-up) Display a summary line per parent_ordernumber
Wrong resolution conflict
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:03:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 13:03:53 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P5 - low |P1 - high
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:11:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 13:11:08 +0000
Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given
subscription
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467
--- Comment #38 from Katrin Fischer ---
QA tool green, tests tool pass now. Acq tab in subscription detail works
correctly.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:50:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 13:50:14 +0000
Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given
subscription
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
Patch complexity|--- |Medium patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:50:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 13:50:19 +0000
Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given
subscription
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467
--- Comment #39 from Katrin Fischer ---
Created attachment 81800
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81800&action=edit
Bug 21474: Add the Koha::Subscription->frequency method
And the 2 modules for the subscriptions' frequencies
Test plan:
prove t/db_dependent/Koha/Subscription.t
must return green
Signed-off-by: Josef Moravec
Signed-off-by: S?verine QUEUNE
Signed-off-by: Katrin Fischer
https://bugs.koha-community.org/show_bug.cgi?id=21475
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:50:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 13:50:23 +0000
Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given
subscription
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #81394|0 |1
is obsolete| |
--- Comment #40 from Katrin Fischer ---
Created attachment 81801
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81801&action=edit
Bug 21467: Allow several receipts for a given subscription
When a new order is created from a subscription the quantity is set to 1
and cannot be modified.
The idea was to order 1 subscription.
This behavior leads to a limitation: it is not possible to mark a
receipt as partially received. However it is how it works in real life,
the vendors send invoices throughout the year. The number of items can
also be changed.
The idea is be to rethink the "quantity" value for an order created
from a subscription and use it to track the number of invoices already
paid.
FIXME: This approach will not cohabit with standing orders.
This patch is a first draft to get feedback on the idea.
FIXME: What about cancelled orders?
Test plan:
- Create a new order from a subscription
- Enter the number of items you think you will receive for this
subscription (for instance 1 per month: 12)
- Close the basket
- Receive 3 items (a trimester) and create a specific invoice for this
receipt. Note that the price are per unit.
If you want to receive items with different prices you should make
split the receipt
- Receive more items. This time you will notice that the previous order
will be displayed on the "order receive" under a new block "Receipt
history for this subscription"
- Note that the "Quantity to receive" has been decrease by the number of
items you previously received
- Also you can notice that this "Quantity to receive" can be modified.
Indeed it can happen that the number of items to receive changed during
the year
- Go to the detail of the subscription and notice that the orders have
been grouped by "parent ordernumber"
- Continue to receive items until all have been received
Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: S?verine QUEUNE
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:50:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 13:50:32 +0000
Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given
subscription
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #81396|0 |1
is obsolete| |
--- Comment #42 from Katrin Fischer ---
Created attachment 81803
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81803&action=edit
Bug 21467: Add subscription's info when ordering
When ordering from a subscription, there is now a "hint" to display the
number of issues and the frequency. It will be easier to estimate the
quantity to receive.
Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: S?verine QUEUNE
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:50:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 13:50:28 +0000
Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given
subscription
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #81395|0 |1
is obsolete| |
--- Comment #41 from Katrin Fischer ---
Created attachment 81802
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81802&action=edit
Bug 21467: Add treetable to subscription detail to group orders by parent
ordernumber
Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: S?verine QUEUNE
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:50:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 13:50:37 +0000
Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given
subscription
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #81397|0 |1
is obsolete| |
--- Comment #43 from Katrin Fischer ---
Created attachment 81804
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81804&action=edit
Bug 21467: Do not erase the internal note of the first order
For the subscription we would like to keep the original internal note
(from the first order), to display it unmodified each time we receive
issues.
Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: S?verine QUEUNE
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:50:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 13:50:41 +0000
Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given
subscription
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #81398|0 |1
is obsolete| |
--- Comment #44 from Katrin Fischer ---
Created attachment 81805
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81805&action=edit
Bug 21467: Display the quantity and adjust the amounts
On the subscription detail view we should display the amounts depending
on the quantity (can be different than 0 now!)
Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: S?verine QUEUNE
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:50:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 13:50:46 +0000
Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given
subscription
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #81399|0 |1
is obsolete| |
--- Comment #45 from Katrin Fischer ---
Created attachment 81806
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81806&action=edit
Bug 21467: Fix default sort
Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: S?verine QUEUNE
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:50:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 13:50:50 +0000
Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given
subscription
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #81400|0 |1
is obsolete| |
--- Comment #46 from Katrin Fischer ---
Created attachment 81807
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81807&action=edit
Bug 21467: Display a summary line per parent_ordernumber
This will help to keep track of the different orders for a given
subscription.
Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: S?verine QUEUNE
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:50:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 13:50:55 +0000
Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given
subscription
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #81430|0 |1
is obsolete| |
--- Comment #47 from Katrin Fischer ---
Created attachment 81808
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81808&action=edit
Bug 21467: (QA follow-up) Fix filter and variable declaration in .t
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:50:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 13:50:59 +0000
Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given
subscription
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #81797|0 |1
is obsolete| |
--- Comment #48 from Katrin Fischer ---
Created attachment 81809
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81809&action=edit
Bug 21467: Prevent tests to fail
The following error is raised if TestBuilder generates too big numbers:
Out of range value for column 'tax_value_on_ordering'
UPDATE aqorders
SET
tax_value_on_ordering = quantity * ecost_tax_excluded *
tax_rate_on_ordering,
tax_value_on_receiving = quantity * unitprice_tax_excluded *
tax_rate_on_receiving
WHERE ordernumber = ?
"] at /home/vagrant/kohaclone/C4/Acquisition.pm line 1484.
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:51:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 13:51:04 +0000
Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given
subscription
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #81798|0 |1
is obsolete| |
--- Comment #49 from Katrin Fischer ---
Created attachment 81810
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81810&action=edit
Bug 21467: (QA follow-up) Move hint a little bit
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:51:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 13:51:09 +0000
Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given
subscription
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #81799|0 |1
is obsolete| |
--- Comment #50 from Katrin Fischer ---
Created attachment 81811
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81811&action=edit
Bug 21467: (follow-up) Display a summary line per parent_ordernumber
Wrong resolution conflict
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:51:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 13:51:22 +0000
Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given
subscription
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #81800|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:55:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 13:55:03 +0000
Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given
subscription
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467
--- Comment #51 from Katrin Fischer ---
I believe this is great in its flexibility and will work much better for
acquisition of serials than the standing order feature. You will be able to
handle an end-of-year invoice or being charged by issue. The amounts will be
encumbered for the year.
I think the only thing missing now would be an option to bring those orders
into the next year, but the duplicate order line feature also waiting will help
with that :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:02:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:02:16 +0000
Subject: [Koha-bugs] [Bug 20489] Prevent DB user login
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |21746
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746
[Bug 21746] Remove NO_LIBRARY_SET
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:02:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:02:16 +0000
Subject: [Koha-bugs] [Bug 21746] New: Remove NO_LIBRARY_SET
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746
Bug ID: 21746
Summary: Remove NO_LIBRARY_SET
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: ASSIGNED
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: jonathan.druart at bugs.koha-community.org
Reporter: jonathan.druart at bugs.koha-community.org
QA Contact: testopia at bugs.koha-community.org
Depends on: 20489
NO_LIBRARY_SET was used when the DB user was logged in. Since bug 20489 it's
not longer possible. We could remove the code.
We also have 2 TT variables: LoginBranchcode, LoginBranchname
And 1 template method, Branches.GetLoggedInBranchcode.
We could simplify and unify that code
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489
[Bug 20489] Prevent DB user login
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:04:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:04:35 +0000
Subject: [Koha-bugs] [Bug 15184] Ability to duplicate existing order lines
to a given basket
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |release-notes-needed
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:04:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:04:42 +0000
Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given
subscription
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |release-notes-needed
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:10:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:10:08 +0000
Subject: [Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use
Koha::Account->add_debit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |21002
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002
[Bug 21002] Add Koha::Account::add_debit
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:10:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:10:08 +0000
Subject: [Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |21747
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747
[Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:09:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:09:49 +0000
Subject: [Koha-bugs] [Bug 21747] New: Update C4::Overdues::UpdateFine to use
Koha::Account->add_debit
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747
Bug ID: 21747
Summary: Update C4::Overdues::UpdateFine to use
Koha::Account->add_debit
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs at lists.koha-community.org
Reporter: martin.renvoize at ptfs-europe.com
QA Contact: testopia at bugs.koha-community.org
All account handling should go via the Koha::Account class.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:11:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:11:24 +0000
Subject: [Koha-bugs] [Bug 21748] New: Update C4::Overdues::UpdateFine to use
Koha::Account->update_debit
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21748
Bug ID: 21748
Summary: Update C4::Overdues::UpdateFine to use
Koha::Account->update_debit
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs at lists.koha-community.org
Reporter: martin.renvoize at ptfs-europe.com
QA Contact: testopia at bugs.koha-community.org
All account handling should go via the Koha::Account class.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:12:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:12:06 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |21748
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21748
[Bug 21748] Update C4::Overdues::UpdateFine to use Koha::Account->update_debit
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:12:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:12:06 +0000
Subject: [Koha-bugs] [Bug 21748] Update C4::Overdues::UpdateFine to use
Koha::Account->update_debit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21748
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |14825
Depends on| |21727
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
[Bug 21727] Add Koha::Account::update_debit
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:12:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:12:06 +0000
Subject: [Koha-bugs] [Bug 21727] Add Koha::Account::update_debit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |21748
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21748
[Bug 21748] Update C4::Overdues::UpdateFine to use Koha::Account->update_debit
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:12:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:12:34 +0000
Subject: [Koha-bugs] [Bug 21727] Add Koha::Account::update_debit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|14825 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:12:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:12:34 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|21727 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
[Bug 21727] Add Koha::Account::update_debit
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:13:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:13:28 +0000
Subject: [Koha-bugs] [Bug 21727] Add Koha::Account::update_debit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|21002 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002
[Bug 21002] Add Koha::Account::add_debit
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:13:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:13:28 +0000
Subject: [Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|21727 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
[Bug 21727] Add Koha::Account::update_debit
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:14:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:14:17 +0000
Subject: [Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|tomascohen at gmail.com |martin.renvoize at ptfs-europe
| |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:26:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:26:19 +0000
Subject: [Koha-bugs] [Bug 21725] Incorrect HAVING in group by in
Acquisitions.pm
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21725
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:26:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:26:25 +0000
Subject: [Koha-bugs] [Bug 21725] Incorrect HAVING in group by in
Acquisitions.pm
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21725
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #81626|0 |1
is obsolete| |
--- Comment #9 from Jonathan Druart ---
Created attachment 81812
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81812&action=edit
Bug 21725: Use full statement in HAVING rather than constructed column
To test:
1 - prove -v t/db_dpendent/Acquisition/GetBasketsInfosByBookseller.t
2 - Apply patch
3 - prove -v t/db_dpendent/Acquisition/GetBasketsInfosByBookseller.t
4 - It passes
5 - Have some open/closed and some fully and not full received baskets
6 - View a vendor and confirm baskets are shwn as expected
7 - Check 'Show all baskets' shows all baskets
Signed-off-by: Martin Renvoize
Signed-off-by: Jonathan Druart
Note sure this is the best thing but it fixes the issue
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:28:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:28:41 +0000
Subject: [Koha-bugs] [Bug 21556] Deleting same record twice leads to fatal
software error
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21556
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:28:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:28:47 +0000
Subject: [Koha-bugs] [Bug 21556] Deleting same record twice leads to fatal
software error
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21556
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #80560|0 |1
is obsolete| |
Attachment #80685|0 |1
is obsolete| |
--- Comment #13 from Jonathan Druart ---
Created attachment 81813
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81813&action=edit
Bug 21556: Deleting same record twice leads to fatal software error
If you delete a record, confirm the deletion, and try to delete the
record and confirm it again befoe the first deletion completes, you'll
generate a fatal software error.
This patch unbinds the click handlers for the "Delete record" button
after the deletion is confirmed and just before the Javascript
processes the redirect to the next page in the process.
To test:
1) You will need a bibliographic record that is able to be deleted
2) Click "Edit", then "Delete record", then "OK"
3) While the browser is reloading, click "Edit", then "Delete record",
then "OK
4) Observe a fatal error such as "Internal server error" or 'Can't call
method "holds" on an undefined value at
/home/vagrant/kohaclone/C4/Biblio.pm line 406.'
5) Apply the patch
6) Run "restart_all" on kohadevbox (or otherwise restart Plack if
running Plack)
7) Navigate to another bibliographic record that is able to be deleted
8) Click "Edit", then "Delete record", then "OK"
9) While the browser is reloading, click "Edit", then "Delete record"
10) Observe that no fatal software error is generated
11) You are redirected to
http://localhost:8081/cgi-bin/koha/catalogue/search.pl (on kohadevbox)
Signed-off-by: Pierre-Marc Thibault
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:28:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:28:53 +0000
Subject: [Koha-bugs] [Bug 21556] Deleting same record twice leads to fatal
software error
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21556
--- Comment #14 from Jonathan Druart ---
Created attachment 81814
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81814&action=edit
Bug 21556: Do not crash if a biblio is deleted twice
To recreate:
- Go to a bibliographic detail page
- Delete it
- Go back
- Delete it again
=> Without this patch you will get a 500
Can't call method "holds" on an undefined value at
/home/vagrant/kohaclone/C4/Biblio.pm line 406.
=> With this patch applied it will silently redirect you to the search
form.
Note: We could/should improve the behavior and display a message, but
DelBiblio will need to be moved to Koha::Biblio->delete and other
callers adjusted
Signed-off-by: Mark Tompsett
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:30:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:30:45 +0000
Subject: [Koha-bugs] [Bug 18677] issue_id is not added to accountlines for
lost item fees
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|In Discussion |ASSIGNED
Assignee|kyle at bywatersolutions.com |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #18 from Jonathan Druart ---
Working on an alternative patch.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:33:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:33:57 +0000
Subject: [Koha-bugs] [Bug 21682] Stock Rotation: Update DB is failing with
strict_sql_modes ON
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21682
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #81788|0 |1
is obsolete| |
--- Comment #26 from Jonathan Druart ---
Created attachment 81815
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81815&action=edit
Bug 21682: Add update DB entry for existing installs
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:34:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:34:43 +0000
Subject: [Koha-bugs] [Bug 21682] Stock Rotation: Update DB is failing with
strict_sql_modes ON
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21682
--- Comment #27 from Jonathan Druart ---
I amended the last patch to move atomicupdate/bug_21620.perl to
atomicupdate/bug_21682.perl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:46:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:46:17 +0000
Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for
callnumber ranges
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:46:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:46:20 +0000
Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for
callnumber ranges
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #76721|0 |1
is obsolete| |
Attachment #76722|0 |1
is obsolete| |
Attachment #76723|0 |1
is obsolete| |
Attachment #76724|0 |1
is obsolete| |
--- Comment #34 from Nick Clemens ---
Created attachment 81816
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81816&action=edit
Bug 19915: Add unit test to GetItemsForInventory.t
prove -v t/db_dependent/Items/GetItemsForInventory.t
Signed-off-by: Anne-Claire Bernaudin
Signed-off-by: Marcel de Rooy
Moved the betwen typo edit back here.
Current patch-complexity: Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:46:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:46:24 +0000
Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for
callnumber ranges
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915
--- Comment #35 from Nick Clemens ---
Created attachment 81817
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81817&action=edit
Bug 19915: (QA follow-up) Tidy up GetItemsForInventory.t
Standard edits like modules, schema, Koha objects instead of DBIC.
Removing unneeded autoflush.
Moving initial test to a first subtest.
No need to clear issues if you clear items.
Adding a FIXME for OldWay; would be nice to remove that code..
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:46:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:46:29 +0000
Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for
callnumber ranges
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915
--- Comment #36 from Nick Clemens ---
Created attachment 81818
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81818&action=edit
Bug 19915: Use cn_sort values for getting inventory items
To test:
1 - Catalog an item under LCC with callnumber GT95
2 - cn_sort should calculate as GT0095
3 - Go to inventory tool
4 - Enter a range that should have your item e.g LC GT90 to GT100
5 - Item is not returned
6 - Apply patch
7 - Item should be returned
8 - Verify things otherwise work as expected
Signed-off-by: Anne-Claire Bernaudin
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:46:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:46:34 +0000
Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for
callnumber ranges
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915
--- Comment #37 from Nick Clemens ---
Created attachment 81819
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81819&action=edit
Bug 19915: Only show class sources in use
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:46:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:46:38 +0000
Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for
callnumber ranges
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915
--- Comment #38 from Nick Clemens ---
Created attachment 81820
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81820&action=edit
Bug 19915: Don't delete in tests
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:46:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:46:47 +0000
Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for
callnumber ranges
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915
--- Comment #39 from Nick Clemens ---
Created attachment 81821
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81821&action=edit
Bug 19915: Make behaviour syspref controlled
To test:
0 - Apply patch, run updatedatabase
1 - Catalog an item under LCC classification source with callnumber GT95
2 - Check db, cn_sort should calculate as GT0095
SELECT cn_sort FROM items where callnumber="GT95";
3 - Catalog an item under LCC classification source with callnumber
GT101
4 - Check db, cn_sort should calculate as GT0101
SELECT cn_sort FROM items where callnumber="GT101";
5 - Go to inventory tool
6 - Enter a range from GT90 to GT100
7 - Neither item is not returned
8 - Enter range from GT100 to GT90
9 - Second item is returned
10 - Set UseCNSortForInventory to 'Use'
11 - Go to invenotry tool
12 - Enter a range from GT90 to GT100
13 - The first item is returned, the second is not
14 - Enter a range from GT100 to GT90
15 - Neither item is returned
16 - prove -v t/db_dependent/Items/GetItemsForInventory.t
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:47:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:47:47 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #194 from David Gustafsson ---
Created attachment 81822
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81822&action=edit
Bug 19893: Add code review fixes
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:48:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:48:48 +0000
Subject: [Koha-bugs] [Bug 18677] issue_id is not added to accountlines for
lost item fees
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:48:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:48:57 +0000
Subject: [Koha-bugs] [Bug 18677] issue_id is not added to accountlines for
lost item fees
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677
--- Comment #19 from Jonathan Druart ---
Created attachment 81823
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81823&action=edit
Bug 18677: Make the tests pass
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:49:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:49:11 +0000
Subject: [Koha-bugs] [Bug 18677] issue_id is not added to accountlines for
lost item fees
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677
--- Comment #20 from Jonathan Druart ---
Created attachment 81824
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81824&action=edit
Bug 18677: Remove new issue_id param from charlostitem
We have the itemnumber no need to pass the issue_id, we can retrieve it
from chargelostitem
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:50:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:50:20 +0000
Subject: [Koha-bugs] [Bug 18677] issue_id is not added to accountlines for
lost item fees
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|jonathan.druart at bugs.koha-c |kyle at bywatersolutions.com
|ommunity.org |
--- Comment #21 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #18)
> Working on an alternative patch.
I have attached 2 follow-ups, back to Needs Signoff.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:55:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:55:29 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #195 from David Gustafsson ---
Ok, thanks for the feedback! I think I fixed most things except:
(In reply to Joonas Kylm?l? from comment #188)
> Comment on attachment 78690 [details] [review]
> Bug 19893 - Alternative optimized indexing for Elasticsearch
>
> Review of attachment 78690 [details] [review]:
> -----------------------------------------------------------------
>
> ::: Koha/SearchEngine/Elasticsearch.pm
> @@ +333,5 @@
> > + }
> > + push @{$record_document->{$target}}, $_data;
> > + }
> > + }
> > + foreach my $record (@{$records}) {
>
> Instead of stacking multiple for loops here, we can move this block to its
> own function, maybe called marc_record_to_document. This should make it
> easier to understand the code as the for loop would be then named and code
> doesn't go horizontally off the screen, right?
I don't get the line numbers to match up, but perhaps I'm using a different
base. I don't recognize this code in my current branch.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:58:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 14:58:09 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #196 from David Gustafsson ---
I also took the liberty to fix commit line length to 80 (perhaps not for all
comments though), since some where a bit long.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:06:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 15:06:00 +0000
Subject: [Koha-bugs] [Bug 21749] New: Importing MARC frameworks from
pre-9701 fails
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21749
Bug ID: 21749
Summary: Importing MARC frameworks from pre-9701 fails
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: MARC Bibliographic data support
Assignee: koha-bugs at lists.koha-community.org
Reporter: tomascohen at gmail.com
QA Contact: testopia at bugs.koha-community.org
If you import a MARC framework that has been exported from a previous version
of Koha (17.11 and below) results in an empty MARC framework, without any error
reporting to the end user. This is because of the added columns in
'marc_tag_structure' (ind1_defaultvalue and ind2_defaultvalue) and the fact
that we don't have a fallback behaviour when they are not present on the
uploaded file.
My opinion is we should check the table header (from CSV or whatever format)
and let the DB use the default values if a column is missing.
I mark it as Major, because there's no possible data recovery after the failed
import.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:06:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 15:06:10 +0000
Subject: [Koha-bugs] [Bug 9701] Configure default indicators
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |21749
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21749
[Bug 21749] Importing MARC frameworks from pre-9701 fails
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:06:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 15:06:10 +0000
Subject: [Koha-bugs] [Bug 21749] Importing MARC frameworks from pre-9701
fails
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21749
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |9701
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701
[Bug 9701] Configure default indicators
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:11:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 15:11:45 +0000
Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774
--- Comment #57 from Martin Renvoize ---
(In reply to M. Tompsett from comment #48)
> (In reply to Katrin Fischer from comment #46)
> > I think search_by doesn't sound quite right... search_on? search_in? Native
> > speaker? :)
>
> search_for? I don't like filter_by, because filter_by suggests we are taking
> a given set and shrinking it. No such thing is passed. We are searching, but
> it is limited for a particular set of conditions. The rest would describe
> the condition. And why not just get_by_marc_field (would do tagfield, but
> tagsubfield is included, I believe), get_by_kohafield?
But you are filtering... you pass in a resultset (whether that be a new one or
an existing already partially filtered one) and then refine it by filtering
down...
We're trying to bring consistency to the objects, so to me filter_by which is
already being discussed elsewhere seems to make sense.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:14:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 15:14:02 +0000
Subject: [Koha-bugs] [Bug 21750] New: Move collection code to its own column
in checkins table
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21750
Bug ID: 21750
Summary: Move collection code to its own column in checkins
table
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs at lists.koha-community.org
Reporter: nick at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
Currently the collection is displayed as part of the itemtype column.
It should be its own column
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:18:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 15:18:38 +0000
Subject: [Koha-bugs] [Bug 20194] Display both biblioitems.itemtype and
items.itype in circulation screens
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20194
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |21750
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21750
[Bug 21750] Move collection code to its own column in checkins table
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:18:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 15:18:41 +0000
Subject: [Koha-bugs] [Bug 21750] Move collection code to its own column in
checkins table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21750
--- Comment #1 from Nick Clemens ---
Created attachment 81825
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81825&action=edit
Bug 21750: Move collection code to its own column on checkins table
To test:
1 - Set 'ShowAllCheckins' to show
2 - Set a collcection code for an item
3 - Check it in
4 - Note it displays in the the 'Item type' column
5 - Apply patch
6 - Check it in again
7 - Note the new 'Collection' column
8 - Hide/show the column using column visibility on the checkins page
9 - Go to Admin->Configure columns
10 - Test the various settings for this column and check in the item to
make sure they work as expected
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:18:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 15:18:49 +0000
Subject: [Koha-bugs] [Bug 21750] Move collection code to its own column in
checkins table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21750
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:18:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 15:18:38 +0000
Subject: [Koha-bugs] [Bug 21750] Move collection code to its own column in
checkins table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21750
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Depends on| |20194
Status|NEW |Needs Signoff
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20194
[Bug 20194] Display both biblioitems.itemtype and items.itype in circulation
screens
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:30:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 15:30:15 +0000
Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640
--- Comment #22 from Martin Renvoize ---
Created attachment 81827
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81827&action=edit
Bug 20640: (follow-up) Degrade gracefully on error
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:30:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 15:30:11 +0000
Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #80900|0 |1
is obsolete| |
--- Comment #21 from Martin Renvoize ---
Created attachment 81826
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81826&action=edit
Bug 20640: Add backend migration support to ILL
- Add core methods required to support the migration of ILL requests
between backends.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:31:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 15:31:25 +0000
Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640
--- Comment #23 from Martin Renvoize ---
I've added a more graceful failure mode should a backend fail to load or fail
to support the migrate action.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:46:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 15:46:01 +0000
Subject: [Koha-bugs] [Bug 21526] TT variables used to build a link should be
uri filtered
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rel_18_11_candidate
Severity|normal |blocker
--- Comment #25 from Jonathan Druart ---
Upping severity to get the attention it needs.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:47:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 15:47:51 +0000
Subject: [Koha-bugs] [Bug 15296] MEMBER logging in action_logs does not give
enough detail.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15296
Sally Healey changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sally.healey at cheshireshared
| |services.gov.uk
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:50:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 15:50:31 +0000
Subject: [Koha-bugs] [Bug 19469] Add ability to split view of holds view on
record by pickup library and/or itemtype
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469
--- Comment #52 from Jonathan Druart ---
Links on the "multi holds" view are broken, please fix.
To recreate:
- Search
- Select few records
- Click "Place hold"
=> On "Home ? Catalog ? Confirm holds" the link of the record does not have a
biblionumber value, the link is
"/cgi-bin/koha/catalogue/detail.pl?biblionumber="
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:50:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 15:50:46 +0000
Subject: [Koha-bugs] [Bug 19469] Add ability to split view of holds view on
record by pickup library and/or itemtype
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |additional_work_needed
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:52:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 15:52:15 +0000
Subject: [Koha-bugs] [Bug 19469] Add ability to split view of holds view on
record by pickup library and/or itemtype
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469
--- Comment #53 from Jonathan Druart ---
Created attachment 81828
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81828&action=edit
Bug 19469: Fix record links on multi holds
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:52:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 15:52:48 +0000
Subject: [Koha-bugs] [Bug 19469] Add ability to split view of holds view on
record by pickup library and/or itemtype
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469
--- Comment #54 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #52)
> Links on the "multi holds" view are broken, please fix.
Ok done, it was an easy fix.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:58:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 15:58:30 +0000
Subject: [Koha-bugs] [Bug 19469] Add ability to split view of holds view on
record by pickup library and/or itemtype
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #81828|0 |1
is obsolete| |
--- Comment #55 from Jonathan Druart ---
Created attachment 81829
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81829&action=edit
Bug 19469: Fix record links on multi holds
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:02:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 16:02:24 +0000
Subject: [Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title
without item
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #2 from Jonathan Druart ---
If I hit /reserve/request.pl?biblionumbers=1/2/3&multi_hold=1
I see: https://snag.gy/myA5aP.jpg
The patron search box should not be there. If I search for a patron, I get:
https://snag.gy/tuRJb1.jpg
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:07:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 16:07:46 +0000
Subject: [Koha-bugs] [Bug 21751] New: staff lists not displaying properly in
Chrome
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751
Bug ID: 21751
Summary: staff lists not displaying properly in Chrome
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Lists
Assignee: koha-bugs at lists.koha-community.org
Reporter: lucas at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
CC: m.de.rooy at rijksmuseum.nl
Created attachment 81830
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81830&action=edit
screenshot of public list in Chrome
There is a display issue in Chrome (Firefox seems unaffected) at
cgi-bin/koha/virtualshelves/shelves.pl
The table header is overlapped by the toolbar (#searchheader) because of its
absolute positioning. See attachment.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:12:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 16:12:18 +0000
Subject: [Koha-bugs] [Bug 20182] Remove group by clause in
search_patrons_to_anonymise
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20182
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |21723
--- Comment #6 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #3)
> (In reply to Julian Maurice from comment #2)
> > So it basically just added a GROUP BY with all columns. Can it affect
> > performances ?
>
> EXPLAIN tells me it should not.
Looking at bug 21723, it may be wrong.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21723
[Bug 21723] batch_anonymise.pl SQL-query runs out of memory
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:12:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 16:12:18 +0000
Subject: [Koha-bugs] [Bug 21723] batch_anonymise.pl SQL-query runs out of
memory
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21723
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |20182
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20182
[Bug 20182] Remove group by clause in search_patrons_to_anonymise
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:17:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 16:17:00 +0000
Subject: [Koha-bugs] [Bug 21751] "#searchheader" toolbar not displaying
properly in Chrome
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|staff lists not displaying |"#searchheader" toolbar not
|properly in Chrome |displaying properly in
| |Chrome
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:18:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 16:18:13 +0000
Subject: [Koha-bugs] [Bug 21751] "#searchheader" toolbar not displaying
properly in Chrome
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751
--- Comment #1 from Lucas Gass ---
Actually, this is effecting all pages where the "#searchheader" toolbar is
present.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:21:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 16:21:58 +0000
Subject: [Koha-bugs] [Bug 21723] batch_anonymise.pl SQL-query runs out of
memory
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21723
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|18.05 |master
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #1 from Jonathan Druart ---
Hi Andreas,
Could you compare the execution time between this query and the same but with
the GROUP BY clause that would contain 'borrowernumber' only?
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:22:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 16:22:48 +0000
Subject: [Koha-bugs] [Bug 21723] batch_anonymise.pl SQL-query runs out of
memory
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21723
--- Comment #2 from Jonathan Druart ---
Created attachment 81831
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81831&action=edit
Bug 21723: Do no retrieve already anonymised entries
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:23:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 16:23:53 +0000
Subject: [Koha-bugs] [Bug 21723] batch_anonymise.pl SQL-query runs out of
memory
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21723
--- Comment #3 from Jonathan Druart ---
Also I would be interesting to compare with the query generated with this
patch.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:31:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 16:31:51 +0000
Subject: [Koha-bugs] [Bug 21709] Addbiblio shows tag editor icons which do
nothing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709
--- Comment #6 from Jonathan Druart ---
Created attachment 81832
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81832&action=edit
Bug 21709: Replace 'no popup' plugin links with a span
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:32:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 16:32:34 +0000
Subject: [Koha-bugs] [Bug 21709] Addbiblio shows tag editor icons which do
nothing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709
--- Comment #7 from Jonathan Druart ---
Like that? Also I am wondering if we should not remove some classes, I do not
know what is the purpose of .buttonDot
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:32:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 16:32:47 +0000
Subject: [Koha-bugs] [Bug 21709] Addbiblio shows tag editor icons which do
nothing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |In Discussion
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:36:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Nov 2018 16:36:51 +0000
Subject: [Koha-bugs] [Bug 21457] datelastseen and datelastborrowed out of
sync
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21457
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #1 from Jonathan Druart