From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 00:06:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Oct 2018 23:06:55 +0000 Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 --- Comment #23 from David Cook --- (In reply to Julian Maurice from comment #21) > I don't think we can, psgi.input is defined only when running in a PSGI > environment (app run by starman for instance) and $c->req->env is an empty > hashref when the app is run by morbo or hypnotoad. Ahhh, I see. I forgot about morbo and hypnotoad. Neither CGI nor PSGI, they're totally bespoke Mojolicious web servers it seems? I guess that's why they would be more optimized for Mojolicious... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 00:09:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Oct 2018 23:09:01 +0000 Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 --- Comment #24 from David Cook --- (In reply to Julian Maurice from comment #22) > Created attachment 81687 [details] [review] > Bug 20582: Handle multipart content-type > > Mojo::Message::Request's body attribute does not contain anything when > the content-type is multipart/* > We have to rebuild the multipart body for CGI scripts > > Test plan: > 1. Go to Tools ? Upload and try to upload a file Seems such a shame that Mojolicious doesn't just provide the actual original body of the message... I was just idly curious about this bug so I'll leave testing to Jerome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 00:12:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Oct 2018 23:12:10 +0000 Subject: [Koha-bugs] [Bug 20525] Add --timezone switch to koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20525 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 00:20:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Oct 2018 23:20:27 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #29 from David Cook --- I am so confused by this bug. Isn't the inventory already sorting by call number? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 00:46:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Oct 2018 23:46:17 +0000 Subject: [Koha-bugs] [Bug 21732] If an item is marked as lost, any outstanding transfers upon it should be cancelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 --- Comment #13 from Alex Buckley --- Created attachment 81782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81782&action=edit Bug 21732: (follow-up) Added tests to t/db_dependent/Circulation.t Tests check: * If transfer is deleted when item is marked as lost with the LostItemCancelOutstandingTransfer enabled and disabled * If the items holdingbranch changes when item with transfers on it is marked as lost. Also added call to ModItem() when transfers are deleted (if the LostItemCancelOutstandingTransfers syspref is enabled and a transfer did exist on the item) to set the items holdingbranch to the transfer source branch so the 'from' library is responsible for the lost item. Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 00:48:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Oct 2018 23:48:51 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 --- Comment #30 from Carl --- Yes, it's sorted by call number but that does not sort correctly. It should be sorted by items.cn_sort which will sort correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 00:50:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Oct 2018 23:50:30 +0000 Subject: [Koha-bugs] [Bug 21732] If an item is marked as lost, any outstanding transfers upon it should be cancelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #14 from Alex Buckley --- Hi there I have added tests to t/db_dependent/Circulation.t and a change of the items holdingbranch to the 'from' branch when the syspref is enabled. I am not sure what data inconsistencies script you are referring to Jonathan? I will set this to 'Needs signoff' for now as I have addressed Martin's point in comment #3 and Katrin's point in comment #9. Please let me know if you'd like me to make further changes. Cheers, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 00:52:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Oct 2018 23:52:19 +0000 Subject: [Koha-bugs] [Bug 18926] Web installer doesn't work with plack enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18926 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- I think I've run the web installer on Plack and it has upgraded but it does get stuck in a loop. Once I restart Plack, then everything is fine. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 03:37:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 02:37:42 +0000 Subject: [Koha-bugs] [Bug 21662] Missing Developers from history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #9 from Liz Rea --- That's right, that page is updated daily from Master. I've fixed the encoding - the database had been installed in latin1, it's now UTF8. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 03:57:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 02:57:03 +0000 Subject: [Koha-bugs] [Bug 18677] issue_id is not added to accountlines for lost item fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 --- Comment #17 from M. Tompsett --- (In reply to Jonathan Druart from comment #16) > There is only 1 call, from C4::Circulation::LostItem, the occurrence in > C4::Overdues is part of a comment So it is. Still, I thought the general thrust of development was to move towards the Koha namespace, and if not, perhaps hashref the parameter list, so that at least it gets closer to our coding guidelines. https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL16:_Hashrefs_should_be_used_as_arguments Also, that comment in C4::Overdues makes me wonder about a tiny refactor / move into the Koha name space. But perhaps that is beyond the scope of this. Changing the parameter to a hashref should be a simple enough fix. Though, I do think putting the lookup in the function, rather than in the calling function, and thus avoid the need to change the parameter list, is probably better. Less files affected. Less is more. It's not like chargelostitems is called for the same thing multiple times, is it? If it is, the external look up and hashref parameter is probably preferred. After all, we don't want to slow things down either. To summarize: if there are no speed issues caused by a double call, then moving the look up into the function is the preferred fix. If there is a speed issue, then hashref'ing the parameter list and leaving it external is preferred. Just my take on it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 04:52:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 03:52:15 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 --- Comment #31 from David Cook --- (In reply to Carl from comment #30) > Yes, it's sorted by call number but that does not sort correctly. It should > be sorted by items.cn_sort which will sort correctly. I am certain that I just looked at this a couple months ago and it was using the normalized call numbers. I had an issue where the normalized call numbers were wrong for old records, but after re-generating the values, all was well. Let me see if I can find any details on that issue I had... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 04:53:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 03:53:43 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 --- Comment #32 from David Cook --- Here we go... https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21447 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 04:56:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 03:56:04 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 --- Comment #33 from David Cook --- (In reply to David Cook from comment #32) > Here we go... > > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21447 I wish that I had written that bug report better. In hindsight, I think maybe #19915 fixes the underlying problem that I observed, which means that both the list view and export views should be fixed after these changes... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 06:12:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 05:12:48 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79039|0 |1 is obsolete| | --- Comment #203 from David Cook --- Created attachment 81783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81783&action=edit Bug 10662: Build OAI-PMH Harvesting Client This patch adds an OAI-PMH harvesting client to Koha. The client runs as a daemon in the background. Users interact with the client via the Koha web user interface, which communicates with the daemon via a unix socket using a simple JSON-based protocol. The harvester ingests MARCXML. You can harvest other metadata formats, but you must use a XSLT to transform them into MARCXML, if you want them to be imported into Koha. You can supply your own download and import modules via the oai-pmh-harvester.yaml configuration file, but the default modules supplied in this patch should be good enough for your purposes. If they're not, raise a Bugzilla issue. There is a cleanup_database.pl addition, because high volume harvesting will cause the oai_harvester_import_queue table to fill quickly. This table is not required for adding/updating records. It's mostly just for general monitoring and audit purposes. Signed-off-by: Andreas Hedstr?m Mace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 06:13:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 05:13:00 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #204 from David Cook --- Created attachment 81784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81784&action=edit Bug 10662: (QA follow-up) addressing qa test tool output I've done the following in this follow-up: - Added missing POD - Replaced DBIC use with Koha::Object[s] - Replaced DataTables with KohaTable - Fixed database charset and collation - Moved Javascript to bottom of templates - Fixed a syntax error in rewrite-config.PL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 06:14:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 05:14:47 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #205 from David Cook --- Do I change it to Signed Off or back to Needs Signoff? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 06:16:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 05:16:18 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #206 from David Cook --- Btw, there will be some QA test tool failures, but they should all be false and stem from this issue: https://gitlab.com/koha-community/qa-test-tools/issues/4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 08:06:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 07:06:44 +0000 Subject: [Koha-bugs] [Bug 21744] New: Getting Error 500 e trying to Upload patron images Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21744 Bug ID: 21744 Summary: Getting Error 500 e trying to Upload patron images Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: harjinder.nagi at serosoft.in QA Contact: testopia at bugs.koha-community.org Created attachment 81785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81785&action=edit attached document contains the images Getting Error 500 e trying to Upload patron images -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 08:38:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 07:38:57 +0000 Subject: [Koha-bugs] [Bug 21662] Missing Developers from history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 --- Comment #10 from Martin Renvoize --- Excellent, thanks Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:07:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 08:07:57 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #207 from Josef Moravec --- What is the intention on commented out code in koha-tmpl/intranet-tmpl/prog/en/modules/tools/oai-pmh-harvester/dashboard.tt in table with saved_requests? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:11:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 08:11:05 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #208 from Josef Moravec --- In tables for history and requests you have column import_matcher_code, that is bad I think, you should always use matcher_id and make it foreign key to marc_matchers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:14:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 08:14:23 +0000 Subject: [Koha-bugs] [Bug 21744] Getting Error 500 e trying to Upload patron images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21744 Harjinder Singh Nagi changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 --- Comment #1 from Harjinder Singh Nagi --- Library: Unitedworld School of Law Koha version: 17.11.05.000 Apache version: Server version: Apache/2.4.18 (Ubuntu) Registration date: 04/05/2018 Expiration date: 04/08/2026 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:17:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 08:17:02 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #186 from Joonas Kylm?l? --- Comment on attachment 78690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78690 Bug 19893 - Alternative optimized indexing for Elasticsearch Review of attachment 78690: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19893&attachment=78690) ----------------------------------------------------------------- ::: Koha/SearchEngine/Elasticsearch.pm @@ +34,5 @@ > use Try::Tiny; > use YAML::Syck; > > +use List::Util qw( sum0 reduce ); > +use Search::Elasticsearch; use Search::Elasticsearch; is already defined above -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:17:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 08:17:18 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #187 from Joonas Kylm?l? --- Comment on attachment 81284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81284 Bug 19893: Add pods, remove syspref, add tests for serialization format Review of attachment 81284: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19893&attachment=81284) ----------------------------------------------------------------- ::: Koha/SearchEngine/Elasticsearch.pm @@ +329,5 @@ > +The source data from a MARC record field. > + > +=item C<$record_document> > + > +Hashref representing the Elasticsearch document on which mappings should be applied. extra space between "the Elasticsearch" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:22:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 08:22:31 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #188 from Joonas Kylm?l? --- Comment on attachment 78690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78690 Bug 19893 - Alternative optimized indexing for Elasticsearch Review of attachment 78690: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19893&attachment=78690) ----------------------------------------------------------------- ::: Koha/SearchEngine/Elasticsearch.pm @@ +333,5 @@ > + } > + push @{$record_document->{$target}}, $_data; > + } > + } > + foreach my $record (@{$records}) { Instead of stacking multiple for loops here, we can move this block to its own function, maybe called marc_record_to_document. This should make it easier to understand the code as the for loop would be then named and code doesn't go horizontally off the screen, right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:25:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 08:25:06 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #209 from Josef Moravec --- Created attachment 81786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81786&action=edit Encoding problem + datatable In submitted requests table I encountered a encoding problem: "Knihovna ?st??" should be "Knihovna ?st?". Also, the heading of datatable is usually formatted in one line, see patron circulation history for example. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:29:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 08:29:02 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #210 from Josef Moravec --- (In reply to Josef Moravec from comment #209) > Created attachment 81786 [details] > Encoding problem + datatable > > In submitted requests table I encountered a encoding problem: > > "Knihovna ?st??" should be "Knihovna ?st?". > > Also, the heading of datatable is usually formatted in one line, see patron > circulation history for example. I am adding Owen because of the datatable styling. Owen, what would you suggest? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:43:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 08:43:01 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #211 from Josef Moravec --- Comment on attachment 81783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81783 Bug 10662: Build OAI-PMH Harvesting Client Review of attachment 81783: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10662&attachment=81783) ----------------------------------------------------------------- ::: Koha/OAI/Harvester/Worker/Download/Stream.pm @@ +111,5 @@ > + } > + > + #NOTE: Prepare database statement handle > + my $dbh = C4::Context->dbh; > + my $sql = "insert into oai_harvester_import_queue (uuid,result) VALUES (?,?)"; You should not use SQL in Koha modules, use Koha::OAI::Harvester::ImportQueue->new in place of execution of this statement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:50:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 08:50:28 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #189 from Joonas Kylm?l? --- Comment on attachment 81284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81284 Bug 19893: Add pods, remove syspref, add tests for serialization format Review of attachment 81284: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19893&attachment=81284) ----------------------------------------------------------------- ::: Koha/SearchEngine/Elasticsearch.pm @@ +484,5 @@ > > +Get mappings, an internal data structure later used by L<_process_mappings($mappings, $data, $record_document)> > +to process MARC target data, for a MARC mapping. > + > +The returned C<$mappings> is to to be confused with mappings provided by C<_foreach_mapping>, rather this Should be: The returned C<$mappings> is not to be confused with mappings provided by C<_foreach_mapping>, rather this (notice also the extra whitespace) @@ +515,5 @@ > +Elasticsearch document target field type. > + > +=item C<$range> > + > +An optinal range as a string on the format "-" or "", Should be: An optional range as a string in the format "-" or "", @@ +517,5 @@ > +=item C<$range> > + > +An optinal range as a string on the format "-" or "", > +where "" and "" are integers specifying a range that will be used > +for extracting a substing from MARC data as Elasticsearch field target value. substing -> substring @@ +522,5 @@ > + > +The first character position is "1", and the range is inclusive, > +so "1-3" means the first three characters of MARC data. > + > +If only "" is provided only one character as position "" will as position -> at position -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:52:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 08:52:22 +0000 Subject: [Koha-bugs] [Bug 21682] Stock Rotation: Update DB is failing with strict_sql_modes ON In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21682 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81769|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize --- Created attachment 81787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81787&action=edit Bug 21682: Corrections for strict sql in stockrotationrotas Test Plan: 1) Ensure you're database is prior to version 18.06.00.040 2) Ensure 'strict_sql_modes' is enabled 3) Run updatedatabase 4) See no errors during upgrade 5) Run a fresh install 6) Note no errors during database installation Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:52:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 08:52:25 +0000 Subject: [Koha-bugs] [Bug 21682] Stock Rotation: Update DB is failing with strict_sql_modes ON In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21682 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81770|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize --- Created attachment 81788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81788&action=edit Bug 21682: Add update DB entry for existing installs Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:52:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 08:52:41 +0000 Subject: [Koha-bugs] [Bug 21682] Stock Rotation: Update DB is failing with strict_sql_modes ON In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21682 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #25 from Martin Renvoize --- Works for me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 09:59:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 08:59:35 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #212 from Josef Moravec --- Koha/Schema/Result/*.pm changes should be in its own patch, as they are generated. Could you split it please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 10:04:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 09:04:06 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #213 from Josef Moravec --- There are still COLLATE utf8_unicode_ci in column definitions in atomic update and kohastrusture.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 10:13:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 09:13:31 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #190 from Joonas Kylm?l? --- Comment on attachment 81284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81284 Bug 19893: Add pods, remove syspref, add tests for serialization format Review of attachment 81284: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19893&attachment=81284) ----------------------------------------------------------------- ::: Koha/SearchEngine/Elasticsearch.pm @@ +310,5 @@ > return $self->_sort_fields_accessor(); > } > > +=head2 _process_mappings($mappings, $data, $record_document) > + Missing example usage @@ +480,4 @@ > return \@record_documents; > } > > +=head2 _field_mappings($facet, $suggestible, $sort, $target_name, $target_type, $range) This POD is missing example usage: my @mappings = $self->_field_mappings($facet, $suggestible, $sort, $target_name, $target_type, $range) This will be somewhat useful to know what the function returns. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 10:15:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 09:15:09 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #214 from Josef Moravec --- Created attachment 81789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81789&action=edit Bug 10662: (QA follow-up) Fix plural in pod and use statements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 10:15:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 09:15:16 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #215 from Josef Moravec --- Created attachment 81790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81790&action=edit Bug 10662: (QA follow-up) Enhance marc matchers description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 10:37:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 09:37:48 +0000 Subject: [Koha-bugs] [Bug 21316] Adding controlfields to the ACQ framework causes issues when adding to basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21316 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 10:47:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 09:47:05 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #146 from Martin Renvoize --- Ack, of course.. this is where NULL being meaningful is bad :(. Hmm, in a few other projects I enforced via relations and made sure I had a 'hidden' default to replace anywhere I'd want a NULL.. but I think that would be a pretty drastic change.. I'll ponder for a while. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:12:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 11:12:08 +0000 Subject: [Koha-bugs] [Bug 21728] Update C4::Reserves::ChargeReserveFee to use Koha::Account->add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728 --- Comment #1 from Martin Renvoize --- Created attachment 81791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81791&action=edit Bug 21728: Use Koha::Account->add_debit in ChargeReserveFee -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:21:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 11:21:02 +0000 Subject: [Koha-bugs] [Bug 20996] Fix API response time on ILL request endpoint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|7317 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:21:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 11:21:02 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|20996 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996 [Bug 20996] Fix API response time on ILL request endpoint -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:20:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 11:20:51 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #191 from Joonas Kylm?l? --- Comment on attachment 81284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81284 Bug 19893: Add pods, remove syspref, add tests for serialization format Review of attachment 81284: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19893&attachment=81284) ----------------------------------------------------------------- ::: Koha/SearchEngine/Elasticsearch.pm @@ +592,5 @@ > +rules keyed by MARC field tags holding all the mapping rules for that particular tag. > + > +We can then iterate through all MARC fields for each record and apply all relevant > +rules once per fields instead of retreiving fields multiple times for each mapping rule > +wich is terribly slow. wich -> which @@ +605,5 @@ > +sub _get_marc_mapping_rules { > + my ($self) = @_; > + > + my $marcflavour = lc C4::Context->preference('marcflavour'); > + my @rules; There are now two definitions for rules variable. Let's remove this first one. @@ +699,4 @@ > push @{$rules->{leader}}, @mappings; > } > else { > + die("Invalid MARC field: $marc_field"); https://wiki.koha-community.org/wiki/Coding_Guidelines#Perl says "Instead of die or croak when meeting unfavorable conditions in our code, we should raise exceptions via Koha::Exceptions. " There is also "die("Unmatched opening parenthesis for $marc_field");" and maybe others that need to be fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:21:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 11:21:20 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|20600 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 [Bug 20600] Provide the ability for users to filter ILL requests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:21:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 11:21:20 +0000 Subject: [Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Depends on|7317 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:21:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 11:21:35 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|20581 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 [Bug 20581] Allow manual selection of custom ILL request statuses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:21:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 11:21:35 +0000 Subject: [Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|7317 | CC| |martin.renvoize at ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:22:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 11:22:08 +0000 Subject: [Koha-bugs] [Bug 20639] Allow setting a default/single backend for OPAC driven requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|7317 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:22:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 11:22:08 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|20639 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639 [Bug 20639] Allow setting a default/single backend for OPAC driven requests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:22:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 11:22:16 +0000 Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|7317 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:22:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 11:22:16 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|20750 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 [Bug 20750] Allow timestamped auditing of ILL request events -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:22:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 11:22:23 +0000 Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|7317 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:22:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 11:22:23 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|18837 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 [Bug 18837] Add an unmediated Interlibrary Loans workflow -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:22:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 11:22:29 +0000 Subject: [Koha-bugs] [Bug 20563] ILL request list gives no indication of source and/or target In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Depends on|7317 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:22:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 11:22:29 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|20563 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563 [Bug 20563] ILL request list gives no indication of source and/or target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:41:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 11:41:13 +0000 Subject: [Koha-bugs] [Bug 21540] Move bibliographic framework strings out of database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21540 --- Comment #4 from Katrin Fischer --- I think you can't say they are not translatable, but you require a web installer in your language and that would be required with a changed process as well. What is asked for here was multi-language... and that is much harder. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:50:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 11:50:34 +0000 Subject: [Koha-bugs] [Bug 20966] Add column configuration to table of orders in a basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:50:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 11:50:38 +0000 Subject: [Koha-bugs] [Bug 20966] Add column configuration to table of orders in a basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80404|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 81792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81792&action=edit Bug 20966: Add column configuration to table of orders in a basket This patch adds column configuration to the table of orders in a basket. It replaces the "Show all details" checkbox which previously was used to show the hidden "tax included" columns. Now those columns are hidden by default in the columns configuration file. To test, apply the patch and view a basket with multiple orders. Test all DataTables functionality (paging, sorting, filtering) including showing and hiding columns. Test with both an open and a closed basket. Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:50:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 11:50:43 +0000 Subject: [Koha-bugs] [Bug 20966] Add column configuration to table of orders in a basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81636|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 81793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81793&action=edit Bug 20966: (follow-up) Add template variable filter; Fix table export This patch makes to corrections: 1. The "$raw" filter has been added to the column configuration 2. The columns configuration now specifies which columns are exported in Copy, Excel, etc. operations. To test, apply the patch and test the various table export buttons on a both a closed and open basket. Confirm that the 'Modify' and 'Cancel' columns are not exported. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:54:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 11:54:16 +0000 Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 --- Comment #29 from Alex Buckley --- Hi Martin Thanks for your feedback. I have tested and looked through the code calls in /circ/pendingreserves.pl, /tools/batchMod.pl and misc/cronjobs/longoverdue.pl I have noticed they are not consistent in their current handling of the reserves on lost items. * /circ/pendingreserves.pl - This cancels non-waiting item level reserves when item is marked as lost. Doesn't show allocated (waiting) holds. * /tools/batchMod.pl - Doesn?t cancel item-level or allocated bib-level reserves. * /misc/cronjob/longoverdue.pl - Doesn't cancel non-waiting (un-allocated) reserves It would be good to have a consistent approach throughout Koha for dealing with reserves on lost items. A question do you think it would be best to split this patch up so it is only dealing with allocated (waiting) holds. This would alter the behavior of the patches on the bug report which check for reserve type of 'waiting' or 'reserved'. Then we would only need to add reserve handling to /tools/batchMod.pl as longoverdue.pl and pendingreserves.pl don't touch waiting reserves. Amending longoverdue.pl and pendingreserves.pl could go in another bug report building on this to handle un-allocated holds, just to prevent too much scope creep on this bug report? Cheers, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:57:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 11:57:22 +0000 Subject: [Koha-bugs] [Bug 21282] Ordered/spent lists should use prices including tax for calculations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21282 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81003|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 81794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81794&action=edit Bug 21282: Sync ordered and spent values with acqui home The order list for each fund calculates using the ecost tax excl., but it should be tax incl. At the moment this means that the sum on the start page table and the order list don't match up. Test plan: - Create and receive orders - Values on acqui home and ordered/spent should be the same Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:57:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 11:57:18 +0000 Subject: [Koha-bugs] [Bug 21282] Ordered/spent lists should use prices including tax for calculations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21282 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:58:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 11:58:43 +0000 Subject: [Koha-bugs] [Bug 21427] Format prices on ordered/spent lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21427 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21282 --- Comment #8 from Katrin Fischer --- 21282 adds a bit of filters. Waiting for that one. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21282 [Bug 21282] Ordered/spent lists should use prices including tax for calculations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 12:58:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 11:58:43 +0000 Subject: [Koha-bugs] [Bug 21282] Ordered/spent lists should use prices including tax for calculations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21282 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21427 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21427 [Bug 21427] Format prices on ordered/spent lists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:00:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 12:00:58 +0000 Subject: [Koha-bugs] [Bug 21745] New: Checkin of withdrawn items marked successful via SIP2 when BlockReturnOfWithdrawnItems is enabled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21745 Bug ID: 21745 Summary: Checkin of withdrawn items marked successful via SIP2 when BlockReturnOfWithdrawnItems is enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com To recreate: 1 - Mark an item withdrawn 2 - Set up sip server: https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 3 - Set 'BlockReturnOfWithdrawnItems' to block 4 - Use the sip_cli_emulator to checkin the withdrawn item 5 - There is no error in the checkin -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:19:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 12:19:15 +0000 Subject: [Koha-bugs] [Bug 21158] Add cronjob references to the system preference descriptions if a cronjob is required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:19:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 12:19:19 +0000 Subject: [Koha-bugs] [Bug 21158] Add cronjob references to the system preference descriptions if a cronjob is required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81608|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 81795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81795&action=edit Bug 21158: Add cronjob references to the system preference descriptions if a cronjob is required This patch adds references to cronjobs in the description of some system preferences. The following system preference description were modified: - StaticHoldsQueueWeight - ExpireReservesMaxPickUpDelay - AutoResumeSuspendedHolds - finesMode - DefaultLongOverdueLostValue - DefaultLongOverdueChargeValue - PatronSelfRegistrationExpireTemporaryAccountsDelay - PatronSelfRegistrationVerifyByEmail - EnhancedMessagingPreferences - NewItemsDefaultLocation - InProcessingToShelvingCart - ReturnToShelvingCart - ReturnToShelvingCart - AuthorityMergeLimit - OpacBrowser - OpacCloud - UsageStats - PurgeSuggestionsOlderThan - MembershipExpiryDaysNotice To test, check the above mentioned system preferences to make sure the sentence is there and it is correct. Followed test plan and patch is as described Signed-off-by: Alex Buckley Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=12258 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:19:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 12:19:23 +0000 Subject: [Koha-bugs] [Bug 21158] Add cronjob references to the system preference descriptions if a cronjob is required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21158 --- Comment #6 from Katrin Fischer --- Created attachment 81796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81796&action=edit Bug 12258: (QA follow-up) Add some missing rrrrrrs Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:29:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 12:29:09 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #192 from Joonas Kylm?l? --- Comment on attachment 78690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78690 Bug 19893 - Alternative optimized indexing for Elasticsearch Review of attachment 78690: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19893&attachment=78690) ----------------------------------------------------------------- ::: Koha/SearchEngine/Elasticsearch.pm @@ +464,5 @@ > + > + if ($type eq 'sum') { > + push @{$rules->{sum}}, $name; > + } > + elsif($type eq 'boolean') { missing space after elsif ::: t/Koha/SearchEngine/Elasticsearch.t @@ +219,5 @@ > + ); > + } > + }); > + > + my $see = Koha::SearchEngine::Elasticsearch->new({ index => 'biblios' }); Should use $Koha::SearchEngine::BIBLIOS_INDEX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:30:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 12:30:44 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #193 from Joonas Kylm?l? --- Comment on attachment 78692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78692 Bug 19893: Add index status Review of attachment 78692: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19893&attachment=78692) ----------------------------------------------------------------- ::: admin/searchengine/elasticsearch/mappings.pl @@ +47,4 @@ > > my $marc_type = lc C4::Context->preference('marcflavour'); > > +my @index_names = ('biblios', 'authorities'); Should use $Koha::SearchEngine::BIBLIOS_INDEX and $Koha::SearchEngine::AUTHORITIES_INDEX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:33:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 12:33:49 +0000 Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:35:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 12:35:05 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #216 from Josef Moravec --- The Refresh import history button does not work, there is an error in js console: TypeError: history_table.ajax is undefined -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:35:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 12:35:42 +0000 Subject: [Koha-bugs] [Bug 21745] Checkin of withdrawn items marked successful via SIP2 when BlockReturnOfWithdrawnItems is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21745 --- Comment #1 from Nick Clemens --- Some more details: C4/SIP/ILS/Transaction/Checkin.pm does set a 'CV' field to 99 if the item is withdrawn - this doesn't cause a screen message, or set the 'ok' flag to 0 C4/SIP/ILS.pm does not check the CV for 99, or check the value of 'BlockReturnOfLostItems' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:38:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 12:38:54 +0000 Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #34 from Katrin Fischer --- QA tools are green, but there is a problem with the tests. I will continue testing, hoping for a quick follow-up: kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Acquisition.t t/db_dependent/Acquisition.t .. 70/71 DBD::mysql::db do failed: Out of range value for column 'tax_value_on_ordering' at row 1 [for Statement " UPDATE aqorders SET tax_value_on_ordering = quantity * ecost_tax_excluded * tax_rate_on_ordering, tax_value_on_receiving = quantity * unitprice_tax_excluded * tax_rate_on_receiving WHERE ordernumber = ? "] at /home/vagrant/kohaclone/C4/Acquisition.pm line 1484. # No tests run! t/db_dependent/Acquisition.t .. 71/71 # Failed test 'No tests run for subtest "ModReceiveOrder and subscription"' # at t/db_dependent/Acquisition.t line 748. DBD::mysql::db do failed: Out of range value for column 'tax_value_on_ordering' at row 1 [for Statement " UPDATE aqorders SET tax_value_on_ordering = quantity * ecost_tax_excluded * tax_rate_on_ordering, tax_value_on_receiving = quantity * unitprice_tax_excluded * tax_rate_on_receiving WHERE ordernumber = ? "] at /home/vagrant/kohaclone/C4/Acquisition.pm line 1484. # Looks like your test exited with 255 just after 71. t/db_dependent/Acquisition.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/71 subtests Test Summary Report ------------------- t/db_dependent/Acquisition.t (Wstat: 65280 Tests: 71 Failed: 1) Failed test: 71 Non-zero exit status: 255 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:49:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 12:49:08 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72988|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:49:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 12:49:15 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72989|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:53:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 12:53:26 +0000 Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #35 from Jonathan Druart --- Created attachment 81797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81797&action=edit Bug 21467: Prevent tests to fail The following error is raised if TestBuilder generates too big numbers: Out of range value for column 'tax_value_on_ordering' UPDATE aqorders SET tax_value_on_ordering = quantity * ecost_tax_excluded * tax_rate_on_ordering, tax_value_on_receiving = quantity * unitprice_tax_excluded * tax_rate_on_receiving WHERE ordernumber = ? "] at /home/vagrant/kohaclone/C4/Acquisition.pm line 1484. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 13:56:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 12:56:41 +0000 Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #36 from Katrin Fischer --- Created attachment 81798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81798&action=edit Bug 21467: (QA follow-up) Move hint a little bit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:03:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 13:03:44 +0000 Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #37 from Jonathan Druart --- Created attachment 81799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81799&action=edit Bug 21467: (follow-up) Display a summary line per parent_ordernumber Wrong resolution conflict -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:03:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 13:03:53 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:11:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 13:11:08 +0000 Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #38 from Katrin Fischer --- QA tool green, tests tool pass now. Acq tab in subscription detail works correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:50:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 13:50:14 +0000 Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:50:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 13:50:19 +0000 Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #39 from Katrin Fischer --- Created attachment 81800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81800&action=edit Bug 21474: Add the Koha::Subscription->frequency method And the 2 modules for the subscriptions' frequencies Test plan: prove t/db_dependent/Koha/Subscription.t must return green Signed-off-by: Josef Moravec Signed-off-by: S?verine QUEUNE Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=21475 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:50:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 13:50:23 +0000 Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81394|0 |1 is obsolete| | --- Comment #40 from Katrin Fischer --- Created attachment 81801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81801&action=edit Bug 21467: Allow several receipts for a given subscription When a new order is created from a subscription the quantity is set to 1 and cannot be modified. The idea was to order 1 subscription. This behavior leads to a limitation: it is not possible to mark a receipt as partially received. However it is how it works in real life, the vendors send invoices throughout the year. The number of items can also be changed. The idea is be to rethink the "quantity" value for an order created from a subscription and use it to track the number of invoices already paid. FIXME: This approach will not cohabit with standing orders. This patch is a first draft to get feedback on the idea. FIXME: What about cancelled orders? Test plan: - Create a new order from a subscription - Enter the number of items you think you will receive for this subscription (for instance 1 per month: 12) - Close the basket - Receive 3 items (a trimester) and create a specific invoice for this receipt. Note that the price are per unit. If you want to receive items with different prices you should make split the receipt - Receive more items. This time you will notice that the previous order will be displayed on the "order receive" under a new block "Receipt history for this subscription" - Note that the "Quantity to receive" has been decrease by the number of items you previously received - Also you can notice that this "Quantity to receive" can be modified. Indeed it can happen that the number of items to receive changed during the year - Go to the detail of the subscription and notice that the orders have been grouped by "parent ordernumber" - Continue to receive items until all have been received Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: S?verine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:50:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 13:50:32 +0000 Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81396|0 |1 is obsolete| | --- Comment #42 from Katrin Fischer --- Created attachment 81803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81803&action=edit Bug 21467: Add subscription's info when ordering When ordering from a subscription, there is now a "hint" to display the number of issues and the frequency. It will be easier to estimate the quantity to receive. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: S?verine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:50:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 13:50:28 +0000 Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81395|0 |1 is obsolete| | --- Comment #41 from Katrin Fischer --- Created attachment 81802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81802&action=edit Bug 21467: Add treetable to subscription detail to group orders by parent ordernumber Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: S?verine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:50:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 13:50:37 +0000 Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81397|0 |1 is obsolete| | --- Comment #43 from Katrin Fischer --- Created attachment 81804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81804&action=edit Bug 21467: Do not erase the internal note of the first order For the subscription we would like to keep the original internal note (from the first order), to display it unmodified each time we receive issues. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: S?verine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:50:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 13:50:41 +0000 Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81398|0 |1 is obsolete| | --- Comment #44 from Katrin Fischer --- Created attachment 81805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81805&action=edit Bug 21467: Display the quantity and adjust the amounts On the subscription detail view we should display the amounts depending on the quantity (can be different than 0 now!) Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: S?verine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:50:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 13:50:46 +0000 Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81399|0 |1 is obsolete| | --- Comment #45 from Katrin Fischer --- Created attachment 81806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81806&action=edit Bug 21467: Fix default sort Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: S?verine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:50:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 13:50:50 +0000 Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81400|0 |1 is obsolete| | --- Comment #46 from Katrin Fischer --- Created attachment 81807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81807&action=edit Bug 21467: Display a summary line per parent_ordernumber This will help to keep track of the different orders for a given subscription. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: S?verine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:50:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 13:50:55 +0000 Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81430|0 |1 is obsolete| | --- Comment #47 from Katrin Fischer --- Created attachment 81808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81808&action=edit Bug 21467: (QA follow-up) Fix filter and variable declaration in .t Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:50:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 13:50:59 +0000 Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81797|0 |1 is obsolete| | --- Comment #48 from Katrin Fischer --- Created attachment 81809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81809&action=edit Bug 21467: Prevent tests to fail The following error is raised if TestBuilder generates too big numbers: Out of range value for column 'tax_value_on_ordering' UPDATE aqorders SET tax_value_on_ordering = quantity * ecost_tax_excluded * tax_rate_on_ordering, tax_value_on_receiving = quantity * unitprice_tax_excluded * tax_rate_on_receiving WHERE ordernumber = ? "] at /home/vagrant/kohaclone/C4/Acquisition.pm line 1484. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:51:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 13:51:04 +0000 Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81798|0 |1 is obsolete| | --- Comment #49 from Katrin Fischer --- Created attachment 81810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81810&action=edit Bug 21467: (QA follow-up) Move hint a little bit Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:51:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 13:51:09 +0000 Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81799|0 |1 is obsolete| | --- Comment #50 from Katrin Fischer --- Created attachment 81811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81811&action=edit Bug 21467: (follow-up) Display a summary line per parent_ordernumber Wrong resolution conflict Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:51:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 13:51:22 +0000 Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81800|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 14:55:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 13:55:03 +0000 Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #51 from Katrin Fischer --- I believe this is great in its flexibility and will work much better for acquisition of serials than the standing order feature. You will be able to handle an end-of-year invoice or being charged by issue. The amounts will be encumbered for the year. I think the only thing missing now would be an option to bring those orders into the next year, but the duplicate order line feature also waiting will help with that :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:02:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:02:16 +0000 Subject: [Koha-bugs] [Bug 20489] Prevent DB user login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21746 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 [Bug 21746] Remove NO_LIBRARY_SET -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:02:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:02:16 +0000 Subject: [Koha-bugs] [Bug 21746] New: Remove NO_LIBRARY_SET Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 Bug ID: 21746 Summary: Remove NO_LIBRARY_SET Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 20489 NO_LIBRARY_SET was used when the DB user was logged in. Since bug 20489 it's not longer possible. We could remove the code. We also have 2 TT variables: LoginBranchcode, LoginBranchname And 1 template method, Branches.GetLoggedInBranchcode. We could simplify and unify that code Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 [Bug 20489] Prevent DB user login -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:04:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:04:35 +0000 Subject: [Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:04:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:04:42 +0000 Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:10:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:10:08 +0000 Subject: [Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 [Bug 21002] Add Koha::Account::add_debit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:10:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:10:08 +0000 Subject: [Koha-bugs] [Bug 21002] Add Koha::Account::add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21747 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:09:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:09:49 +0000 Subject: [Koha-bugs] [Bug 21747] New: Update C4::Overdues::UpdateFine to use Koha::Account->add_debit Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Bug ID: 21747 Summary: Update C4::Overdues::UpdateFine to use Koha::Account->add_debit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org All account handling should go via the Koha::Account class. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:11:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:11:24 +0000 Subject: [Koha-bugs] [Bug 21748] New: Update C4::Overdues::UpdateFine to use Koha::Account->update_debit Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21748 Bug ID: 21748 Summary: Update C4::Overdues::UpdateFine to use Koha::Account->update_debit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org All account handling should go via the Koha::Account class. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:12:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:12:06 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21748 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21748 [Bug 21748] Update C4::Overdues::UpdateFine to use Koha::Account->update_debit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:12:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:12:06 +0000 Subject: [Koha-bugs] [Bug 21748] Update C4::Overdues::UpdateFine to use Koha::Account->update_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21748 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Depends on| |21727 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 [Bug 21727] Add Koha::Account::update_debit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:12:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:12:06 +0000 Subject: [Koha-bugs] [Bug 21727] Add Koha::Account::update_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21748 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21748 [Bug 21748] Update C4::Overdues::UpdateFine to use Koha::Account->update_debit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:12:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:12:34 +0000 Subject: [Koha-bugs] [Bug 21727] Add Koha::Account::update_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:12:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:12:34 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21727 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 [Bug 21727] Add Koha::Account::update_debit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:13:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:13:28 +0000 Subject: [Koha-bugs] [Bug 21727] Add Koha::Account::update_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21002 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 [Bug 21002] Add Koha::Account::add_debit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:13:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:13:28 +0000 Subject: [Koha-bugs] [Bug 21002] Add Koha::Account::add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|21727 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 [Bug 21727] Add Koha::Account::update_debit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:14:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:14:17 +0000 Subject: [Koha-bugs] [Bug 21002] Add Koha::Account::add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen at gmail.com |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:26:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:26:19 +0000 Subject: [Koha-bugs] [Bug 21725] Incorrect HAVING in group by in Acquisitions.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21725 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:26:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:26:25 +0000 Subject: [Koha-bugs] [Bug 21725] Incorrect HAVING in group by in Acquisitions.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21725 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81626|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 81812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81812&action=edit Bug 21725: Use full statement in HAVING rather than constructed column To test: 1 - prove -v t/db_dpendent/Acquisition/GetBasketsInfosByBookseller.t 2 - Apply patch 3 - prove -v t/db_dpendent/Acquisition/GetBasketsInfosByBookseller.t 4 - It passes 5 - Have some open/closed and some fully and not full received baskets 6 - View a vendor and confirm baskets are shwn as expected 7 - Check 'Show all baskets' shows all baskets Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Note sure this is the best thing but it fixes the issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:28:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:28:41 +0000 Subject: [Koha-bugs] [Bug 21556] Deleting same record twice leads to fatal software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21556 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:28:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:28:47 +0000 Subject: [Koha-bugs] [Bug 21556] Deleting same record twice leads to fatal software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21556 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80560|0 |1 is obsolete| | Attachment #80685|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 81813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81813&action=edit Bug 21556: Deleting same record twice leads to fatal software error If you delete a record, confirm the deletion, and try to delete the record and confirm it again befoe the first deletion completes, you'll generate a fatal software error. This patch unbinds the click handlers for the "Delete record" button after the deletion is confirmed and just before the Javascript processes the redirect to the next page in the process. To test: 1) You will need a bibliographic record that is able to be deleted 2) Click "Edit", then "Delete record", then "OK" 3) While the browser is reloading, click "Edit", then "Delete record", then "OK 4) Observe a fatal error such as "Internal server error" or 'Can't call method "holds" on an undefined value at /home/vagrant/kohaclone/C4/Biblio.pm line 406.' 5) Apply the patch 6) Run "restart_all" on kohadevbox (or otherwise restart Plack if running Plack) 7) Navigate to another bibliographic record that is able to be deleted 8) Click "Edit", then "Delete record", then "OK" 9) While the browser is reloading, click "Edit", then "Delete record" 10) Observe that no fatal software error is generated 11) You are redirected to http://localhost:8081/cgi-bin/koha/catalogue/search.pl (on kohadevbox) Signed-off-by: Pierre-Marc Thibault Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:28:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:28:53 +0000 Subject: [Koha-bugs] [Bug 21556] Deleting same record twice leads to fatal software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21556 --- Comment #14 from Jonathan Druart --- Created attachment 81814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81814&action=edit Bug 21556: Do not crash if a biblio is deleted twice To recreate: - Go to a bibliographic detail page - Delete it - Go back - Delete it again => Without this patch you will get a 500 Can't call method "holds" on an undefined value at /home/vagrant/kohaclone/C4/Biblio.pm line 406. => With this patch applied it will silently redirect you to the search form. Note: We could/should improve the behavior and display a message, but DelBiblio will need to be moved to Koha::Biblio->delete and other callers adjusted Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:30:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:30:45 +0000 Subject: [Koha-bugs] [Bug 18677] issue_id is not added to accountlines for lost item fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED Assignee|kyle at bywatersolutions.com |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #18 from Jonathan Druart --- Working on an alternative patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:33:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:33:57 +0000 Subject: [Koha-bugs] [Bug 21682] Stock Rotation: Update DB is failing with strict_sql_modes ON In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21682 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81788|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart --- Created attachment 81815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81815&action=edit Bug 21682: Add update DB entry for existing installs Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:34:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:34:43 +0000 Subject: [Koha-bugs] [Bug 21682] Stock Rotation: Update DB is failing with strict_sql_modes ON In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21682 --- Comment #27 from Jonathan Druart --- I amended the last patch to move atomicupdate/bug_21620.perl to atomicupdate/bug_21682.perl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:46:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:46:17 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:46:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:46:20 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76721|0 |1 is obsolete| | Attachment #76722|0 |1 is obsolete| | Attachment #76723|0 |1 is obsolete| | Attachment #76724|0 |1 is obsolete| | --- Comment #34 from Nick Clemens --- Created attachment 81816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81816&action=edit Bug 19915: Add unit test to GetItemsForInventory.t prove -v t/db_dependent/Items/GetItemsForInventory.t Signed-off-by: Anne-Claire Bernaudin Signed-off-by: Marcel de Rooy Moved the betwen typo edit back here. Current patch-complexity: Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:46:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:46:24 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 --- Comment #35 from Nick Clemens --- Created attachment 81817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81817&action=edit Bug 19915: (QA follow-up) Tidy up GetItemsForInventory.t Standard edits like modules, schema, Koha objects instead of DBIC. Removing unneeded autoflush. Moving initial test to a first subtest. No need to clear issues if you clear items. Adding a FIXME for OldWay; would be nice to remove that code.. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:46:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:46:29 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 --- Comment #36 from Nick Clemens --- Created attachment 81818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81818&action=edit Bug 19915: Use cn_sort values for getting inventory items To test: 1 - Catalog an item under LCC with callnumber GT95 2 - cn_sort should calculate as GT0095 3 - Go to inventory tool 4 - Enter a range that should have your item e.g LC GT90 to GT100 5 - Item is not returned 6 - Apply patch 7 - Item should be returned 8 - Verify things otherwise work as expected Signed-off-by: Anne-Claire Bernaudin Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:46:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:46:34 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 --- Comment #37 from Nick Clemens --- Created attachment 81819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81819&action=edit Bug 19915: Only show class sources in use Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:46:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:46:38 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 --- Comment #38 from Nick Clemens --- Created attachment 81820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81820&action=edit Bug 19915: Don't delete in tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:46:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:46:47 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 --- Comment #39 from Nick Clemens --- Created attachment 81821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81821&action=edit Bug 19915: Make behaviour syspref controlled To test: 0 - Apply patch, run updatedatabase 1 - Catalog an item under LCC classification source with callnumber GT95 2 - Check db, cn_sort should calculate as GT0095 SELECT cn_sort FROM items where callnumber="GT95"; 3 - Catalog an item under LCC classification source with callnumber GT101 4 - Check db, cn_sort should calculate as GT0101 SELECT cn_sort FROM items where callnumber="GT101"; 5 - Go to inventory tool 6 - Enter a range from GT90 to GT100 7 - Neither item is not returned 8 - Enter range from GT100 to GT90 9 - Second item is returned 10 - Set UseCNSortForInventory to 'Use' 11 - Go to invenotry tool 12 - Enter a range from GT90 to GT100 13 - The first item is returned, the second is not 14 - Enter a range from GT100 to GT90 15 - Neither item is returned 16 - prove -v t/db_dependent/Items/GetItemsForInventory.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:47:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:47:47 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #194 from David Gustafsson --- Created attachment 81822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81822&action=edit Bug 19893: Add code review fixes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:48:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:48:48 +0000 Subject: [Koha-bugs] [Bug 18677] issue_id is not added to accountlines for lost item fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:48:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:48:57 +0000 Subject: [Koha-bugs] [Bug 18677] issue_id is not added to accountlines for lost item fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 --- Comment #19 from Jonathan Druart --- Created attachment 81823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81823&action=edit Bug 18677: Make the tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:49:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:49:11 +0000 Subject: [Koha-bugs] [Bug 18677] issue_id is not added to accountlines for lost item fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 --- Comment #20 from Jonathan Druart --- Created attachment 81824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81824&action=edit Bug 18677: Remove new issue_id param from charlostitem We have the itemnumber no need to pass the issue_id, we can retrieve it from chargelostitem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:50:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:50:20 +0000 Subject: [Koha-bugs] [Bug 18677] issue_id is not added to accountlines for lost item fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at bugs.koha-c |kyle at bywatersolutions.com |ommunity.org | --- Comment #21 from Jonathan Druart --- (In reply to Jonathan Druart from comment #18) > Working on an alternative patch. I have attached 2 follow-ups, back to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:55:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:55:29 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #195 from David Gustafsson --- Ok, thanks for the feedback! I think I fixed most things except: (In reply to Joonas Kylm?l? from comment #188) > Comment on attachment 78690 [details] [review] > Bug 19893 - Alternative optimized indexing for Elasticsearch > > Review of attachment 78690 [details] [review]: > ----------------------------------------------------------------- > > ::: Koha/SearchEngine/Elasticsearch.pm > @@ +333,5 @@ > > + } > > + push @{$record_document->{$target}}, $_data; > > + } > > + } > > + foreach my $record (@{$records}) { > > Instead of stacking multiple for loops here, we can move this block to its > own function, maybe called marc_record_to_document. This should make it > easier to understand the code as the for loop would be then named and code > doesn't go horizontally off the screen, right? I don't get the line numbers to match up, but perhaps I'm using a different base. I don't recognize this code in my current branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 15:58:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 14:58:09 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #196 from David Gustafsson --- I also took the liberty to fix commit line length to 80 (perhaps not for all comments though), since some where a bit long. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:06:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 15:06:00 +0000 Subject: [Koha-bugs] [Bug 21749] New: Importing MARC frameworks from pre-9701 fails Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21749 Bug ID: 21749 Summary: Importing MARC frameworks from pre-9701 fails Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org If you import a MARC framework that has been exported from a previous version of Koha (17.11 and below) results in an empty MARC framework, without any error reporting to the end user. This is because of the added columns in 'marc_tag_structure' (ind1_defaultvalue and ind2_defaultvalue) and the fact that we don't have a fallback behaviour when they are not present on the uploaded file. My opinion is we should check the table header (from CSV or whatever format) and let the DB use the default values if a column is missing. I mark it as Major, because there's no possible data recovery after the failed import. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:06:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 15:06:10 +0000 Subject: [Koha-bugs] [Bug 9701] Configure default indicators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21749 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21749 [Bug 21749] Importing MARC frameworks from pre-9701 fails -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:06:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 15:06:10 +0000 Subject: [Koha-bugs] [Bug 21749] Importing MARC frameworks from pre-9701 fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21749 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9701 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 [Bug 9701] Configure default indicators -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:11:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 15:11:45 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #57 from Martin Renvoize --- (In reply to M. Tompsett from comment #48) > (In reply to Katrin Fischer from comment #46) > > I think search_by doesn't sound quite right... search_on? search_in? Native > > speaker? :) > > search_for? I don't like filter_by, because filter_by suggests we are taking > a given set and shrinking it. No such thing is passed. We are searching, but > it is limited for a particular set of conditions. The rest would describe > the condition. And why not just get_by_marc_field (would do tagfield, but > tagsubfield is included, I believe), get_by_kohafield? But you are filtering... you pass in a resultset (whether that be a new one or an existing already partially filtered one) and then refine it by filtering down... We're trying to bring consistency to the objects, so to me filter_by which is already being discussed elsewhere seems to make sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:14:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 15:14:02 +0000 Subject: [Koha-bugs] [Bug 21750] New: Move collection code to its own column in checkins table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21750 Bug ID: 21750 Summary: Move collection code to its own column in checkins table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently the collection is displayed as part of the itemtype column. It should be its own column -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:18:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 15:18:38 +0000 Subject: [Koha-bugs] [Bug 20194] Display both biblioitems.itemtype and items.itype in circulation screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20194 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21750 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21750 [Bug 21750] Move collection code to its own column in checkins table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:18:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 15:18:41 +0000 Subject: [Koha-bugs] [Bug 21750] Move collection code to its own column in checkins table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21750 --- Comment #1 from Nick Clemens --- Created attachment 81825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81825&action=edit Bug 21750: Move collection code to its own column on checkins table To test: 1 - Set 'ShowAllCheckins' to show 2 - Set a collcection code for an item 3 - Check it in 4 - Note it displays in the the 'Item type' column 5 - Apply patch 6 - Check it in again 7 - Note the new 'Collection' column 8 - Hide/show the column using column visibility on the checkins page 9 - Go to Admin->Configure columns 10 - Test the various settings for this column and check in the item to make sure they work as expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:18:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 15:18:49 +0000 Subject: [Koha-bugs] [Bug 21750] Move collection code to its own column in checkins table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21750 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:18:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 15:18:38 +0000 Subject: [Koha-bugs] [Bug 21750] Move collection code to its own column in checkins table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21750 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Depends on| |20194 Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20194 [Bug 20194] Display both biblioitems.itemtype and items.itype in circulation screens -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:30:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 15:30:15 +0000 Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640 --- Comment #22 from Martin Renvoize --- Created attachment 81827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81827&action=edit Bug 20640: (follow-up) Degrade gracefully on error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:30:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 15:30:11 +0000 Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80900|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize --- Created attachment 81826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81826&action=edit Bug 20640: Add backend migration support to ILL - Add core methods required to support the migration of ILL requests between backends. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:31:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 15:31:25 +0000 Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640 --- Comment #23 from Martin Renvoize --- I've added a more graceful failure mode should a backend fail to load or fail to support the migrate action. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:46:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 15:46:01 +0000 Subject: [Koha-bugs] [Bug 21526] TT variables used to build a link should be uri filtered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_11_candidate Severity|normal |blocker --- Comment #25 from Jonathan Druart --- Upping severity to get the attention it needs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:47:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 15:47:51 +0000 Subject: [Koha-bugs] [Bug 15296] MEMBER logging in action_logs does not give enough detail. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15296 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:50:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 15:50:31 +0000 Subject: [Koha-bugs] [Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 --- Comment #52 from Jonathan Druart --- Links on the "multi holds" view are broken, please fix. To recreate: - Search - Select few records - Click "Place hold" => On "Home ? Catalog ? Confirm holds" the link of the record does not have a biblionumber value, the link is "/cgi-bin/koha/catalogue/detail.pl?biblionumber=" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:50:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 15:50:46 +0000 Subject: [Koha-bugs] [Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:52:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 15:52:15 +0000 Subject: [Koha-bugs] [Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 --- Comment #53 from Jonathan Druart --- Created attachment 81828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81828&action=edit Bug 19469: Fix record links on multi holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:52:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 15:52:48 +0000 Subject: [Koha-bugs] [Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 --- Comment #54 from Jonathan Druart --- (In reply to Jonathan Druart from comment #52) > Links on the "multi holds" view are broken, please fix. Ok done, it was an easy fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 16:58:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 15:58:30 +0000 Subject: [Koha-bugs] [Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81828|0 |1 is obsolete| | --- Comment #55 from Jonathan Druart --- Created attachment 81829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81829&action=edit Bug 19469: Fix record links on multi holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:02:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 16:02:24 +0000 Subject: [Koha-bugs] [Bug 21738] [ILS-DI] error while holding a title without item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- If I hit /reserve/request.pl?biblionumbers=1/2/3&multi_hold=1 I see: https://snag.gy/myA5aP.jpg The patron search box should not be there. If I search for a patron, I get: https://snag.gy/tuRJb1.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:07:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 16:07:46 +0000 Subject: [Koha-bugs] [Bug 21751] New: staff lists not displaying properly in Chrome Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 Bug ID: 21751 Summary: staff lists not displaying properly in Chrome Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 81830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81830&action=edit screenshot of public list in Chrome There is a display issue in Chrome (Firefox seems unaffected) at cgi-bin/koha/virtualshelves/shelves.pl The table header is overlapped by the toolbar (#searchheader) because of its absolute positioning. See attachment. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:12:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 16:12:18 +0000 Subject: [Koha-bugs] [Bug 20182] Remove group by clause in search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20182 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21723 --- Comment #6 from Jonathan Druart --- (In reply to Jonathan Druart from comment #3) > (In reply to Julian Maurice from comment #2) > > So it basically just added a GROUP BY with all columns. Can it affect > > performances ? > > EXPLAIN tells me it should not. Looking at bug 21723, it may be wrong. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21723 [Bug 21723] batch_anonymise.pl SQL-query runs out of memory -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:12:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 16:12:18 +0000 Subject: [Koha-bugs] [Bug 21723] batch_anonymise.pl SQL-query runs out of memory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21723 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20182 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20182 [Bug 20182] Remove group by clause in search_patrons_to_anonymise -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:17:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 16:17:00 +0000 Subject: [Koha-bugs] [Bug 21751] "#searchheader" toolbar not displaying properly in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|staff lists not displaying |"#searchheader" toolbar not |properly in Chrome |displaying properly in | |Chrome -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:18:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 16:18:13 +0000 Subject: [Koha-bugs] [Bug 21751] "#searchheader" toolbar not displaying properly in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 --- Comment #1 from Lucas Gass --- Actually, this is effecting all pages where the "#searchheader" toolbar is present. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:21:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 16:21:58 +0000 Subject: [Koha-bugs] [Bug 21723] batch_anonymise.pl SQL-query runs out of memory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21723 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.05 |master CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Hi Andreas, Could you compare the execution time between this query and the same but with the GROUP BY clause that would contain 'borrowernumber' only? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:22:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 16:22:48 +0000 Subject: [Koha-bugs] [Bug 21723] batch_anonymise.pl SQL-query runs out of memory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21723 --- Comment #2 from Jonathan Druart --- Created attachment 81831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81831&action=edit Bug 21723: Do no retrieve already anonymised entries -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:23:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 16:23:53 +0000 Subject: [Koha-bugs] [Bug 21723] batch_anonymise.pl SQL-query runs out of memory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21723 --- Comment #3 from Jonathan Druart --- Also I would be interesting to compare with the query generated with this patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:31:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 16:31:51 +0000 Subject: [Koha-bugs] [Bug 21709] Addbiblio shows tag editor icons which do nothing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 --- Comment #6 from Jonathan Druart --- Created attachment 81832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81832&action=edit Bug 21709: Replace 'no popup' plugin links with a span -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:32:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 16:32:34 +0000 Subject: [Koha-bugs] [Bug 21709] Addbiblio shows tag editor icons which do nothing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 --- Comment #7 from Jonathan Druart --- Like that? Also I am wondering if we should not remove some classes, I do not know what is the purpose of .buttonDot -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:32:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 16:32:47 +0000 Subject: [Koha-bugs] [Bug 21709] Addbiblio shows tag editor icons which do nothing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:36:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 16:36:51 +0000 Subject: [Koha-bugs] [Bug 21457] datelastseen and datelastborrowed out of sync In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21457 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- What are the values? SELECT datelastborrowed, datelastseen FROM items WHERE datelastborrowed > datelastseen LIMIT 10; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:40:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 16:40:24 +0000 Subject: [Koha-bugs] [Bug 21392] Some tables not available to AUTO_RENEW letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21392 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15705 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 [Bug 15705] Notify the user on auto renewing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:40:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 16:40:24 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21392 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21392 [Bug 21392] Some tables not available to AUTO_RENEW letter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:49:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 16:49:38 +0000 Subject: [Koha-bugs] [Bug 21414] view_borrower_infos_from_any_libraries can't be used with IndependentBranches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21414 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18403 CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21255 --- Comment #1 from Jonathan Druart --- Yes, I think we could replace some of our features with the new "library group" mechanism. IndependentBranchesPatronModifications, IndependentBranches, "Branches limitations" for patron's categories and AV, etc. Not trivial however. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:49:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 16:49:38 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21414 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21414 [Bug 21414] view_borrower_infos_from_any_libraries can't be used with IndependentBranches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:49:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 16:49:38 +0000 Subject: [Koha-bugs] [Bug 21255] memberetnry.pl is missing categories in the Category pull-down list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21255 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21414 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 17:57:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 16:57:17 +0000 Subject: [Koha-bugs] [Bug 20059] Option to allow checkin of non-issued items without setting SIP-alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20059 --- Comment #3 from Colin Campbell --- Have you thought about the interaction with the change introduced by bug 13411. Also 13411s change is set in the config file this is set as syspref, it would be better to have a consistent approach -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 18:53:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 17:53:12 +0000 Subject: [Koha-bugs] [Bug 21752] New: request.pl does not allow to revert Waiting to Priority 1 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21752 Bug ID: 21752 Summary: request.pl does not allow to revert Waiting to Priority 1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 21611 fixes a problem with the priority status, but full functionality is not restored. If an item is marked as waiting, there is NO WAY to set it back to a priority level. To test: 1) Place item on hold. 2) Check in the item to trigger the hold. 3) Look at requests.pl. Note waiting status. 4) Try to set to priority 1 instead of waiting. You can't. Can only delete. 5) Place another hold on the same item with another patron. 6) Look at requests.pl. Note one waiting status and one priority 1 status. 7) Note that priority 1 is now an option on the waiting hold, but you can't select it! Expected behavior: Change waiting status to priority 1. If there is more than one hold, change it to whatever hold level needed, and bump the rest of the priorities below that accordingly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 18:53:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 17:53:38 +0000 Subject: [Koha-bugs] [Bug 21752] request.pl does not allow to revert Waiting to Priority 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21752 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21611 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21611 [Bug 21611] Priority in request.pl shows 1 instead of Waiting -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 18:53:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 17:53:38 +0000 Subject: [Koha-bugs] [Bug 21611] Priority in request.pl shows 1 instead of Waiting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21611 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21752 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21752 [Bug 21752] request.pl does not allow to revert Waiting to Priority 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 18:57:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 17:57:31 +0000 Subject: [Koha-bugs] [Bug 21752] request.pl does not allow to revert Waiting to priority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21752 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED Summary|request.pl does not allow |request.pl does not allow |to revert Waiting to |to revert Waiting to |Priority 1 |priority --- Comment #1 from Christopher Brannon --- *** This bug has been marked as a duplicate of bug 21608 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 18:57:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 17:57:31 +0000 Subject: [Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #15 from Christopher Brannon --- *** Bug 21752 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 19:32:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 18:32:29 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 19:32:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 18:32:33 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #58 from Nick Clemens --- Created attachment 81833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81833&action=edit Bug 15774: (follow-up) Address QA issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 19:39:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 18:39:20 +0000 Subject: [Koha-bugs] [Bug 21717] TestBuilder.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21717 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 19:39:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 18:39:24 +0000 Subject: [Koha-bugs] [Bug 21717] TestBuilder.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21717 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81607|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 81834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81834&action=edit Bug 21717: Fix generation of real's values With strict SQL modes we now have TestBuilder tests that fail randomly with: Out of range value for column 'tax_rate_on_receiving' Out of range value for column 'discount' We are trying to insert a value that is too high for the type defined at DB level. It happens for discount when a value > 100 is generated. The datatype is float(6,4). >From the MySQL Doc: """ MySQL permits a nonstandard syntax: FLOAT(M,D) or REAL(M,D) or DOUBLE PRECISION(M,D). Here, (M,D) means than values can be stored with up to M digits in total, of which D digits may be after the decimal point. """ So float(6,4) does not allow 100. To recreate easily the issue: use t::lib::TestBuilder; my $builder = t::lib::TestBuilder->new; $builder->build( { source => 'Aqorder', value => { discount => 100 } } )->{discount}; To make sure this patch fixes the issue you can use this script: use Modern::Perl; use t::lib::TestBuilder; my $builder = t::lib::TestBuilder->new; my ( $real, $i ) = ( 0, 0 ); while ( $real < 100 ) { $real = $builder->_gen_real( { info => { size => [ 6, 4 ] } } ); warn $i++; } warn "$i - $real"; Test plan: 0/ Does not apply this patch 1/ Run the snippet above 2/ Confirm that it fails quite quickly (constantly before 500 for me) 3/ Apply this patch 4/ Run again the script 5/ Confirm that it is stuck in an infinite loop 6/ CTRL-C :D QA Note: Other _gen_* subroutine may need a fix, but we will wait for them to fail TODO: 1. Add JS check to the interface to prevent the use to enter a value > 100 2. Allow '100' as a valid value for discount (?) Followed test plan, patch worked as described Signed-off-by: Alex Buckley Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 19:48:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 18:48:00 +0000 Subject: [Koha-bugs] [Bug 21414] view_borrower_infos_from_any_libraries can't be used with IndependentBranches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21414 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 19:56:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 18:56:41 +0000 Subject: [Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 19:56:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 18:56:44 +0000 Subject: [Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #16 from Nick Clemens --- Created attachment 81835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81835&action=edit Bug 21608: (follow-up) Use RevertWaitingStatus and do not alter _FixPriority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 20:09:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 19:09:21 +0000 Subject: [Koha-bugs] [Bug 21476] Incorrect filter prevents HTML5 media from playing in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21476 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 20:09:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 19:09:33 +0000 Subject: [Koha-bugs] [Bug 21556] Deleting same record twice leads to fatal software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21556 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #15 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 20:09:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 19:09:44 +0000 Subject: [Koha-bugs] [Bug 21585] Ignore missing firstname in ILL requests table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21585 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #9 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 20:10:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 19:10:10 +0000 Subject: [Koha-bugs] [Bug 21717] TestBuilder.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21717 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 20:09:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 19:09:58 +0000 Subject: [Koha-bugs] [Bug 21682] Stock Rotation: Update DB is failing with strict_sql_modes ON In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21682 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #28 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 20:10:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 19:10:22 +0000 Subject: [Koha-bugs] [Bug 21725] Incorrect HAVING in group by in Acquisitions.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21725 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 20:10:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 19:10:33 +0000 Subject: [Koha-bugs] [Bug 21742] Incorrect count of youtube videos In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21742 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #2 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 20:17:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 19:17:49 +0000 Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Brian changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bklein at dubuque.lib.ia.us --- Comment #8 from Brian --- Could we please get an update on this bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 20:42:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 19:42:42 +0000 Subject: [Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from "Holds over" tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 Brian changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bklein at dubuque.lib.ia.us --- Comment #24 from Brian --- Any updates on the 15561 bug? Carnegie Stout Team would be grateful -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 20:46:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 19:46:12 +0000 Subject: [Koha-bugs] [Bug 19486] When cancelling a waiting hold via circulation the patron is charged the ExpireReservesMaxPickUpDelayCharge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19486 Brian changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bklein at dubuque.lib.ia.us --- Comment #3 from Brian --- Any updates on the 19486 bug? Carnegie Stout Team would be grateful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 20:46:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 19:46:57 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #127 from Cori Lynn Arnold --- 10. Try creating a rule with tag set to "008" (or other control field) and set Appended: Append and Removed: Skip, the other options does not matter. Verify that saving this rule produces an error message complaining about invalid combination of actions for control field. ==Error is generated, but rule still is created. User has to delete the invalid rule. Seems like it shouldn't be created as with the other error conditions. 11. With the 245a rule in step 5 in place, edit a bibliographic record, change 245a (which should be Title for MARC21) and save. 12. Verify that the changes has not been saved. ==Changes *are* saved. Attempted to edit a record already in the catalog, and creating a new one via Z39 search. Can you clarify how these rules should be applied for "edit record"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 20:52:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 19:52:06 +0000 Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Brian changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bklein at dubuque.lib.ia.us --- Comment #16 from Brian --- Has there been any more updates on bug 17140? Carnegie Stout Team. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 21:00:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 20:00:55 +0000 Subject: [Koha-bugs] [Bug 21427] Format prices on ordered/spent lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21427 Brian changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bklein at dubuque.lib.ia.us --- Comment #9 from Brian --- what's the status of bug 21427? Carnegie Stout Team -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 21:02:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 20:02:07 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Brian changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bklein at dubuque.lib.ia.us --- Comment #128 from Brian --- Whats the status of bug 18736? Carnegie Stout Team -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 21:09:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 20:09:25 +0000 Subject: [Koha-bugs] [Bug 21753] New: issuingrules.chargename is unused and should be removed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21753 Bug ID: 21753 Summary: issuingrules.chargename is unused and should be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org There is no way to set the chargename field in the issuingrules table and there is at least one FIXME (in C4::Overdues::CalcFine) stating that it is never set. A decade has passed since the FIXME was added to C4::Overdues, and nothing has changed. We should remove the field now ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 21:10:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 20:10:52 +0000 Subject: [Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21753 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21753 [Bug 21753] issuingrules.chargename is unused and should be removed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 21:10:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 20:10:52 +0000 Subject: [Koha-bugs] [Bug 21753] issuingrules.chargename is unused and should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21753 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21747 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 21:11:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 20:11:52 +0000 Subject: [Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update |Update |C4::Overdues::UpdateFine to |C4::Overdues::UpdateFine to |use |use |Koha::Account->add_debit |Koha::Account->add_debit | |and | |Koha::Account::Line->adjust -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 21:13:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 20:13:18 +0000 Subject: [Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 21:13:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 20:13:18 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21747 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 21:15:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 20:15:05 +0000 Subject: [Koha-bugs] [Bug 21748] Update C4::Overdues::UpdateFine to use Koha::Account->update_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21748 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Martin Renvoize --- *** This bug has been marked as a duplicate of bug 21747 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 21:15:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 20:15:05 +0000 Subject: [Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 --- Comment #1 from Martin Renvoize --- *** Bug 21748 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 21:15:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 20:15:05 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Bug 14825 depends on bug 21748, which changed state. Bug 21748 Summary: Update C4::Overdues::UpdateFine to use Koha::Account->update_debit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21748 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 21:15:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 20:15:48 +0000 Subject: [Koha-bugs] [Bug 21727] Add Koha::Account::update_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21747 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 21:15:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 20:15:48 +0000 Subject: [Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21727 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 [Bug 21727] Add Koha::Account::update_debit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 21:17:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 20:17:40 +0000 Subject: [Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add |Add |Koha::Account::update_debit |Koha::Account::Line->adjust -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 21:18:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 20:18:22 +0000 Subject: [Koha-bugs] [Bug 21748] Update C4::Overdues::UpdateFine to use Koha::Account->update_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21748 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21727 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 [Bug 21727] Add Koha::Account::Line->adjust -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 21:18:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 20:18:22 +0000 Subject: [Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|21748 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21748 [Bug 21748] Update C4::Overdues::UpdateFine to use Koha::Account->update_debit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 21:20:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 20:20:49 +0000 Subject: [Koha-bugs] [Bug 21753] issuingrules.chargename is unused and should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21753 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 21:20:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 20:20:52 +0000 Subject: [Koha-bugs] [Bug 20508] Validation for *MandatoryField and *UnwantedField sysprefs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20508 Brian changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bklein at dubuque.lib.ia.us --- Comment #1 from Brian --- Any updates on bug 20508? Carnegie Stout Team -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 21:22:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 20:22:08 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 21:26:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 20:26:10 +0000 Subject: [Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79686|0 |1 is obsolete| | Attachment #80879|0 |1 is obsolete| | Attachment #81100|0 |1 is obsolete| | --- Comment #30 from Christopher Brannon --- Created attachment 81836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81836&action=edit Bug 21346: Streamline logic in holds and transfers 1) Replaced comparison with string to make testing branch easier. 2) Replaced useless 0 values with undef. Does not change any behavior, only simplifies code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 22:08:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 21:08:25 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81490|0 |1 is obsolete| | Attachment #81491|0 |1 is obsolete| | Attachment #81492|0 |1 is obsolete| | Attachment #81493|0 |1 is obsolete| | Attachment #81494|0 |1 is obsolete| | Attachment #81495|0 |1 is obsolete| | Attachment #81496|0 |1 is obsolete| | Attachment #81497|0 |1 is obsolete| | Attachment #81833|0 |1 is obsolete| | --- Comment #59 from Jonathan Druart --- Created attachment 81837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81837&action=edit Bug 15774: Add additional fields to order baskets This also moves the admin page for additional fields for all tables to a single common screen, and factors out display/input parsing logic. Test plan: 1. Create an additional field for a subscription (under Serials -> Add subscription fields). 2. Apply patch. 3. Visit Additional fields under administration, and verify that the field created above still shows under the list for the subscription table. 4. Create at least four fields for aqbasket for each combination of searchable/not-searchable and with/without an authorized value. 5. Create an order basket, and verify that all fields are visible and correctly save. 6. Edit the basket, verifying that changes to these additional fields are saved. 7. Add an order to the basket (contents are irrelevant). 8. Go to advanced search within acquisitions. 9. Verify that only the searchable fields show in the form, and that their contents may be searched. Signed-off-by: S?verine QUEUNE Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 22:08:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 21:08:34 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #60 from Jonathan Druart --- Created attachment 81838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81838&action=edit Bug 15774: (QA follow-up) Make sure that tablename is correctly saved Signed-off-by: S?verine QUEUNE Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 22:08:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 21:08:44 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #61 from Jonathan Druart --- Created attachment 81839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81839&action=edit Bug 15774: Fix additional fields filters Addresses the following QA comments: 1/ Regression: On serials/serials-search.pl, the filters are not filled with what the users searched for and the additional fields linked to an AV are not displayed as a dropdown list. 4/ When searching an order, there is no way not to set a "all" value for additional fields linked to AV. 5/ When searching an order and the search does not return any results, the field should contain what the user filled in. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774#c10 Signed-off-by: S?verine QUEUNE Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 22:08:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 21:08:53 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #62 from Jonathan Druart --- Created attachment 81840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81840&action=edit Bug 15774: Use Koha::Object(s) for additional fields A lot of code can be removed just by using Koha::Object It also makes fetching and updating additional field values easier. Signed-off-by: S?verine QUEUNE Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 22:09:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 21:09:01 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #63 from Jonathan Druart --- Created attachment 81841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81841&action=edit Bug 15774: Add POD and license notices Signed-off-by: S?verine QUEUNE Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 22:09:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 21:09:09 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #64 from Jonathan Druart --- Created attachment 81842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81842&action=edit Bug 15774: Show additional field values in edit form Signed-off-by: S?verine QUEUNE Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 22:09:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 21:09:18 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #65 from Jonathan Druart --- Created attachment 81843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81843&action=edit Bug 15774: (follow-up) Add html filters Signed-off-by: S?verine QUEUNE Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 22:09:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 21:09:27 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #66 from Jonathan Druart --- Created attachment 81844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81844&action=edit Bug 15774: Fix JS check when AV and MARC field are both selected Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 22:09:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 21:09:44 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #68 from Jonathan Druart --- Created attachment 81846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81846&action=edit Bug 15774: Use the include file to display the subscription's additional fields We have it, why not to use it? Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 22:09:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 21:09:53 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #69 from Jonathan Druart --- Created attachment 81847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81847&action=edit Bug 15774: Fix insert and update for subscription Call it a typo Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 22:09:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 21:09:34 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #67 from Jonathan Druart --- Created attachment 81845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81845&action=edit Bug 15774: (follow-up) Address QA issues Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 22:10:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 21:10:02 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #70 from Jonathan Druart --- Created attachment 81848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81848&action=edit Bug 15774: Add missing tests for GetSubscription Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 22:10:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 21:10:11 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #71 from Jonathan Druart --- Created attachment 81849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81849&action=edit Bug 15774: Add missing tests for Koha::Object::Mixin::AdditionalFields Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 22:10:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 21:10:19 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #72 from Jonathan Druart --- Created attachment 81850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81850&action=edit Bug 15774: Fix and unify additional_fields in C4::Serials Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 22:10:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 21:10:28 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #73 from Jonathan Druart --- Created attachment 81851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81851&action=edit Bug 15774: Do not fetch additional fields from GetSubscription Finally we do not want that, they should be fetch when needed Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 22:10:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 21:10:37 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #74 from Jonathan Druart --- Created attachment 81852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81852&action=edit Bug 15774: Remove unecessary returned value for ->delete Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 22:11:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 21:11:53 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81848|0 |1 is obsolete| | --- Comment #75 from Jonathan Druart --- Comment on attachment 81848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81848 Bug 15774: Add missing tests for GetSubscription We finally do not need that I'd say. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 22:12:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 21:12:12 +0000 Subject: [Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #31 from Christopher Brannon --- Created attachment 81853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81853&action=edit Bug 21346: Remove double dialog To Test: 1) Place a hold on an item for pickup at another branch. 2) Check in item to trigger hold and transfer. 3) Check in item again without changing location. Note modal AND old dialog behind modal. 4) Apply patch. 5) Check in item again without changing location. Note modal without the old dialog. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 22:16:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 21:16:21 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 22:17:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 21:17:03 +0000 Subject: [Koha-bugs] [Bug 21205] C4::Acquisition - Remove GetOrderFromItemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[DEP_15184] C4::Acquisition |C4::Acquisition - Remove |- Remove |GetOrderFromItemnumber |GetOrderFromItemnumber | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 22:26:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 21:26:28 +0000 Subject: [Koha-bugs] [Bug 21754] New: If an item is marked as lost, any outstanding transfers upon it should be automatically cancelled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 Bug ID: 21754 Summary: If an item is marked as lost, any outstanding transfers upon it should be automatically cancelled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When an item is marked as lost automatically cancel any outstanding transfers on it (this is an alternative to bug 21732 - https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732- which checks if a syspref is enabled before cancelling outstanding transfers on the lost item). Also set the items holding branch to the transfers source ('from') branch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 22:33:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 21:33:51 +0000 Subject: [Koha-bugs] [Bug 21751] "#searchheader" toolbar not displaying properly in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- (In reply to Lucas Gass from comment #1) > Actually, this is effecting all pages where the "#searchheader" toolbar is > present. Sure about that? On which other views do you recreate the problem? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 23:05:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 22:05:57 +0000 Subject: [Koha-bugs] [Bug 21751] "#searchheader" toolbar not displaying properly in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 --- Comment #3 from Lucas Gass --- No, I may be wrong about that. I can only successfully recreate it on the lists view. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 23:09:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 22:09:51 +0000 Subject: [Koha-bugs] [Bug 21754] If an item is marked as lost, any outstanding transfers upon it should be automatically cancelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 --- Comment #1 from Alex Buckley --- Created attachment 81854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81854&action=edit Bug 21754: Automatically clean up outstanding transfers on lost items This is an alternative to bug 21732 as transfers are automatically cancelled on marking an item lost, and the items holding rbanch is set to the transfers source ('from') branch. When an item is marked as lost, the routine should also clean up any outstanding transfers. Also added tests to t/db_dependent/Circulation.t which check: * If transfer is automatically deleted when item is marked as lost * If the items holdingbranch automatically changes when item with transfers on it is marked as lost. Test plan: 1. Find a item which is in transfer, i.e. find an item with the text in the 'Status' field of the table in detail.pl that indicates it is in transfer 2. Set the item to 'Lost' either by clicking on Edit->Edit items from the detail.pl page OR clicking on the Items tab on the left side of the detail.pl page 3. Notice that the transfer is now cancelled for the item and the items holdingbranch is the transfers source ('from') branch 4. Run t/db_dependent/Circulation.t Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 23:10:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 22:10:32 +0000 Subject: [Koha-bugs] [Bug 21754] If an item is marked as lost, any outstanding transfers upon it should be automatically cancelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21732 Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 23:10:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 22:10:32 +0000 Subject: [Koha-bugs] [Bug 21732] If an item is marked as lost, any outstanding transfers upon it should be cancelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21754 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 1 23:24:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 22:24:18 +0000 Subject: [Koha-bugs] [Bug 21751] "#searchheader" toolbar not displaying properly in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 --- Comment #4 from Jonathan Druart --- On the mailing list (https://lists.katipo.co.nz/pipermail/koha/2018-October/051753.html) Elaine reported an overlap of the tabs on top of the toolbar, but I cannot recreate it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 00:45:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Nov 2018 23:45:04 +0000 Subject: [Koha-bugs] [Bug 21732] If an item is marked as lost, any outstanding transfers upon it should be cancelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732 --- Comment #15 from Alex Buckley --- Hi there I have made another bug report Bug 21754 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754) which does not use a system preference to determine if outstanding transfers on an item marked as lost are cancelled. Instead, my patch on bug 21754 automatically cancels outstanding transfers on lost items and sets the items holding branch to the cancelled transfers source ('from') branch. Therefore with bug 21732 and bug 21754 we should be covered for whatever responses/concensus comes back to your questions in the Koha mailing list Martin. Bug 21752 also contains tests in the t/db_dependent/Circulation.t Could bugs 21732 and 21754 please be tested and QA? Cheers, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 01:01:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 00:01:26 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #217 from David Cook --- (In reply to Josef Moravec from comment #207) > What is the intention on commented out code in > koha-tmpl/intranet-tmpl/prog/en/modules/tools/oai-pmh-harvester/dashboard.tt > in table with saved_requests? Originally, I displayed a lot more information in this table, but I commented it out, as I thought it would be too much. I kept it in comments in case during QA people thought there should be more information. This way I wouldn't have to rewrite it all out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 01:03:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 00:03:13 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #218 from David Cook --- (In reply to Josef Moravec from comment #208) > In tables for history and requests you have column import_matcher_code, that > is bad I think, you should always use matcher_id and make it foreign key to > marc_matchers. I can see why you'd say that, but import_matcher_code is an optional field, so it can't be a foreign key. 99.99% of requests should never ever use that field, but it was added for libraries that might want to initially match against an existing set of records so they don't get duplicates when first starting harvesting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 01:04:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 00:04:04 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #219 from David Cook --- (In reply to Josef Moravec from comment #209) > Created attachment 81786 [details] > Encoding problem + datatable > > In submitted requests table I encountered a encoding problem: > > "Knihovna ?st??" should be "Knihovna ?st?". > > Also, the heading of datatable is usually formatted in one line, see patron > circulation history for example. That's strange. I've never had this problem before. I will try to reproduce. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 01:04:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 00:04:51 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #220 from David Cook --- (In reply to Josef Moravec from comment #210) > (In reply to Josef Moravec from comment #209) > > Created attachment 81786 [details] > > Encoding problem + datatable > > > > In submitted requests table I encountered a encoding problem: > > > > "Knihovna ?st??" should be "Knihovna ?st?". > > > > Also, the heading of datatable is usually formatted in one line, see patron > > circulation history for example. > > I am adding Owen because of the datatable styling. > > Owen, what would you suggest? I just added KohaTable as requested. If someone can provide additional details regarding styling, I'd be happy to change it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 01:10:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 00:10:01 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #221 from David Cook --- (In reply to Josef Moravec from comment #211) > Comment on attachment 81783 [details] [review] > Bug 10662: Build OAI-PMH Harvesting Client > > Review of attachment 81783 [details] [review]: > ----------------------------------------------------------------- > > ::: Koha/OAI/Harvester/Worker/Download/Stream.pm > @@ +111,5 @@ > > + } > > + > > + #NOTE: Prepare database statement handle > > + my $dbh = C4::Context->dbh; > > + my $sql = "insert into oai_harvester_import_queue (uuid,result) VALUES (?,?)"; > > You should not use SQL in Koha modules, use > Koha::OAI::Harvester::ImportQueue->new in place of execution of this > statement Ordinarily, I would agree. However, Koha::Object[s] use DBIx::Class, which is very slow. If you read more of Koha::OAI::Harvester::Download::Stream, you'll see that I re-use the same prepared statement handle (something we unfortunately have never done in Koha), which makes the inserts much much much faster. Here I'm aiming for high performance. DBIx::Class was built for convenience rather than performance, so I've opted to use DBI and SQL, as it's just so much faster. As a side note, Tomas and I chatted a bit at Kohacon about making the harvester's workers use Koha's plugins, so perhaps this is something where the built-in for Koha could use DBIC, and I could provide a more high performance plugin outside of Koha. Although it seems a shame that we'd prefer low performance over high performance :/. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 01:10:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 00:10:32 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #222 from David Cook --- (In reply to Josef Moravec from comment #212) > Koha/Schema/Result/*.pm changes should be in its own patch, as they are > generated. Could you split it please? Good point. I have done that in the past, and I can certainly do that here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 01:11:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 00:11:39 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #223 from David Cook --- (In reply to Josef Moravec from comment #213) > There are still COLLATE utf8_unicode_ci in column definitions in atomic > update and kohastrusture.sql Oh I see at the column level. I did the table level but must have missed those. I'll fix that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 01:13:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 00:13:40 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #224 from David Cook --- Comment on attachment 81789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81789 Bug 10662: (QA follow-up) Fix plural in pod and use statements Review of attachment 81789: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10662&attachment=81789) ----------------------------------------------------------------- ::: Koha/OAI/Harvester/Import/Record.pm @@ +29,4 @@ > > use Koha::OAI::Harvester::Import::MARCXML; > use Koha::OAI::Harvester::Biblios; > +use Koha::OAI::Harvester::Histories; This actually should be Koha::OAI::Harvester::History and not Koha::OAI::Harvester::Histories. This change breaks the harvester. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 01:14:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 00:14:56 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #225 from David Cook --- (In reply to Josef Moravec from comment #216) > The Refresh import history button does not work, there is an error in js > console: > > TypeError: history_table.ajax is undefined That's very strange. I tested this before uploading and it was fine. I will add your follow-ups and try to reproduce. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 01:23:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 00:23:22 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #226 from David Cook --- Interesting... I can't even submit a task with a name of "Knihovna ?st?". The harvester is failing to add it. I'll look into it. And I am getting "Refresh import history" errors now too. Maybe I didn't double-check after converting to KohaTable. I'm getting a different error though: Uncaught TypeError: Cannot read property 'reload' of undefined at HTMLButtonElement. (dashboard.pl?op=send&id=1:1082) at HTMLButtonElement.dispatch (jquery-2.2.3.min_18.0600047.js:3) at HTMLButtonElement.r.handle (jquery-2.2.3.min_18.0600047.js:3) Looking into both of these now... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 01:48:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 00:48:54 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #227 from David Cook --- (In reply to David Cook from comment #226) > Interesting... > > I can't even submit a task with a name of "Knihovna ?st?". The harvester is > failing to add it. I'll look into it. > > And I am getting "Refresh import history" errors now too. Maybe I didn't > double-check after converting to KohaTable. I'm getting a different error > though: > > Uncaught TypeError: Cannot read property 'reload' of undefined > at HTMLButtonElement. (dashboard.pl?op=send&id=1:1082) > at HTMLButtonElement.dispatch (jquery-2.2.3.min_18.0600047.js:3) > at HTMLButtonElement.r.handle (jquery-2.2.3.min_18.0600047.js:3) > > Looking into both of these now... I think KohaTable is breaking some functionality from DataTables, because I should be able to do this on a KohaTable: https://datatables.net/reference/api/ajax.reload() -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 01:58:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 00:58:58 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #228 from David Cook --- (In reply to David Cook from comment #227) > I think KohaTable is breaking some functionality from DataTables, because I > should be able to do this on a KohaTable: > https://datatables.net/reference/api/ajax.reload() I think KohaTable is using the legacy API and DataTables allowed me to use the current API. Uploading screenshots to show the different objects returned by DataTable and KohaTable... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 01:59:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 00:59:43 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #229 from David Cook --- Created attachment 81855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81855&action=edit Object returned by KohaTable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 02:00:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 01:00:07 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #230 from David Cook --- Created attachment 81856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81856&action=edit Object returned by DataTable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 02:08:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 01:08:01 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #231 from David Cook --- (In reply to David Cook from comment #228) > (In reply to David Cook from comment #227) > > I think KohaTable is breaking some functionality from DataTables, because I > > should be able to do this on a KohaTable: > > https://datatables.net/reference/api/ajax.reload() > > I think KohaTable is using the legacy API and DataTables allowed me to use > the current API. > > Uploading screenshots to show the different objects returned by DataTable > and KohaTable... OK I figured it out. When using "$( selector ).DataTable();", the return value is the API object. When using KohaTable, the return value is the jQuery object. So I just needed to add .dataTable().api() to the back of the jQuery object to access the DataTable API. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 02:46:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 01:46:42 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #232 from David Cook --- (In reply to David Cook from comment #226) > Interesting... > > I can't even submit a task with a name of "Knihovna ?st?". The harvester is > failing to add it. I'll look into it. Ah, I see the problem I was having. Just me being silly. Now I see the problem. I have some ideas with this one... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 03:09:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 02:09:28 +0000 Subject: [Koha-bugs] [Bug 21746] Remove NO_LIBRARY_SET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21746 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #1 from M. Tompsett --- NO_LIBRARY_SET is also used for the initial web install, which requires the DB user. So, probably not entirely removing NO_LIBRARY_SET, because the branches table won't even exist at the initial web install. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 03:54:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 02:54:56 +0000 Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 --- Comment #25 from Jerome Charaoui --- Created attachment 81857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81857&action=edit Fix PDF generation Here's a patch to fix generating PDFs from the Acquisitions module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 03:58:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 02:58:33 +0000 Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 --- Comment #26 from Jerome Charaoui --- (In reply to Julian Maurice from comment #22) > Created attachment 81687 [details] [review] > Bug 20582: Handle multipart content-type > > Mojo::Message::Request's body attribute does not contain anything when > the content-type is multipart/* > We have to rebuild the multipart body for CGI scripts > > Test plan: > 1. Go to Tools ? Upload and try to upload a file Thank you for being so quick to provide a patch! I can confirm that it fixes upload functions within Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 05:16:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 04:16:39 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #233 from David Cook --- (In reply to Josef Moravec from comment #209) > Created attachment 81786 [details] > Encoding problem + datatable > > In submitted requests table I encountered a encoding problem: > > "Knihovna ?st??" should be "Knihovna ?st?". > > Also, the heading of datatable is usually formatted in one line, see patron > circulation history for example. I am stumped by this one. I've added a Encode::Decode("UTF-8",$json_message") to the client used by the web page, and that gets the characters to render as Knihovna ?st? on the web page... but when I look at the actual hex code in the variable... it's not valid UTF8. It's Windows 1252/Latin-1. The hex is 4b6e69686f766e6120da7374ed, and the internal representation in Perl is PV = 0xa6bce80 "Knihovna \303\232st\303\255"\0 [UTF8 "Knihovna \x{da}st\x{ed}"]. So DA and ED are Unicode code points that match ? and ? (https://www.utf8-chartable.de/unicode-utf8-table.pl). However, DA and ED are also the Latin-1 hex for ? and ? (https://en.wikipedia.org/wiki/Windows-1252)(https://en.wikipedia.org/wiki/ISO/IEC_8859-1). I think maybe I need to try with some Chinese characters that don't exist in Latin-1... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 05:19:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 04:19:22 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #234 from David Cook --- Yep... put in some Chinese characters and now that decode isn't working either. Let's try this again... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 06:21:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 05:21:26 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #235 from David Cook --- (In reply to Josef Moravec from comment #209) > Created attachment 81786 [details] > Encoding problem + datatable > > In submitted requests table I encountered a encoding problem: > > "Knihovna ?st??" should be "Knihovna ?st?". > > Also, the heading of datatable is usually formatted in one line, see patron > circulation history for example. Ok I've fixed that. I was reversing the Encode module encode/decode functions and not reading the output of Devel::Peek correctly. Now I can see both Knihovna ?st? and ??? coming back from the harvester as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 06:45:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 05:45:59 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #236 from David Cook --- (In reply to David Cook from comment #224) > Comment on attachment 81789 [details] [review] > Bug 10662: (QA follow-up) Fix plural in pod and use statements > > Review of attachment 81789 [details] [review]: > ----------------------------------------------------------------- > > ::: Koha/OAI/Harvester/Import/Record.pm > @@ +29,4 @@ > > > > use Koha::OAI::Harvester::Import::MARCXML; > > use Koha::OAI::Harvester::Biblios; > > +use Koha::OAI::Harvester::Histories; > > This actually should be Koha::OAI::Harvester::History and not > Koha::OAI::Harvester::Histories. This change breaks the harvester. Actually, since Histories uses History, it's probably fine... but I don't actually use Histories in Record.pm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 07:24:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 06:24:08 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #197 from Joonas Kylm?l? --- Thanks for the patch! Instead of croak or die the exceptions need to be used, e.g. Koha::Exceptions::Exception->throw(""). Please do a git diff origin/master..HEAD to see all the dies and croaks (assuming HEAD contains your patches). And the many for loops I mentioned are in the subroutine marc_records_to_documents Koha/SearchEngine/Elasticsearch.pm ? though take this as an optional thing to fix as I know this bug is blocking quite many other things. Continuing still code review... About installer/data/mysql/atomicupdate/bug_19893_elasticsearch_index_status_sysprefs.sql ? a) is it a good idea to have these as a syspref (even though the user cannot see them)? b) if it's a good idea then the sysprefs should also be in installer/data/mysql/sysprefs.sql because otherwise in a new Koha installation the syspref will be missing. In the file Koha/SearchEngine/Elasticsearch.pm: s/string on the format/string in the format/ Then we also need a test plan for this code. Like what steps need to be taken to index authorities and biblios and what should be the expected result. Unit tests (https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL17:_Unit_tests_are_required_.28updated_Apr_26.2C_2017.29): at least decode_record_from_result is missing one If all the above mentioned things get fixed then I'm probably ready to sign-off but I still need to test this code actually before that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 07:30:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 06:30:52 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #198 from Joonas Kylm?l? --- (In reply to Joonas Kylm?l? from comment #197) > Then we also need a test plan for this code. Like what steps need to be > taken to index authorities and biblios and what should be the expected > result. There was one already in the first commit, so forget this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 07:33:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 06:33:51 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #199 from Joonas Kylm?l? --- The first patch's title "Bug 19893 - Alternative optimized indexing for Elasticsearch" should be Bug 19893: Alternative optimized indexing for Elasticsearch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 07:51:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 06:51:00 +0000 Subject: [Koha-bugs] [Bug 21604] Cannot add/edit funds, cannot add budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21604 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 07:51:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 06:51:04 +0000 Subject: [Koha-bugs] [Bug 21604] Cannot add/edit funds, cannot add budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21604 --- Comment #4 from Marcel de Rooy --- Created attachment 81858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81858&action=edit Bug 21604: Add two trivial test cases Adding an id in AddBudgetPeriod and an empty string in AddBudget for budget_encumb. Test plan: Run Budgets.t with/without this patch in strict sql mode. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 07:51:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 06:51:08 +0000 Subject: [Koha-bugs] [Bug 21604] Cannot add/edit funds, cannot add budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21604 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80959|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 81859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81859&action=edit Bug 21604: Fix add/edit fund/budget [Strict SQL modes context] For insert aqbudgetperiods: Incorrect integer value: '' for column 'budget_period_id' For insert/update aqbudgets Incorrect integer value: '' for column 'budget_owner_id' Incorrect decimal value: '' for column 'budget_encumb' Test plan: Add/edit budgets and funds A good example of why we should use Koha::Object for all our objects Signed-off-by: Pierre-Marc Thibault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 07:51:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 06:51:43 +0000 Subject: [Koha-bugs] [Bug 21604] Cannot add/edit funds, cannot add budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21604 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #6 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #3) > I added 1 to > /etc/koha/sites/kohadev/koha-conf.xml and restart_all and restarted > memcached separately too, but I fail to make things explode. What am I > missing? Sabotaged the test to show it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 07:51:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 06:51:51 +0000 Subject: [Koha-bugs] [Bug 21604] Cannot add/edit funds, cannot add budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21604 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 07:56:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 06:56:31 +0000 Subject: [Koha-bugs] [Bug 21606] Issues with matching rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21606 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 07:56:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 06:56:34 +0000 Subject: [Koha-bugs] [Bug 21606] Issues with matching rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21606 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80886|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy --- Created attachment 81860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81860&action=edit Bug 21606: [sql_modes] Fix matching rules insert Fix: Incorrect integer value: '' for column 'offset' Incorrect integer value: '' for column 'score' Test plan: Add/edit matching rules Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 08:01:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 07:01:02 +0000 Subject: [Koha-bugs] [Bug 21606] Issues with matching rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21606 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Patch complexity|--- |Trivial patch CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- Trivial fix, combined SO + QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 08:08:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 07:08:49 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #238 from David Cook --- Created attachment 81862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81862&action=edit Bug 10662: (QA follow-up) provide DBIC schema files DBIC schema files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 08:08:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 07:08:57 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81789|0 |1 is obsolete| | --- Comment #239 from David Cook --- Created attachment 81863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81863&action=edit Bug 10662: (QA follow-up) Fix plural in pod and use statements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 08:08:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 07:08:39 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81783|0 |1 is obsolete| | --- Comment #237 from David Cook --- Created attachment 81861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81861&action=edit Bug 10662: Build OAI-PMH Harvesting Client This patch adds an OAI-PMH harvesting client to Koha. The client runs as a daemon in the background. Users interact with the client via the Koha web user interface, which communicates with the daemon via a unix socket using a simple JSON-based protocol. The harvester ingests MARCXML. You can harvest other metadata formats, but you must use a XSLT to transform them into MARCXML, if you want them to be imported into Koha. You can supply your own download and import modules via the oai-pmh-harvester.yaml configuration file, but the default modules supplied in this patch should be good enough for your purposes. If they're not, raise a Bugzilla issue. There is a cleanup_database.pl addition, because high volume harvesting will cause the oai_harvester_import_queue table to fill quickly. This table is not required for adding/updating records. It's mostly just for general monitoring and audit purposes. Signed-off-by: Andreas Hedstr?m Mace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 08:09:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 07:09:07 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81790|0 |1 is obsolete| | --- Comment #240 from David Cook --- Created attachment 81864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81864&action=edit Bug 10662: (QA follow-up) Enhance marc matchers description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 08:09:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 07:09:38 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81784|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 08:10:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 07:10:18 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81856|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 08:10:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 07:10:22 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81855|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 08:11:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 07:11:02 +0000 Subject: [Koha-bugs] [Bug 21015] Members.pm slow because it loads twice Koha::Schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21015 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 08:11:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 07:11:06 +0000 Subject: [Koha-bugs] [Bug 21015] Members.pm slow because it loads twice Koha::Schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21015 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80751|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 81865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81865&action=edit Bug 21015: fix performance issue with C4::Members loading Koha::Schema ("use Koha::Schema;") takes significantly time as it loads almost a couple hundred classes. Koha::Database has done that already once and we can use it to get the ResultSet "Borrower" as well, so let's use that. This also make the code more unified because Koha::Database is used throughout the code instead of Koha::Schema. Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 08:11:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 07:11:11 +0000 Subject: [Koha-bugs] [Bug 21015] Members.pm slow because it loads twice Koha::Schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21015 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80752|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 81866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81866&action=edit Bug 21015: Remove unecessary 'use Koha::Schema' statements in t/ Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 08:11:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 07:11:22 +0000 Subject: [Koha-bugs] [Bug 21015] Members.pm slow because it loads twice Koha::Schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21015 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 08:12:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 07:12:22 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #241 from David Cook --- OK. I have fixed: - column collation in installer/data/mysql/atomicupdate/bug_10662.sql and installer/data/mysql/kohastructure.sql - fixed the "Refresh import history" button/ajax KohaTable/DataTable - fixed UTF-8 encoding problem in client-server communications - separated out the Koha/Schema/Result/*.pm schema files I think the only things I haven't changed are: - SQL statement handle I re-use - DataTable styling - matcher_id foreign key issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 08:13:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 07:13:51 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 08:15:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 07:15:32 +0000 Subject: [Koha-bugs] [Bug 20635] Write authentication tests with Test::Mojo In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20635 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 08:16:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 07:16:19 +0000 Subject: [Koha-bugs] [Bug 21457] datelastseen and datelastborrowed out of sync In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21457 --- Comment #2 from Magnus Enger --- MariaDB [koha_bth]> SELECT datelastborrowed, datelastseen FROM items WHERE datelastborrowed > datelastseen LIMIT 10; +------------------+--------------+ | datelastborrowed | datelastseen | +------------------+--------------+ | 2018-09-13 | 2018-06-25 | | 2018-09-05 | 2015-10-09 | | 2018-09-05 | 2018-02-08 | | 2018-09-10 | 2017-12-14 | | 2018-06-08 | 2018-04-10 | | 2018-04-30 | 2016-10-20 | | 2018-07-10 | 2017-06-08 | | 2018-01-24 | 2017-01-19 | | 2018-07-31 | 2018-02-01 | | 2018-07-10 | 2018-01-16 | +------------------+--------------+ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 08:37:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 07:37:35 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Johanna R?is? changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |johanna.raisa at mikkeli.fi --- Comment #48 from Johanna R?is? --- As we have used this in Finland for some years now, my opinion is that using the index for linking the records is not very efficient. You are always depended on it and if you want to make REST endpoint for the host and its component parts the callback probably isn't always solid. Also we have had issues with removing records. If you remove the host record the children are not going to be removed at the same time. And finding which children can be removed afterwards is difficult. On the other hand cleaning the database is getting very annoying and slow. My proposal is to move this linking to database level. Having a linking table which has host's biblionumber and child's biblionumber would make it solid and easier to handle. This could be a solution that we don't have to implement always to new search index platform. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 08:48:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 07:48:16 +0000 Subject: [Koha-bugs] [Bug 21640] Itivia outbound script doesn't print to STDOUT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21640 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 08:48:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 07:48:19 +0000 Subject: [Koha-bugs] [Bug 21640] Itivia outbound script doesn't print to STDOUT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21640 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81103|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 81867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81867&action=edit Bug 21640: Enable output to STDOUT for Itiva outbound script To test: 1 - Enable the TalkingTechItivaPhoneNotification 2 - Copy 'HOLD' notice 'email' transport to the phone section 3 - Enable EnhancedMessagingPreferences 4 - Find a patron and enable 'phone' for the 'Hold filled' notice Note: You might not be able to do this straightaway, bug 21639 If the phone box has a '-' and not a checkbox: sudo koha-mysql kohadev INSERT INTO message_transports (message_attribute_id,message_transport_type,is_digest,letter_module,letter_code) VALUES (4,'phone',0,'reserves','HOLD'); 5 - Place a hold for the patron 6 - Check it in and confirm the hold to set it waiting 7 - sudo koha-shell kohadev 8 - perl misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl --type=RESERVE -w 0 -v 9 - Note the Output says it will be on STDOUT, but nothing is output 10 - Apply patch 11 - repeat 12 - Hold info is output to command line Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 08:52:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 07:52:01 +0000 Subject: [Koha-bugs] [Bug 21640] Itivia outbound script doesn't print to STDOUT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21640 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #4 from Marcel de Rooy --- Symbol table aliasing (not duplicating) STDOUT is not really nice. (We could just print to STDOUT and optionally select a file handle.) No big deal. Removed the parentheses from die on the same line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 08:58:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 07:58:43 +0000 Subject: [Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #37 from Marcel de Rooy --- QA: Looking here a bit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 09:07:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 08:07:22 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #49 from Olli-Antti Kivilahti --- DB link table is a good idea. Zebra searches for the link relations were blazingly fast tho. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 09:10:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 08:10:51 +0000 Subject: [Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #38 from Marcel de Rooy --- Patch does not apply btw. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 09:19:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 08:19:15 +0000 Subject: [Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #39 from Alex Buckley --- Hi Marcel Thanks for testing. Can you please tell me which patch is failing to apply? When I test applying on up to date master it is applying fine: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15529 - Locking process_message_queue.pl cron whilst it is running Applying: Bug 15529 - Wrapping email sending up in the verbose flag Using index info to reconstruct a base tree... M misc/cronjobs/process_message_queue.pl Falling back to patching base and 3-way merge... Auto-merging misc/cronjobs/process_message_queue.pl Applying: Bug 15529: Followup to send without more libraries Applying: Bug 15529: Altered logic for lockfile creation Cheers, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 09:24:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 08:24:50 +0000 Subject: [Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #40 from Marcel de Rooy --- +print "$0 is already running. Exiting.\n"; +#Send email to inform administrator another process_message_queue.pl cron was attempted to run whilst previous execution of the file is taking place. +# Configure accordingly +MIME::Lite->send( 'smtp', ''); +my $email = MIME::Lite->new( +To => ' ', +From => ' ', +Type => 'TEXT', +Subject => 'process_message_queue.pl cron is already running', +Data => 'process_message_queue.pl cron is already running', +); + +$email->attach( +Type => 'Text', + Data => 'process_message_queue.pl cron is already running', ); +$email->send(); +exit(1); +} I would say: Just print already running to STDERR and quit. No need to send email. If the administrator wants an email, he can add MAILTO=root in cron. No need to add MIME::Lite etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 09:25:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 08:25:13 +0000 Subject: [Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #41 from Marcel de Rooy --- (In reply to Alex Buckley from comment #39) > Hi Marcel > > Thanks for testing. Can you please tell me which patch is failing to apply? > > When I test applying on up to date master it is applying fine: > > Apply? [(y)es, (n)o, (i)nteractive] y > Applying: Bug 15529 - Locking process_message_queue.pl cron whilst it is > running > Applying: Bug 15529 - Wrapping email sending up in the verbose flag > Using index info to reconstruct a base tree... > M misc/cronjobs/process_message_queue.pl > Falling back to patching base and 3-way merge... > Auto-merging misc/cronjobs/process_message_queue.pl > Applying: Bug 15529: Followup to send without more libraries > Applying: Bug 15529: Altered logic for lockfile creation > > Cheers, > Alex Second patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 09:26:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 08:26:34 +0000 Subject: [Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #42 from Marcel de Rooy --- +my $instancemessagequeuefile = $logdir . "/messagequeue.lock"; +open(FOO, ">> $instancemessagequeuefile") or die "Cannot write to $instancemessagequeuefile: $!"; As Martin already said, the logdir might not be the best candidate. Also look at locking in rebuild_zebra.pl. Note that it tries three places and continues even if the system does not facilitate locking. I see in the follow-ups that you change it. Fine. You now copy locking from rebuild_zebra. Please consolidate: move it to a module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 09:27:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 08:27:03 +0000 Subject: [Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #43 from Marcel de Rooy --- -C4::Letters::SendQueuedMessages( - { - verbose => $verbose, - username => $username, - password => $password, - method => $method, - limit => $limit, - type => $type, - } +C4::Letters::SendQueuedMessages( { verbose => $verbose, username => $username, password => $password, method => $method } ); +sleep(15); Why do you remove limit and type? Why add sleep (debug leftover)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 09:28:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 08:28:02 +0000 Subject: [Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 09:28:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 08:28:59 +0000 Subject: [Koha-bugs] [Bug 21723] batch_anonymise.pl SQL-query runs out of memory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21723 --- Comment #4 from Andreas Jonsson --- With the full GROUP BY clause the query fails because it runs out of sort memory. With only GROUP BY `borrowernumber` the query takes 2.87 seconds and matches 9529 lines. Just adding filtering on AnonymousPatron doesn't actually help me at the moment. Since it has taken us a while to notice this problem, we already have 43797 entries that needs to be anonymised. These entries needs to be sorted for the GROUP BY clause, which cause the sort buffer memory to run out. It would have prevented this situation, though. But it seems that all we need from search_patrons_to_anonymise is `SELECT DISTINCT borrowernumber FROM old_issues JOIN borrowers USING (borrowernumber) WHERE privacy <> 0 AND returndate < ? AND borrowernumber <> ?` Or why not do the anonymisation in SQL-code directly: CREATE TEMPORARY TABLE old_issues_to_anonymise (issue_id INT); INSERT INTO old_issues_to_anonymise SELECT issue_id FROM old_issues JOIN borrowers USING (borrowernumber) WHERE privacy <> 0 AND returndate < ? AND borrowernumber <> ?; UPDATE old_issues SET borrowernumer = ? WHERE issue_id IN (SELECT * FROM old_issues_to_anonymise); DROP TABLE old_issues_to_anonymise; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 09:35:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 08:35:00 +0000 Subject: [Koha-bugs] [Bug 21656] Syntax Error in Stock Rotation Default Notice Template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21656 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #18 from Marcel de Rooy --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 09:43:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 08:43:49 +0000 Subject: [Koha-bugs] [Bug 21656] Syntax Error in Stock Rotation Default Notice Template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21656 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81275|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy --- Created attachment 81868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81868&action=edit Bug 21656: Fix for bad TT syntax in default stock rotation notice Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 09:43:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 08:43:54 +0000 Subject: [Koha-bugs] [Bug 21656] Syntax Error in Stock Rotation Default Notice Template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21656 --- Comment #20 from Marcel de Rooy --- Created attachment 81869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81869&action=edit Bug 21656: (follow-up) Fix atomicupdate The atomicupdate is going to run as part of an upgrade. It needs to UPDATE, not INSERT. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 09:43:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 08:43:59 +0000 Subject: [Koha-bugs] [Bug 21656] Syntax Error in Stock Rotation Default Notice Template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21656 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81277|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy --- Created attachment 81870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81870&action=edit Bug 21656: Reduce the risk of possible side-effects Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 09:44:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 08:44:07 +0000 Subject: [Koha-bugs] [Bug 21656] Syntax Error in Stock Rotation Default Notice Template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21656 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81278|0 |1 is obsolete| | --- Comment #22 from Marcel de Rooy --- Created attachment 81871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81871&action=edit Bug 21656: Update 4 missing sample_notices.sql Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 09:43:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 08:43:46 +0000 Subject: [Koha-bugs] [Bug 21656] Syntax Error in Stock Rotation Default Notice Template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21656 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 09:44:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 08:44:30 +0000 Subject: [Koha-bugs] [Bug 21656] Syntax Error in Stock Rotation Default Notice Template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21656 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81276|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 09:45:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 08:45:01 +0000 Subject: [Koha-bugs] [Bug 21656] Syntax Error in Stock Rotation Default Notice Template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21656 --- Comment #23 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #16) > (In reply to Marcel de Rooy from comment #9) > > FAIL installer/data/mysql/atomicupdate/bug_21620.perl > > FAIL git manipulation > > The file has been added and deleted in the same patchset > > Not blocker for atomic update I'd say, even if is would be better to amend > the first patch and rename it (not a bit deal, really). Fixed that. Made QA tools happy now :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 09:44:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 08:44:38 +0000 Subject: [Koha-bugs] [Bug 21656] Syntax Error in Stock Rotation Default Notice Template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21656 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 09:45:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 08:45:50 +0000 Subject: [Koha-bugs] [Bug 21656] Syntax Error in Stock Rotation Default Notice Template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21656 --- Comment #24 from Marcel de Rooy --- * Commit title does not contain 'follow-up' correctly spelt - 32bf113 Renamed it. But this was bit arbitrary.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 09:47:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 08:47:43 +0000 Subject: [Koha-bugs] [Bug 21656] Syntax Error in Stock Rotation Default Notice Template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21656 --- Comment #25 from Martin Renvoize --- Thanks for the follow-up fixes.. think my brain was on a go slow that day. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 09:49:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 08:49:41 +0000 Subject: [Koha-bugs] [Bug 21620] Errors when using email from stockrotation.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21620 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 09:49:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 08:49:34 +0000 Subject: [Koha-bugs] [Bug 21620] Errors when using email from stockrotation.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21620 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 09:54:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 08:54:05 +0000 Subject: [Koha-bugs] [Bug 21604] Cannot add/edit funds, cannot add budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21604 --- Comment #7 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #6) > (In reply to Katrin Fischer from comment #3) > > I added 1 to > > /etc/koha/sites/kohadev/koha-conf.xml and restart_all and restarted > > memcached separately too, but I fail to make things explode. What am I > > missing? > > Sabotaged the test to show it :) Turns out the entry needs to go within the config section (figured it out later, updated wiki) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 09:56:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 08:56:03 +0000 Subject: [Koha-bugs] [Bug 21755] New: Show patron updated date in circ menu Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21755 Bug ID: 21755 Summary: Show patron updated date in circ menu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In borrowers table the column updated_on stores the last updated date and time. Display this in the circ menu. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 09:56:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 08:56:13 +0000 Subject: [Koha-bugs] [Bug 21755] Show patron updated date in circ menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21755 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 10:02:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 09:02:14 +0000 Subject: [Koha-bugs] [Bug 21620] Errors when using email from stockrotation.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21620 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 10:02:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 09:02:18 +0000 Subject: [Koha-bugs] [Bug 21620] Errors when using email from stockrotation.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21620 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81111|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy --- Created attachment 81872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81872&action=edit Bug 21620: Prevent stockrotation cronjob failures Superflous use of sprintf combined with rebasing issue left the stockrotation cronjob such that a 'No action taken' email report would catastrophically fail with the error: Redundant argument in sprintf at ./stockrotation.pl line 316 This patch both resolves the error and cleans up some additional unrequired sprintf usage. Test Plan 1) Create a rotation plan 2) Add some items to the rotation plan 3) Run the cronjob using `stockrotation.pl --report=email --send-email --execute` 4) Note the lack of errors Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 10:07:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 09:07:40 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #50 from Martin Renvoize --- Add DB link tables moves this bug into entirely different territory in my opinion... lets get the basics working well with zebra first as we're very nearly there here already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 10:13:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 09:13:09 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #51 from Katrin Fischer --- So I think the only thing left fixing are these 2 points right now, correct? BTW I am not sure about a linking table for links between records, but I would love to see a linking table for the EasyAnalytics feature that happens on item level and 'spills over' into the record with non-standard 77x entries. In reply to Josef Moravec from comment #38) > Comment on attachment 79810 [details] [review] > Bug 11175: Show record component parts in the detail view > > Review of attachment 79810 [details] [review]: > ----------------------------------------------------------------- > > ::: Koha/Biblio.pm > @@ +388,4 @@ > > return $self->{_biblioitem}; > > } > > > > +=head3 components > > Please, provide tests for this method > > @@ +399,5 @@ > > + > > +sub components { > > + my ($self) = @_; > > + > > + return undef if (C4::Context->preference('marcflavour') ne 'MARC21'); > > Do not return explicit undef -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 10:15:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 09:15:38 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #23 from Katrin Fischer --- I won't be able to finish here today - would be really happy if someone else from the QA team could have a look. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 10:17:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 09:17:44 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #52 from Olli-Antti Kivilahti --- We are currently discussing how we solve this problem properly for both the Finnish academic and public library sectors. This includes more than 773 linking. I have 0% interest to keep fiddling with this miniscule minimum product which no longer satisfies our extended requirements. I understand the need for small steps, but thanks to the small steps, we still have to restart the SIP2-server due to memcached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 10:20:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 09:20:24 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #53 from Katrin Fischer --- So you are going to let this die here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 10:22:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 09:22:04 +0000 Subject: [Koha-bugs] [Bug 20436] Add ability to specify itemtypes for longoverdue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20436 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from Marcel de Rooy --- * Commit title does not start with 'Bug XXXXX: ' - 62f2b5d QA: Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 10:25:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 09:25:43 +0000 Subject: [Koha-bugs] [Bug 20436] Add ability to specify itemtypes for longoverdue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20436 --- Comment #5 from Marcel de Rooy --- + 'l|lost=s%' => \$lost, 'category=s' => $borrower_category, 'skip-category=s' => $skip_borrower_category, 'list-categories' => \$list_categories, + 'itemtype=s' => $itemtype, + 'skip-itemtype=s' => $skip_itemtype, + 'list-itemtypes' => \$list_itemtypes, This is a confusing mix of handling options. I think we should always pass a reference like name => \$option, but as you can see we already deviate from that here. But you are adding new cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 10:27:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 09:27:02 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #54 from Olli-Antti Kivilahti --- We can always open a new bug ticket :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 10:28:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 09:28:22 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #55 from Olli-Antti Kivilahti --- BTW Zebra doesn't always return the correct search results. For ex we have a REST API endpoint which returns all component parts for a biblio. It is awkward that we know some biblios have component parts, and still the Zebra searches don't return those results. That makes for rather bad API service. Using a DB link-table adds reliability. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 10:30:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 09:30:20 +0000 Subject: [Koha-bugs] [Bug 20436] Add ability to specify itemtypes for longoverdue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20436 --- Comment #6 from Marcel de Rooy --- Typo "The options --itemtype and --skip-itemtype are mually exclusive.\n" But I am not a native speaker, so I might be wrong? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 10:32:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 09:32:30 +0000 Subject: [Koha-bugs] [Bug 20436] Add ability to specify itemtypes for longoverdue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20436 --- Comment #7 from Marcel de Rooy --- +=item B<--list-itemtypes> + +List itemtypes available for use by B<--itemtype> or +B<--skip-itemtype>, and exit. I am not a fan of such options. There are better ways to list them. One is already in and I would rather remove it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 10:33:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 09:33:14 +0000 Subject: [Koha-bugs] [Bug 20436] Add ability to specify itemtypes for longoverdue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20436 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Marcel de Rooy --- Changing status. Too much noise for me now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 10:33:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 09:33:35 +0000 Subject: [Koha-bugs] [Bug 20436] Add ability to specify itemtypes for longoverdue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20436 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 10:34:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 09:34:35 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #56 from Olli-Antti Kivilahti --- BTW. First Finnish academic library HAMK went live last tuesday. Using ES in production. What we are trying to decide is, should these links be only in the ES index, only in the DB as a link-table with different link types separated, or should we implement both. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 10:38:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 09:38:34 +0000 Subject: [Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 10:42:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 09:42:46 +0000 Subject: [Koha-bugs] [Bug 19349] Allow to store biblio record's creator and last modifier in MARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19349 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 10:42:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 09:42:40 +0000 Subject: [Koha-bugs] [Bug 19349] Allow to store biblio record's creator and last modifier in MARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19349 --- Comment #11 from Marcel de Rooy --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 10:49:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 09:49:37 +0000 Subject: [Koha-bugs] [Bug 19349] Allow to store biblio record's creator and last modifier in MARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19349 --- Comment #12 from Marcel de Rooy --- Put 990a in the field. (Yeah should have been 990$a but is not listed on the preferences form..) Internal server error. Tag "990a" is not a valid tag. at /usr/share/koha/devclone/Koha/Util/MARC.pm line 218. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 10:55:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 09:55:47 +0000 Subject: [Koha-bugs] [Bug 19349] Allow to store biblio record's creator and last modifier in MARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19349 --- Comment #13 from Marcel de Rooy --- $record->append_fields($field); Should we actually append or insert_ordered ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:21:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:21:38 +0000 Subject: [Koha-bugs] [Bug 19349] Allow to store biblio record's creator and last modifier in MARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19349 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78639|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy --- Created attachment 81873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81873&action=edit Bug 19349: Store record's creator and last modifier in record Test plan: 1. Run updatedatabase.pl 2. Set sysprefs MarcFieldForCreatorId, MarcFieldForCreatorName, MarcFieldForModifierId, MarcFieldForModifierName 3. Create a new biblio 4. Verify that the fields are correctly filled 5. Logout and login as another user 6. Modify the same biblio 7. Verify that only the fields for last modifier have been modified Works perfectly. Signed-off-by: Simon Pouchol Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:21:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:21:43 +0000 Subject: [Koha-bugs] [Bug 19349] Allow to store biblio record's creator and last modifier in MARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19349 --- Comment #15 from Marcel de Rooy --- Created attachment 81874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81874&action=edit Bug 19349: (QA follow-up) Cosmetic changes [1] Construction with a // b instead of a; unless( a ) b; [2] Error checking on subfieldCode [3] Add explanation how to fill preference Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:21:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:21:35 +0000 Subject: [Koha-bugs] [Bug 19349] Allow to store biblio record's creator and last modifier in MARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19349 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:23:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:23:23 +0000 Subject: [Koha-bugs] [Bug 19349] Allow to store biblio record's creator and last modifier in MARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19349 --- Comment #16 from Marcel de Rooy --- Passed QA If you dont want this in your record, simply do not add something in these prefs. No harm done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:26:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:26:01 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #34 from Marcel de Rooy --- (In reply to Ere Maijala from comment #33) > (In reply to M. Tompsett from comment #32) > > ::: C4/Biblio.pm > > @@ -310,4 @@ > > > > > > $frameworkcode = "" if !$frameworkcode || $frameworkcode eq "Default"; # XXX > > > > > > - _strip_item_fields($record, $frameworkcode); > > > > I really think removing the frameworkcode is a bad idea. > > The default framwork was made authoritative in bug 19096. As a result of > that, the frameworkcode parameter in GetMarcFromKohaField function is no > longer used. _strip_item_fields is still using GetMarcFromKohaField, it just > doesn't need the frameworkcode for anything. So effectively the patch just > removes an unused parameter. Yeah still writing that patch :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:28:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:28:23 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #35 from Marcel de Rooy --- On top of 14385 as suggested: Applying: Bug 20664: Optimize retrieval of biblio and item data /usr/share/koha/devclone/.git/rebase-apply/patch:220: tab in indent. my ( $biblionumber, $itemnumbers, $hidingrules ) = @_; fatal: sha1 information is lacking or useless (t/db_dependent/Items.t). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:40:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:40:07 +0000 Subject: [Koha-bugs] [Bug 20356] Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79760|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy --- Created attachment 81875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81875&action=edit Bug 20356: Add EmailSMSSendDriverFromAddress system preference Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address. How to test: 1) Run tests in t/db_dependent/Letters.t 2) All tests should pass Sponsored-by: Gothenburg University Library Signed-off-by: Michal Denar Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:40:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:40:03 +0000 Subject: [Koha-bugs] [Bug 20356] Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:41:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:41:03 +0000 Subject: [Koha-bugs] [Bug 20356] Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #14 from Marcel de Rooy --- Not a blocker for me. Very specific and small issue, easy to move to provider db on a new report. Please open one, David. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:42:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:42:06 +0000 Subject: [Koha-bugs] [Bug 21753] issuingrules.chargename is unused and should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21753 --- Comment #1 from Martin Renvoize --- Created attachment 81876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81876&action=edit Bug 21753: Remove all reference of chargename from scripts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:42:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:42:09 +0000 Subject: [Koha-bugs] [Bug 21753] issuingrules.chargename is unused and should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21753 --- Comment #2 from Martin Renvoize --- Created attachment 81877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81877&action=edit Bug 21753: DBRev to remove the field from the database -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:42:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:42:23 +0000 Subject: [Koha-bugs] [Bug 21656] Syntax Error in Stock Rotation Default Notice Template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21656 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #26 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:42:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:42:27 +0000 Subject: [Koha-bugs] [Bug 21753] issuingrules.chargename is unused and should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21753 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:42:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:42:38 +0000 Subject: [Koha-bugs] [Bug 21620] Errors when using email from stockrotation.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21620 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #13 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:42:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:42:50 +0000 Subject: [Koha-bugs] [Bug 21604] Cannot add/edit funds, cannot add budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21604 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:42:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:42:45 +0000 Subject: [Koha-bugs] [Bug 21753] issuingrules.chargename is unused and should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21753 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:43:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:43:21 +0000 Subject: [Koha-bugs] [Bug 21606] Issues with matching rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21606 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:43:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:43:24 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #13 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #10) > IMO it's not conceivable to push this code as it. We cannot have such code > in .pl, without tests, etc. > > Why not just a $patron->unblessed then use columns.def instead of listing of > the patron's attributes? > > Also found a typo: + 'dateoffbirth' => $patron->dateofbirth, Please adjust status if something fails qa ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:43:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:43:05 +0000 Subject: [Koha-bugs] [Bug 20996] Fix API response time on ILL request endpoint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #62 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:43:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:43:36 +0000 Subject: [Koha-bugs] [Bug 21640] Itivia outbound script doesn't print to STDOUT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21640 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:43:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:43:48 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #187 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:44:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:44:08 +0000 Subject: [Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #53 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:44:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:44:11 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 --- Comment #14 from Marcel de Rooy --- Please move code to module. Makes it easier to test too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:44:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:44:23 +0000 Subject: [Koha-bugs] [Bug 21501] Remove dead code from course reserves module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21501 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:44:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:44:49 +0000 Subject: [Koha-bugs] [Bug 21748] Update C4::Overdues::UpdateFine to use Koha::Account->update_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21748 --- Comment #2 from Martin Renvoize --- Created attachment 81878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81878&action=edit Bug 21748: Add ->adjust to Koha::Account::Line -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:46:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:46:29 +0000 Subject: [Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 --- Comment #1 from Martin Renvoize --- Created attachment 81879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81879&action=edit Bug 21727: Add ->adjust to Koha::Account::Line -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:48:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:48:25 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:49:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:49:30 +0000 Subject: [Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 --- Comment #2 from Martin Renvoize --- Proof Of Concept... tests to come -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:49:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:49:42 +0000 Subject: [Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:55:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:55:08 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #57 from Johanna R?is? --- Maybe we should open new ticket for it. The linking table could be generic and used more versatile for different types of links. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:58:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:58:16 +0000 Subject: [Koha-bugs] [Bug 21002] Add Koha::Account::add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81620|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 81880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81880&action=edit Bug 21002: Add ->add_debit method to Koha::Account -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:58:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:58:54 +0000 Subject: [Koha-bugs] [Bug 21728] Update C4::Reserves::ChargeReserveFee to use Koha::Account->add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81791|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 81881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81881&action=edit Bug 21728: Use Koha::Account->add_debit in ChargeReserveFee -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:59:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:59:09 +0000 Subject: [Koha-bugs] [Bug 21728] Update C4::Reserves::ChargeReserveFee to use Koha::Account->add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 11:59:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 10:59:50 +0000 Subject: [Koha-bugs] [Bug 21002] Add Koha::Account::add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:02:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:02:22 +0000 Subject: [Koha-bugs] [Bug 21678] Adding debit "Renewal of Rental Item" and "Reserve Charge" does not create account offset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21678 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21720 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:02:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:02:22 +0000 Subject: [Koha-bugs] [Bug 21720] Update C4::Circulation::AddIssuingCharge to use Koha::Account->add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21720 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21678 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:02:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:02:31 +0000 Subject: [Koha-bugs] [Bug 21721] Update C4::Circulation::AddRenewal to use Koha::Account->add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21678 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:02:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:02:31 +0000 Subject: [Koha-bugs] [Bug 21678] Adding debit "Renewal of Rental Item" and "Reserve Charge" does not create account offset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21678 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21721 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:02:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:02:53 +0000 Subject: [Koha-bugs] [Bug 21678] Adding debit "Renewal of Rental Item" and "Reserve Charge" does not create account offset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21678 --- Comment #10 from Martin Renvoize --- bug 21720 and 21721 achieve this using add_debit now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:05:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:05:47 +0000 Subject: [Koha-bugs] [Bug 21720] Update C4::Circulation::AddIssuingCharge to use Koha::Account->add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21720 --- Comment #1 from Martin Renvoize --- Created attachment 81882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81882&action=edit Bug 21720: Use Koha::Account->add_debit in AddIssuingCharge -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:06:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:06:01 +0000 Subject: [Koha-bugs] [Bug 21720] Update C4::Circulation::AddIssuingCharge to use Koha::Account->add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21720 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:06:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:06:28 +0000 Subject: [Koha-bugs] [Bug 18507] Shibboleth auto-provisioning - Sync In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18507 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:06:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:06:32 +0000 Subject: [Koha-bugs] [Bug 18507] Shibboleth auto-provisioning - Sync In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18507 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79505|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 81883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81883&action=edit Bug 18507: Shibboleth auto-provisioning - Sync This patch allows to update borrowers informations with Shibboleth attributes upon login. Test plan: 1. In $KOHA_CONF, check that //shibboleth/sync is set to 1 2. Find an existing user and change one of the values mapped with a Shibboleth attribute 3. Log in using Shibboleth 4. Check that the value has been updated with the Shibboleth attribute. Signed-off-by: Julian Maurice Signed-off-by: Marcel de Rooy Comments posted on Bugzilla. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:07:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:07:10 +0000 Subject: [Koha-bugs] [Bug 18507] Shibboleth auto-provisioning - Sync In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18507 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #5 from Marcel de Rooy --- Seems we have a bit of code duplication here between the add and modify case. Can we slide that into one routine ? No blocker on feature slush, open a new report please. Do we need to check somewhere if the key is a valid patron column btw? Is not done on create, so no blocker too. Looks good enough to go along now. Feature can simply be config disabled, so no harm. Only reviewed, not tested. But has been confirmed to work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:08:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:08:35 +0000 Subject: [Koha-bugs] [Bug 21721] Update C4::Circulation::AddRenewal to use Koha::Account->add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 --- Comment #1 from Martin Renvoize --- Created attachment 81884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81884&action=edit Bug 21721: Use Koha::Account->add_debit in AddRenewal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:08:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:08:49 +0000 Subject: [Koha-bugs] [Bug 21721] Update C4::Circulation::AddRenewal to use Koha::Account->add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:11:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:11:45 +0000 Subject: [Koha-bugs] [Bug 21529] Print notices no longer outputs html notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:11:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:11:49 +0000 Subject: [Koha-bugs] [Bug 21529] Print notices no longer outputs html notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81545|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 81885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81885&action=edit Bug 21529: (follow-up) USE raw filter In order to be able to make use of the $raw filter, we need to USE it first Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:11:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:11:53 +0000 Subject: [Koha-bugs] [Bug 21529] Print notices no longer outputs html notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21529 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81546|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 81886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81886&action=edit Bug 21529: (bug 13618 follow-up) Display print notices with HTML tags Replace a wrong html filter with raw. Test plan: Define a HOLD or DISCHARGE notice template, with html tags. Generate them and confirm that html tags are displayed (which restore the existing behaviour prior to bug 13618) Signed-off-by: Andrew Isherwood Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:12:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:12:13 +0000 Subject: [Koha-bugs] [Bug 21721] Update C4::Circulation::AddRenewal to use Koha::Account->add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81884|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 81887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81887&action=edit Bug 21721: Use Koha::Account->add_debit in AddRenewal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:16:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:16:38 +0000 Subject: [Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Patch complexity|Trivial patch |Small patch --- Comment #17 from Marcel de Rooy --- Time too short, not trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:16:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:16:42 +0000 Subject: [Koha-bugs] [Bug 21721] Update C4::Circulation::AddRenewal to use Koha::Account->add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21002 |21720 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 [Bug 21002] Add Koha::Account::add_debit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21720 [Bug 21720] Update C4::Circulation::AddIssuingCharge to use Koha::Account->add_debit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:16:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:16:42 +0000 Subject: [Koha-bugs] [Bug 21002] Add Koha::Account::add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|21721 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 [Bug 21721] Update C4::Circulation::AddRenewal to use Koha::Account->add_debit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:16:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:16:42 +0000 Subject: [Koha-bugs] [Bug 21720] Update C4::Circulation::AddIssuingCharge to use Koha::Account->add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21720 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21721 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 [Bug 21721] Update C4::Circulation::AddRenewal to use Koha::Account->add_debit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:17:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:17:13 +0000 Subject: [Koha-bugs] [Bug 21720] Update C4::Circulation::AddIssuingCharge to use Koha::Account->add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21720 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:17:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:17:13 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21720 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21720 [Bug 21720] Update C4::Circulation::AddIssuingCharge to use Koha::Account->add_debit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:22:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:22:39 +0000 Subject: [Koha-bugs] [Bug 21721] Update C4::Circulation::AddRenewal to use Koha::Account->add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81887|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 81888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81888&action=edit Bug 21721: Use Koha::Account->add_debit in AddRenewal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:26:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:26:02 +0000 Subject: [Koha-bugs] [Bug 21722] Update C4::Accounts::chargelostitem to use Koha::Account->add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 --- Comment #1 from Martin Renvoize --- Created attachment 81889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81889&action=edit Bug 21722: Use Koha::Account->add_debit in chargelostitem -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:26:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:26:14 +0000 Subject: [Koha-bugs] [Bug 21722] Update C4::Accounts::chargelostitem to use Koha::Account->add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:29:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:29:26 +0000 Subject: [Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 --- Comment #2 from Martin Renvoize --- Created attachment 81890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81890&action=edit Bug 21747: Use Koha::Account:: routines in UpdateFine Set to use Koha::Account->add_debit and Koha::Account::Line->adjust -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:29:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:29:37 +0000 Subject: [Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 12:43:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 11:43:37 +0000 Subject: [Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 13:07:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 12:07:05 +0000 Subject: [Koha-bugs] [Bug 19066] Add branchcode to accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #40 from Martin Renvoize --- Hmm.. I'm working on a push to using Koha::Accounts more.. see the graph dangling off bug 21002 . Attempting to rebase my work on top of this I can see at least a couple of places where we're missing things here.. I'm going to set to failed qa whilst I add the followups. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 13:19:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 12:19:37 +0000 Subject: [Koha-bugs] [Bug 21002] Add Koha::Account::add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- +$debit_type can be any of: => I would not repeat that. Move the global vars at the top of the file instead, maybe should be defined with constant (see C4::Serials for an existing case). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 13:23:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 12:23:22 +0000 Subject: [Koha-bugs] [Bug 21756] New: Update C4::Accounts::manualinvoice to use Koha::Account->add_credit Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Bug ID: 21756 Summary: Update C4::Accounts::manualinvoice to use Koha::Account->add_credit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org All account handling should go via the Koha::Account class. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 13:23:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 12:23:50 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21756 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 [Bug 21756] Update C4::Accounts::manualinvoice to use Koha::Account->add_credit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 13:23:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 12:23:50 +0000 Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21756 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 [Bug 21756] Update C4::Accounts::manualinvoice to use Koha::Account->add_credit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 13:24:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 12:24:02 +0000 Subject: [Koha-bugs] [Bug 21756] Update C4::Accounts::manualinvoice to use Koha::Account->add_credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 13:23:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 12:23:50 +0000 Subject: [Koha-bugs] [Bug 21756] Update C4::Accounts::manualinvoice to use Koha::Account->add_credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20978 Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 [Bug 20978] Add Koha::Account::add_credit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 13:26:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 12:26:26 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 --- Comment #15 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #14) > Please move code to module. Makes it easier to test too. I wanted to get other opinions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 13:29:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 12:29:53 +0000 Subject: [Koha-bugs] [Bug 21753] issuingrules.chargename is unused and should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21753 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 13:43:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 12:43:18 +0000 Subject: [Koha-bugs] [Bug 21756] Update C4::Accounts::manualinvoice to use Koha::Account->add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update |Update |C4::Accounts::manualinvoice |C4::Accounts::manualinvoice |to use |to use |Koha::Account->add_credit |Koha::Account->add_debit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 13:47:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 12:47:21 +0000 Subject: [Koha-bugs] [Bug 20996] Fix API response time on ILL request endpoint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #63 from Jonathan Druart --- t/db_dependent/Illrequest/Config.t is failing. New code added to Koha/Illrequest/Config.pm but no tests? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 13:54:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 12:54:28 +0000 Subject: [Koha-bugs] [Bug 21756] Update C4::Accounts::manualinvoice to use Koha::Account->add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20978 |21002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 [Bug 20978] Add Koha::Account::add_credit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 [Bug 21002] Add Koha::Account::add_debit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 13:54:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 12:54:28 +0000 Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|21756 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 [Bug 21756] Update C4::Accounts::manualinvoice to use Koha::Account->add_debit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 13:54:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 12:54:28 +0000 Subject: [Koha-bugs] [Bug 21002] Add Koha::Account::add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21756 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 [Bug 21756] Update C4::Accounts::manualinvoice to use Koha::Account->add_debit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 13:55:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 12:55:13 +0000 Subject: [Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"#searchheader" toolbar not |fixFloat toolbar not |displaying properly in |displaying properly in |Chrome |Chrome CC| |oleonard at myacpl.org Severity|minor |normal --- Comment #5 from Jonathan Druart --- We could revert commit 592905a4d2d41a1a7b757c48fbac8fc6f025bf9b Bug 21139: (follow-up) Floating toolbars - Remove unecessary height But I would prefer to find a better fix as it degrades the ergonomic for FF -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 13:55:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 12:55:44 +0000 Subject: [Koha-bugs] [Bug 21043] Add routes to add debits to a patron's account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 13:57:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 12:57:48 +0000 Subject: [Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #44 from M. Tompsett --- (In reply to Marcel de Rooy from comment #43) > -C4::Letters::SendQueuedMessages( > - { > - verbose => $verbose, > - username => $username, > - password => $password, > - method => $method, > - limit => $limit, > - type => $type, > - } > +C4::Letters::SendQueuedMessages( { verbose => $verbose, username => > $username, password => $password, method => $method } ); > +sleep(15); > Why do you remove limit and type? Why add sleep (debug leftover)? I too thought it was a bad thing, which is why the third patch fixes it. However, I thought I patched up the ZEBRA stuff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 14:15:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 13:15:41 +0000 Subject: [Koha-bugs] [Bug 21755] Show patron updated date in circ menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21755 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 14:15:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 13:15:44 +0000 Subject: [Koha-bugs] [Bug 21755] Show patron updated date in circ menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21755 --- Comment #1 from Fridolin SOMERS --- Created attachment 81891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81891&action=edit Bug 21755: Show patron updated date in circ menu In borrowers table the column updated_on stores the last updated date and time. Display this in the circ menu. Test plan: 1) Go to a patron details page /cgi-bin/koha/members/moremember.pl 2) Look at left menu, you see "Updated on" and a date and time 3) Edit this patron and save 4) Check that "Updated on" changed 5) Click on each tab of menu to check this date is displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 14:32:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 13:32:09 +0000 Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #66 from Jonathan Druart --- + my $consent = Koha::Patron::Consents->search({ + borrowernumber => getborrowernumber($user), + type => 'GDPR_PROCESSING', + given_on => { '!=', undef }, + })->next; + if( !$consent ) { ->count could have been better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 14:32:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 13:32:13 +0000 Subject: [Koha-bugs] [Bug 15400] display patron age in useful places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 14:32:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 13:32:16 +0000 Subject: [Koha-bugs] [Bug 15400] display patron age in useful places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46935|0 |1 is obsolete| | --- Comment #9 from Josef Moravec --- Created attachment 81892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81892&action=edit Bug 15400: Display date of birth and age more consistantly Test plan: 0) Apply the patch 1) Go to all of these pages Patron detail Other patron pages - look on the left side (circ-menu) Patron search Guarantor search ( go to child patron -> edit -> in guarantor section click "Set to patron" Search through "Check out" (in the header) 2) Confirm that does show date of birth and date consistantly, try it on patrons with and without date of birth set to find possible reggressions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 14:32:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 13:32:30 +0000 Subject: [Koha-bugs] [Bug 15400] display patron age in useful places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Assignee|martin at bugs.koha-community. |josef.moravec at gmail.com |org.xinxidi.net | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 14:48:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 13:48:46 +0000 Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from Martin Renvoize --- Can we add a test for existance of database_test before running the DROP DATABASE commands -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 14:53:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 13:53:39 +0000 Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 15:00:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 14:00:41 +0000 Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 --- Comment #18 from Jonathan Druart --- Created attachment 81893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81893&action=edit Bug 19821: Require database_test != database To prevent developpers to drop their database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 15:16:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 14:16:30 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #242 from Owen Leonard --- (In reply to David Cook from comment #241) > - DataTable styling I'm preparing a template follow-up to this, but the only thing that is a blocker interface-wise is the DataTables styling. The problem is this is missing from the template: [% Asset.css("css/datatables.css") | $raw %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 15:30:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 14:30:25 +0000 Subject: [Koha-bugs] [Bug 20511] Seasonal prediction just in the staff language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 15:36:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 14:36:13 +0000 Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 --- Comment #20 from Martin Renvoize --- Created attachment 81895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81895&action=edit Bug 19821: Close filehandle after writing Signed-off-by: Jon Knight Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 15:36:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 14:36:16 +0000 Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71817|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize --- Created attachment 81896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81896&action=edit Bug 19821: Install sample data, ES mappings and Version syspref Also move .proverc to .proverc.dist, so it cannot be used by accident. Different ways to use it: 1/ prove --rc .proverc.dist Use defaults 2/ cp .proverc.dist .proverc && prove Allows to configure db name, marcflavour, and prove options Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 15:36:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 14:36:20 +0000 Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75045|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize --- Created attachment 81897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81897&action=edit Bug 19821: Ignore .proverc and .proverc.dist in Makefile.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 15:36:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 14:36:24 +0000 Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75091|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize --- Created attachment 81898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81898&action=edit Bug 19821: Do not modify KOHA_CONF, use new database_test entry instead I have tried to use the original idea of this patch for bug 19185, but it cannot work as it. ENV is not shared between processus and KOHA_CONF will not be read by webserver (used for selenium tests). Moreover on bug 19185 we are testing the installation process and we do not want the database to be populated with sample data, we just need a new and clean DB. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 15:36:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 14:36:28 +0000 Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75092|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize --- Created attachment 81899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81899&action=edit Bug 19821: Use database_test entry if exists If the database_test entry exists in the config file we are going to use it. This will be a trick for developers and CI Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 15:36:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 14:36:32 +0000 Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81893|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize --- Created attachment 81900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81900&action=edit Bug 19821: Require database_test != database To prevent developpers to drop their database. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 15:36:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 14:36:09 +0000 Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 --- Comment #19 from Martin Renvoize --- Created attachment 81894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81894&action=edit Bug 19821: Run tests on a separate database Running the tests on the same database as the one used for dev has some drawbacks: - Everybody has different data, so we cannot make any assumptions about data in tests and it can make tests fail for non-obvious reasons. - Tests have to clean up every change to the database using SQL transactions, so we cannot write testable code that use transactions (AFAIK) - Transactions in tests happen to be committed sometimes, resulting in garbage data added to the dev database This patch provides a .proverc file that will load t/lib/Bootstrap.pm before the tests are run. t/lib/Bootstrap.pm is responsible for recreating a fresh database and telling the test scripts to use it. To use it, just run prove normally from the root directory of Koha. By default, the database is 'koha_test' and it's created using MARC21 SQL files, it can be changed by running: prove --norc \ --Mt::lib::Bootstrap=database,koha_test,marcflavour,UNIMARC Test plan: 1. mysql> GRANT ALL PRIVILEGES ON koha_test.* TO @localhost 2. cd /path/to/koha 3. prove t/db_dependent/.t 4. Verify that it created the database koha_test and that the one you use usually was untouched (you can edit the test file and comment the lines related to a transaction (txn_begin, txn_rollback)) Signed-off-by: Jon Knight Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 15:37:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 14:37:06 +0000 Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69844|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 15:37:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 14:37:18 +0000 Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69843|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 15:37:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 14:37:54 +0000 Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #26 from Martin Renvoize --- As an initial step for Jenkins and the use of Selenium testing on the installer, this patch works. Signing Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 15:51:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 14:51:33 +0000 Subject: [Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com --- Comment #10 from Fiona Borthwick --- There is still interest from our customer base on this one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 15:55:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 14:55:18 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81822|0 |1 is obsolete| | --- Comment #200 from David Gustafsson --- Created attachment 81901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81901&action=edit Bug 19893: Add code review fixes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 2 16:04:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Nov 2018 15:04:46 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #243 from Owen Leonard --- Created attachment 81902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81902&action=edit Bug 10662: (follow-up) Template corrections and improvements This patch makes a number of corrections and improvements to the OAI harvester templates: - Add missing DataTables CSS include - Replace YUI grid with Bootstrap - Correct style of inline dialogs (.dialog.alert, .dialog.message) - Correct class of form hint and error messages - Format dates in saved and submitted requests tables - Add title-string sorting to DataTables configuration - Add delete confirmation to saved and submitted tables - Disable sorting on action columns - Style action links inside tables as buttons - Removed commented markup - Add missing JavaScript include (tools-menu.js) to highlight active section in sidebar menu - Add CodeMirror styling to record view page (CodeMirror XML mode file is added to enable this) - Remove invalid