[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

--- Comment #189 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
Comment on attachment 81284
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81284
Bug 19893: Add pods, remove syspref, add tests for serialization format

Review of attachment 81284:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19893&attachment=81284)
-----------------------------------------------------------------

::: Koha/SearchEngine/Elasticsearch.pm
@@ +484,5 @@
>  
> +Get mappings, an internal data structure later used by L<_process_mappings($mappings, $data, $record_document)>
> +to process MARC target data, for a MARC mapping.
> +
> +The returned C<$mappings> is to to be confused  with mappings provided by C<_foreach_mapping>, rather this

Should be:

The returned C<$mappings> is not to be confused with mappings provided by
C<_foreach_mapping>, rather this

(notice also the extra whitespace)

@@ +515,5 @@
> +Elasticsearch document target field type.
> +
> +=item C<$range>
> +
> +An optinal range as a string on the format "<START>-<END>" or "<START>",

Should be:

An optional range as a string in the format "<START>-<END>" or "<START>",

@@ +517,5 @@
> +=item C<$range>
> +
> +An optinal range as a string on the format "<START>-<END>" or "<START>",
> +where "<START>" and "<END>" are integers specifying a range that will be used
> +for extracting a substing from MARC data as Elasticsearch field target value.

substing -> substring

@@ +522,5 @@
> +
> +The first character position is "1", and the range is inclusive,
> +so "1-3" means the first three characters of MARC data.
> +
> +If only "<START>" is provided only one character as position "<START>" will

as position -> at position

-- 
You are receiving this mail because:
You are watching all bug changes.