[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

--- Comment #29 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Hi Martin

Thanks for your feedback.

I have tested and looked through the code calls in /circ/pendingreserves.pl,
/tools/batchMod.pl and misc/cronjobs/longoverdue.pl

I have noticed they are not consistent in their current handling of the
reserves on lost items. 

* /circ/pendingreserves.pl - This cancels non-waiting item level reserves when
item is marked as lost. Doesn't show allocated (waiting) holds.

* /tools/batchMod.pl - Doesn’t cancel item-level or allocated bib-level
reserves.

* /misc/cronjob/longoverdue.pl - Doesn't cancel non-waiting (un-allocated)
reserves

It would be good to have a consistent approach throughout Koha for dealing with
reserves on lost items. 

A question do you think it would be best to split this patch up so it is only
dealing with allocated (waiting) holds. This would alter the behavior of the
patches on the bug report which check for reserve type of 'waiting' or
'reserved'. 

Then we would only need to add reserve handling to /tools/batchMod.pl as
longoverdue.pl and pendingreserves.pl don't touch waiting reserves. 

Amending longoverdue.pl and pendingreserves.pl could go in another bug report
building on this to handle un-allocated holds, just to prevent too much scope
creep on this bug report?

Cheers,
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.