[Koha-bugs] [Bug 20912] Rental fees based on time period

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Failed QA

--- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'd like to see some tests for various combinations of process_fee,
rentalcharge and rental_charge_daily before passing this.

Looking at the code there seems to be a little disparity between charging the
amount returned by GetIssuingCharges followed by a second charge calculated
using rental_charge_daily.. sometimes it looks like a combined charge,
sometimes it looks like two charges and sometimes two charges with the second
change also being a combined charge.

Hence the asking for a few more tests ;)

Also.. i think I'd prefer that the calculation was folded into
GetIssuingCharges myself.. it seems somewhat fraught with peril to be
duplicating this code.

-- 
You are receiving this mail because:
You are watching all bug changes.