[Koha-bugs] [Bug 21770] t::lib::QA::TemplateFilters should allow html_entity in href

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Nov 6 21:31:43 CET 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21770

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81980|0                           |1
        is obsolete|                            |
  Attachment #81983|0                           |1
        is obsolete|                            |
  Attachment #81984|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 82008
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82008&action=edit
Bug 21770: t::lib::QA::TemplateFilters should allow html_entity in href

Bug 21740 highlighted the situation in which the href is not a link (and
thus requiring to be URI/URL encoded). This was fixed on the bug, but
the xt/find-missing-filters.t tests fail on it, becuase they enforce
uri filters on href without exceptions.

This patch adds the exception for those href's starting with '#'

To test:
- Run:
  $ kshell
 k$ prove xt/find-missing-filters.t
=> FAIL: Tests fail
- Apply this patch
- Run:
 k$ prove xt/find-missing-filters.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list