[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if syspref is enabled and patron has an smsalertnumber but no email address

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I've squashed the syspref rename and done a little code golf on the
C4::Suggestions change to try and clarify the intention a little.

QA Scripts are passing, tests are present and passing.. I'm happy to PQA on
this.  I'll add a bug series for extending it's use.. be nice to continue on
this during the next cycle.. I still feel the optimum approach may be to
utilise the advanced messaging preferences a bit more deeply (and perhaps have
a syspref for specifying a fallback order rather than just an email -> sms hard
coded) but for now I think this solves a problem and shouldn't be held up
further.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.