[Koha-bugs] [Bug 21709] Addbiblio shows tag editor icons which do nothing

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Nov 7 14:03:28 CET 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21709

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #7)
> Like that? Also I am wondering if we should not remove some classes, I do
> not know what is the purpose of .buttonDot

This makes no actual difference. I still see a button that does not respond to
clicks. But this is the actual design: if you do not explicitly assign a click
event, it should not respond to click. (The only problem is that we have been
used to some buttons that translated click to focus events.)
I agree with paxed that we should see the difference right away: have a visual
distinction between a real popup and just a focus action (there may be a report
already for that). Only removing the button is not the solution, since we still
want to alert on the focus action.
It should not be that hard to define a separate class and add some css
associated to it to achieve our goal.

On the other hand, when we really want click to translate to focus, add three
lines in the popup script. For instance for 003 in marc21_orgcode.pl:
function Click$params->{id}(event) {
    \$('#'+event.data.id).focus();
}
And now it responds to click and triggers focus.. (I still think though that it
should not be the default.)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.


More information about the Koha-bugs mailing list