[Koha-bugs] [Bug 21774] Cloned item subfields disappear when editing an item

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21774

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to M. Tompsett from comment #12)

> I could sign this off, but then we haven't really solved the enforcing of
> non-repeatables. Why do you think frameworkcode was passed before it was
> removed in bug 19096? It is what would determine if it is repeatable, not
> the default framework. This patch allows anything and all things to repeat.
> Perhaps I'm reading the code wrong? *shrug*

You make a point, but frameworkcode was unfortunately not used to check if the
field was repeatable. There was just a split on pipe.
Report 19096 removed the framework in order to make Koha consistent in its
handling of kohafield: always use the default. But it did not look at
repeatability just as the former code did not. So now we face the challenge of
resolving this issue. The fix here is simple and can still go into 18.11 and
yes it might repeat a bit too much (like before). But benefits are far greater.
And I would still prefer to solve the repeatability issue on another report,
perhaps making its way into 18.11.01 which would be a fix for something that we
did never check before. (Just tested this again in 16.11: put a pipe in your
barcode field.)

So hope you signoff !

-- 
You are receiving this mail because:
You are watching all bug changes.