[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

--- Comment #174 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Some first comments here:

1) CSS
Something is off here, there is no more less directory on master:

http://git.koha-community.org/gitweb/?p=koha.git;a=tree;f=koha-tmpl/opac-tmpl/bootstrap;hb=e112c6f117d4b6fd6c6160e8be9cba4186db1279


koha-tmpl/opac-tmpl/bootstrap/less/opac.less               | 2644
++++++++++++++++++++++++++++++++++++++++++++

Also I think generated .css files should not be included.


2) Asking Joubu to glance at the code, 2 more things (non-blocker):

foreach my $item ( $self->items()->as_list() ) {

would be better as:

while ( my $item = $items->next ) {

And tests should be in their own subtest.

-- 
You are receiving this mail because:
You are watching all bug changes.