[Koha-bugs] [Bug 21814] System preferences save button can be hidden by language menu

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Nov 15 17:40:12 CET 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21814

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> ---
Hi Owen,

Patch works as expected but shouldn't the margin be equal to (or at least based
on) the height of navbar ?

For the navbar we have

min-height: 20px

but it's actually a bit more (30.4px for me) and the patch sets a margin of
3em.

I'm not familiar with SCSS, but this looks like a good candidate for variables.
Something like this:

:root {
  $navbar_height: 30px;
}
.navbar {
  height: $navbar_height;
}
.main {
  margin-bottom: $navbar_height;
}

What do you think ?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list