[Koha-bugs] [Bug 21853] Internal software error when exporting basket group as PDF with Perl > 5.24.1

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21853

--- Comment #7 from M. Tompsett <mtompset at hotmail.com> ---
> (In reply to M. Tompsett from comment #5)
> > Created attachment 82425 [details] [review] [review]
> > Bug 21853: Follow-up to solve printpdf error
> I don't need this patch even in CGI mode. All pdfformat::* modules
> automatically export their printpdf subroutine. Maybe some inconsistent
> Exporter behavior between different Perl versions ?


Retested from scratch today (/var/log/koha/kohadev/intranet-error.log):
[Mon Nov 19 03:40:11.053408 2018] [cgi:error] [pid 32166] [client
10.0.2.2:35866] AH01215: [Mon Nov 19 03:40:11 2018] basketgroup.pl: Useless use
of greediness modifier '?' in regex; marked by <-- HERE in m/(\\S{20}? <-- HERE
)(?=\\S)/ at /usr/share/perl5/PDF/Table.pm line 370.:
/home/vagrant/kohaclone/acqui/basketgroup.pl, referer:
http://localhost:8081/cgi-bin/koha/acqui/basketgroup.pl?booksellerid=1&listclosed=1
And the CGI didn't generate anything. -- Hmmm... same error after my patch, so
not relevant, I guess.

Apply my patch: Got a PDF... with expected output.

Painfully clear test plan:
export LOCAL_ANSIBLE=1;vagrant destroy stretch;vagrant up stretch
vagrant ssh stretch
cd kohaclone
git checkout master
git pull
git remote update -p
git reset --hard origin/master
git checkout -b bug_21853_retry origin/master
git bz apply 21853
i
-- just the first patch
restart_all
sudo service apache2 restart
browse to localhost:8081 and run web installer
log in to staff client
Acquisitions. DOH! Need a budget.
Add a budget.
Acquisitions. DOH! Need a fund in the budget.
Add a fund.
Acquisitions. DOH! Need a vendor.
Add vendor
click Basket Groups on the left pane.
New basket group
save it
Should be listed as open, click the 'close and export' type button.
PDF should be generated and down loaded.
show in file, just to make sure it really is a PDF. Yep. All good.
sudo koha-list --plack
OH! Kohadev is plack on.
sudo koha-plack --disable kohadev
restart_all
sudo service apache2 restart
Click the 'reopen' button.
slower load time, this is good.
click the 'close and export' type button.
nothing?!
Check the log file.
Hmmm...
git bz apply 21853
i
just the second patch
reopen and try again.
PDF generated.
PDF looks okay.

I'm going to trying this all again for good measure. Just to make sure it
wasn't some intermediate step that messed this up.

-- 
You are receiving this mail because:
You are watching all bug changes.