[Koha-bugs] [Bug 21887] 856$u link problem in XSLT result lists and detail page

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21887

--- Comment #5 from David Cook <dcook at prosentient.com.au> ---
Comment on attachment 82677
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82677
Bug 21887: (For OPAC) 856 link problem in XSLT result lists and detail page

Review of attachment 82677:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21887&attachment=82677)
-----------------------------------------------------------------

::: koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl
@@ +1078,5 @@
>                        <xsl:attribute name="href">/cgi-bin/koha/tracklinks.pl?uri=<xsl:value-of select="str:encode-uri(marc:subfield[@code='u'], true())"/>&biblionumber=<xsl:value-of select="$biblionumber"/></xsl:attribute>
>  				</xsl:when>
>  				<xsl:otherwise>
> +                    <xsl:attribute name="href">
> +                        <xsl:if test="not(contains(marc:subfield[@code='u'],'://'))">

I could imagine malformed (yet functional) URLs could cause some problems here. 

Maybe you'd like to try out http://exslt.org/regexp/index.html to be more
precise?

-- 
You are receiving this mail because:
You are watching all bug changes.