[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253

--- Comment #34 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
Comment on attachment 74947
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74947
Bug 15253: Add Koha::Logger based logging for SIP2

Review of attachment 74947:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15253&attachment=74947)
-----------------------------------------------------------------

::: C4/SIP/Sip.pm
@@ +203,5 @@
> +      :                           'error';
> +
> +    my $message = @args ? sprintf($mask, @args) : $mask;
> +
> +    C4::SIP::SIPServer::get_logger()->$method($message);

I think C4::SIP::SIPServer::get_logger() should not be hard coded here because
if the C4::SIP code is used from other parts of Koha like the intranet (yeah, I
know this should not happen but think the same situation with some things in C4
being either just for OPAC or intranet) then instead of the log going to the
intranet log it will go the sip server log.

-- 
You are receiving this mail because:
You are watching all bug changes.