From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 00:19:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 22:19:12 +0000
Subject: [Koha-bugs] [Bug 16690] Remote DB installation is less secure.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 00:19:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 22:19:17 +0000
Subject: [Koha-bugs] [Bug 16690] Remote DB installation is less secure.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79325|0 |1
is obsolete| |
--- Comment #18 from Jonathan Druart ---
Created attachment 79662
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79662&action=edit
Bug 16690: Simplify SHOW GRANTS to work when connected
If the DB is on a remote machine, the web server and the
db server are different, but the SHOW GRANTS code in
installer/install.pl is trying to use the SAME machine.
And even if the permissions were allowed accessing from
both the web and db servers, MySQL won't return the
SHOW GRANTS without access to the mysql.user table. To
install *.* permissions became easiest to get working.
Unless the DB is set up with 'user'@'%', which is also a
potential security issue.
MySQL / MariaDB allow the current connected user to
check their own grants with CURRENT_USER.
There is no need for the installer to know the
IP address of the webserver.
This also removes the need to have permissions for
'koha_kohadev'@'%', because the only process to be
accessing the koha DB is from a known host/ip.
This tightens security too.
TEST PLAN
---------
Install 2 fresh VMs from a Debian ISO.
Make sure they are on the same network (192.168.50.x) as
the kohadevbox. You will need to remember one as DB_IPADDRESS.
On the DB VM & Third VM:
sudo apt-get install mariadb-server mariadb-client net-tools
-- the third vm just needs to be able to run mysql to access
the DB VM.
On DB VM:
sudo vi /etc/mysql/mariadb.conf.d/50-server.cnf
-- make sure the bind-address line is commented out with a #
sudo service mariadb restart
-- congratulations, your DB server is listening to remote
calls now.
sudo mysql -u root
CREATE DATABASE koha_kohadev;
GRANT ALL PRIVILEGES ON `koha_kohadev`.* TO 'koha_kohadev'@'localhost'
IDENTIFIED BY 'password';
FLUSH PRIVILEGES;
-- now you have an empty DB ready to run a web install on.
However, because only koha_kohadev from localhost is
allowed, we expect failure when we try to run the web
installation step when we get there.
Let's confirm that everything is working as expected
before trying. It will also demonstrate the reason why
this patch is superior to the existing code.
On a kohadevbox:
mysql -u koha_kohadev -h DB_IPADDRESS -p
-- this should be denied
On DB VM:
DROP USER 'koha_kohadev'@'localhost';
GRANT ALL PRIVILEGES ON `koha_kohadev`.* TO 'koha_kohadev'@'%' IDENTIFIED BY
'password';
FLUSH PRIVILEGES;
On a kohadevbox:
mysql -u koha_kohadev -h DB_IPADDRESS -p
-- this should give you a SQL prompt
SHOW GRANTS FOR CURRENT_USER;
-- this should show two lines based on 'koha_kohadev'@'%';
SHOW GRANTS FOR 'koha_kohadev'@'192.168.50.10';
-- this should give an access denied error.
SHOW GRANTS FOR 'koha_kohadev'@'%';
-- this should show two lines based on 'koha_kohadev'@'%';
QUIT
-- This case requires the unless code currently in place,
because we aren't checking CURRENT_USER.
On DB VM:
DROP USER 'koha_kohadev'@'%';
GRANT ALL PRIVILEGES ON `koha_kohadev`.* TO 'koha_kohadev'@'192.168.50.10'
IDENTIFIED BY 'password';
FLUSH PRIVILEGES;
On a kohadevbox:
mysql -u koha_kohadev -h DB_IPADDRESS -p
-- this should give you a SQL prompt
SHOW GRANTS FOR CURRENT_USER;
-- this should show two lines based on 'koha_kohadev'@'%';
SHOW GRANTS FOR 'koha_kohadev'@'192.168.50.10';
-- this should show two lines based on 'koha_kohadev'@'192.168.50.10';
SHOW GRANTS FOR 'koha_kohadev'@'%';
-- this should give an access denied error.
QUIT
-- This case demonstrates that we have two failure points:
1) The GRANT command by the DB Admin and
2) The koha-conf.xml setting.
This is why CURRENT_USER is superior: only (2) is the
failure point.
On DB VM:
GRANT ALL PRIVILEGES ON `koha_kohadev`.* TO 'koha_kohadev'@'%' IDENTIFIED BY
'password';
FLUSH PRIVILEGES;
SELECT host,user FROM mysql.user;
-- Should see both koha_kohadev for 192.168.50.10 and %.
On a kohadevbox:
mysql -u koha_kohadev -h DB_IPADDRESS -p
-- this should give you a SQL prompt
SHOW GRANTS FOR CURRENT_USER;
-- this should show two lines based on 'koha_kohadev'@'192.168.50.10';
SHOW GRANTS FOR 'koha_kohadev'@'192.168.50.10';
-- this should show two lines based on 'koha_kohadev'@'192.168.50.10';
SHOW GRANTS FOR 'koha_kohadev'@'%';
-- this should give an access denied error.
QUIT
-- This case doesn't need the unless. CURRENT_USER still
just works.
On an third VM on the same network:
mysql -u koha_kohadev -h DB_IPADDRESS -p
-- this should give you a SQL prompt
SHOW GRANTS FOR CURRENT_USER;
-- this should show two lines based on 'koha_kohadev'@'%';
SHOW GRANTS FOR 'koha_kohadev'@'192.168.50.10';
-- this should give an access denied error.
SHOW GRANTS FOR 'koha_kohadev'@'%';
-- this should show two lines based on 'koha_kohadev'@'%';
QUIT
-- This case demonstrates that it may be more open than a DB
administrator would prefer. And notice, CURRENT_USER still
just works.
On DB VM:
DROP USER 'koha_kohadev'@'192.168.50.10';
DROP USER 'koha_kohadev'@'%';
GRANT ALL PRIVILEGES ON *.* TO 'koha_kohadev'@'%' IDENTIFIED BY 'password';
FLUSH PRIVILEGES;
-- This basically give koha_kohadev free reign to do pretty
dangerous stuff.
On an third VM on the same network:
mysql -u koha_kohadev -h DB_IPADDRESS -p
-- this should give you a SQL prompt
SHOW GRANTS FOR CURRENT_USER;
-- this should show a line based on 'koha_kohadev'@'%';
SHOW GRANTS FOR 'koha_kohadev'@'192.168.50.10';
-- this should give a no such grant error.
SHOW GRANTS FOR 'koha_kohadev'@'%';
-- this should show two lines based on 'koha_kohadev'@'%';
QUIT
-- This case demonstrates that it may be more open than a DB
administrator would prefer. And notice, CURRENT_USER still
just works.
In the old code, both cases were literally checked.
This tweak is an optimization which doesn't require
setting permissions to the mysql.user table. Without it,
the code says the user doesn't have permissions to check
the show grants. This issue is not visible to the user,
because both cases are checked.
On DB VM:
SELECT host,user FROM mysql.user;
-- for each one do an appropriate DROP USER 'user'@'host';
GRANT ALL PRIVILEGES ON `koha_kohadev`.* TO 'koha_kohadev'@'192.168.50.10'
IDENTIFIED BY 'password';
On kohadevbox:
-- Make sure the /etc/koha/sites/kohadev/koha-conf.xml
points to the DB VM.
-- Make sure a web install runs correctly
On third VM:
-- Make sure unable to connect as koha_kohadev/password.
Signed-off-by: Martin Renvoize
Signed-off-by: Jonathan Druart
I have not followed the whole test plan but trusting author and SO
Changes make sense to me
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 00:25:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 22:25:58 +0000
Subject: [Koha-bugs] [Bug 21289] Error when sending emails to partner
libraries
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21289
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 00:26:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 22:26:02 +0000
Subject: [Koha-bugs] [Bug 21289] Error when sending emails to partner
libraries
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21289
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79380|0 |1
is obsolete| |
--- Comment #3 from Jonathan Druart ---
Created attachment 79663
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79663&action=edit
Bug 21289: Fix "isa" bug during partner request
We cannot call 'handle_commit_maybe' inside a 'try' block.
handle_commit_maybe redirects the client then calls 'exit', this is
interpreted as an error and the 'catch' block is erroneously called.
This patch moves the calling of 'handle_commit_maybe' outside the try
block, it will only be reached if everything inside the try block
suceeds.
To test:
1) Enable ILL and have the FreeForm backend available
2) Create a patron category to hold ILL "partners" to whom requests can
be sent. The category can be called anything, you should note the code
you assign
3) Create a patron that belongs to your new category, the patron must
have a primary email defined.
4) In your block in koha-conf.xml, ensure you have
a element, it should contain the code you assigned in
step 2
5) Create an ILL request using the FreeForm backend
6) Once the request is created, select the "Place request with partners"
button
7) Select your "partner" from the "Select partner libraries" box
8) Click "Send email"
9) TEST: Observe no errors are displayed in the UI
Signed-off-by: Barry Cannon
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 00:31:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 22:31:38 +0000
Subject: [Koha-bugs] [Bug 21365] Advanced MARC Editor - Rancor -
BiblioAddsAuthorities not working
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21365
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #3 from Jonathan Druart ---
Should not it be better to call BiblioAutoLink from AddBiblio and ModBiblio?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 00:46:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 22:46:20 +0000
Subject: [Koha-bugs] [Bug 21337] Add Koha::Patrons->delete (trivial wrapper)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21337
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
Status|Signed Off |Failed QA
--- Comment #7 from Jonathan Druart ---
I do not think the implementation is correct. DBIC would execute only 1 query
on Set->delete, which means no entries will be removed if at least one cannot
be removed.
I would say we should do the same, i.e. execute in a transaction and rollback
if something went wrong.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 00:49:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 22:49:39 +0000
Subject: [Koha-bugs] [Bug 21401] Account offsets should save the transacting
library
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21401
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #10 from Jonathan Druart ---
- Use cases?
- Maybe we should use ON DELETE SET NULL instead of cascade?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 00:51:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 22:51:21 +0000
Subject: [Koha-bugs] [Bug 21376] Catalogue detail date handling improvements
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21376
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 00:51:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 22:51:26 +0000
Subject: [Koha-bugs] [Bug 21376] Catalogue detail date handling improvements
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21376
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79289|0 |1
is obsolete| |
Attachment #79290|0 |1
is obsolete| |
--- Comment #7 from Jonathan Druart ---
Created attachment 79664
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79664&action=edit
Bug 21376: Add ability to date sorting in items table on catalogue detail
Changes in this patch (page catalogue/detail):
- enable sorting by date in items table
Signed-off-by: Michal Denar
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 00:51:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 22:51:30 +0000
Subject: [Koha-bugs] [Bug 21376] Catalogue detail date handling improvements
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21376
--- Comment #8 from Jonathan Druart ---
Created attachment 79665
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79665&action=edit
Bug 21376: Add date accessioned to items table on catalogue detail page
Changes in this patch (page catalogue/detail):
- added date accesioned to items table
Signed-off-by: Michal Denar
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 00:55:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 22:55:01 +0000
Subject: [Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix
waiting holds at wrong location bug
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #16 from Jonathan Druart ---
This is bugfix, not an enhancement, right?
I would suggest to provide a patch which would not contain the indentation
changes, that will generate conflicts and make the backport harder.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 01:08:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 23:08:24 +0000
Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart
location
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #27 from Jonathan Druart ---
Please resubmit without the indentation changes.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 01:15:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 23:15:22 +0000
Subject: [Koha-bugs] [Bug 9188] Remove 'debug' information from patron
statistics
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9188
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 01:15:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 23:15:26 +0000
Subject: [Koha-bugs] [Bug 9188] Remove 'debug' information from patron
statistics
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9188
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79659|0 |1
is obsolete| |
--- Comment #14 from Jonathan Druart ---
Created attachment 79666
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79666&action=edit
Bug 9188: Remove 'debug' information from patron statistics
TEST PLAN
---------
run patron statistics without filtering
-- notice lots of text at top.
run patron statistics with filtering
-- notice lots of text at top.
apply patch
run it without and without filtering
-- amount of text should be small or none and be related to the filtering
selected.
run koha qa test tools
Signed-off-by: Andreas Roussos
Works as expected, i.e. only filtering information is displayed.
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 01:20:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 23:20:25 +0000
Subject: [Koha-bugs] [Bug 21425] basketno not being interpolated into error
message
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21425
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #3 from Jonathan Druart ---
Still no test for this module?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 01:21:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 23:21:17 +0000
Subject: [Koha-bugs] [Bug 21425] basketno not being interpolated into error
message
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21425
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 01:21:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 23:21:21 +0000
Subject: [Koha-bugs] [Bug 21425] basketno not being interpolated into error
message
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21425
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79487|0 |1
is obsolete| |
--- Comment #4 from Jonathan Druart ---
Created attachment 79667
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79667&action=edit
Bug 21425 Display basketno correctly in Order error msg
carp will display the hash value instead of the desired basketno
in the error message unless we change its behaviour
Use the simpler but effective option of concatenating
the errormessage with the basketno. Error is shown if no
sender or receipient ean is passed in instantiating
an Koha::Edifact::Order object
Signed-off-by: Kyle M Hall
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 01:25:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 23:25:18 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
OneClickdigital/Recorded Books API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 01:25:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 23:25:27 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
OneClickdigital/Recorded Books API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #78602|0 |1
is obsolete| |
Attachment #78603|0 |1
is obsolete| |
Attachment #78604|0 |1
is obsolete| |
Attachment #78605|0 |1
is obsolete| |
Attachment #78606|0 |1
is obsolete| |
Attachment #78607|0 |1
is obsolete| |
Attachment #78608|0 |1
is obsolete| |
Attachment #78609|0 |1
is obsolete| |
Attachment #78610|0 |1
is obsolete| |
Attachment #78611|0 |1
is obsolete| |
Attachment #78612|0 |1
is obsolete| |
Attachment #78613|0 |1
is obsolete| |
Attachment #78614|0 |1
is obsolete| |
Attachment #78615|0 |1
is obsolete| |
Attachment #79247|0 |1
is obsolete| |
--- Comment #117 from Jonathan Druart ---
Created attachment 79668
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79668&action=edit
Bug 17602: Koha::ExternalContent->koha_patron() will retutn undef rather than
die if user not logged in
Signed-off-by: Nick Clemens
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 01:25:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 23:25:35 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
OneClickdigital/Recorded Books API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602
--- Comment #118 from Jonathan Druart ---
Created attachment 79669
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79669&action=edit
Bug 17602: RecordedBooks Integration to Koha
This patch introduces the required sysprefs and
Koha::ExternalContent::RecordedBooks
Koha::ExternalContent::RecordedBooks - a wrapper around
WebService::ILS::RecordedBooks::PartnerPatron
RecordedBooks* sysprefs
Nothing functional to test with this patch yet.
But you can run the tests that come with it
t/db_dependent/Koha_ExternalContent_RecordedBooks.t
Signed-off-by: Nick Clemens
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 01:25:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 23:25:43 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
OneClickdigital/Recorded Books API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602
--- Comment #119 from Jonathan Druart ---
Created attachment 79670
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79670&action=edit
Bug 17602: OPAC integration of RecordedBooks
Add RecordedBooks to the users page in the public interface
To Test:
1/ Apply all 3 patches
2/ Set the sysprefs to valid values (you will need a test account with
RecordedBooks)
3/ Try a search
4/ Login to the OPAC, try to place a hold, or check an item out
5/ Check the opac-user page, see if your items are showing on the
oneclickdigital tab
Signed-off-by: Nick Clemens
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 01:25:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 23:25:51 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
OneClickdigital/Recorded Books API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602
--- Comment #120 from Jonathan Druart ---
Created attachment 79671
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79671&action=edit
Bug 17602 follow-up: t/Koha_ExternalContent_RecordedBooks.t
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 01:26:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 23:26:00 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
OneClickdigital/Recorded Books API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602
--- Comment #121 from Jonathan Druart ---
Created attachment 79672
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79672&action=edit
Bug 17602: Ease translation
Use String.format() to make translation easier
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 01:26:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 23:26:10 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
OneClickdigital/Recorded Books API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602
--- Comment #122 from Jonathan Druart ---
Created attachment 79673
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79673&action=edit
Bug 17602: Handle '60+' if there are more than 60 results
The service returns "60+" if there are more than 60 results.
Without this patch the "Found %s results in RecordedBooks collection"
line is removed.
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 01:26:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 23:26:25 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
OneClickdigital/Recorded Books API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602
--- Comment #124 from Jonathan Druart ---
Created attachment 79675
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79675&action=edit
Bug 17602: Fix few minor QA issues
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 01:26:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 23:26:30 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
OneClickdigital/Recorded Books API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602
--- Comment #125 from Jonathan Druart ---
Created attachment 79676
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79676&action=edit
Bug 17602: Translations rework
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 01:26:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 23:26:36 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
OneClickdigital/Recorded Books API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602
--- Comment #126 from Jonathan Druart ---
Created attachment 79677
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79677&action=edit
Bug 17602: fix RecordedBooks results pagination
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 01:26:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 23:26:44 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
OneClickdigital/Recorded Books API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602
--- Comment #127 from Jonathan Druart ---
Created attachment 79678
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79678&action=edit
Bug 17602: Removed unused param to RecordedBooks API
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 01:26:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 23:26:18 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
OneClickdigital/Recorded Books API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602
--- Comment #123 from Jonathan Druart ---
Created attachment 79674
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79674&action=edit
Bug 17602: Adapt test plan to make the tests pass
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 01:26:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 23:26:52 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
OneClickdigital/Recorded Books API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602
--- Comment #128 from Jonathan Druart ---
Created attachment 79679
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79679&action=edit
Bug 17602: (follow-up) Adjust js paths to use version add spinner
Also included recompiled version of opac.css that we forgot.
Signed-off-by: Srdjan
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 01:26:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 23:26:59 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
OneClickdigital/Recorded Books API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602
--- Comment #129 from Jonathan Druart ---
Created attachment 79680
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79680&action=edit
Bug 17602: Use Asset TT plugin and fix indentation
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 01:27:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 23:27:06 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
OneClickdigital/Recorded Books API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602
--- Comment #130 from Jonathan Druart ---
Created attachment 79681
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79681&action=edit
Bug 17602: (QA follow-up) Fix tests
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 01:27:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 30 Sep 2018 23:27:13 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
OneClickdigital/Recorded Books API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602
--- Comment #131 from Jonathan Druart ---
Created attachment 79682
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79682&action=edit
Bug 17602: Move spinner location to include file
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 02:01:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 00:01:13 +0000
Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #103 from Jonathan Druart ---
QA comments (reading the code):
1. I do not understand Koha::Serials::get_serial_items_count, several things
are wrong:
* you should not export, it must be a method and called like others:
Koha::Module->method
* my ( @self ) = @_;
No, $self must be the object, then you pass the parameters.
*
+ while ( my $s = $serialitems->next() ) {
+ $countitem++;
+ }
=> You actually want ->count
* And finally, what is it supposed to do? and why?
`git grep get_serial_items_count` returns only one occurrence:
serials/serials-collection.pl:my
@serialitemsinformation=get_serial_items_count(@ids);
It returns an array of hashes (2 keys: countitems and serialid), countitems is
used later, and serialid is not.
Moreover I have no idea what the following is supposed to do
130 foreach my $line (@serialitemsinformation){
131 DelItem($line);
132 }
It certainly does not work.
I would suggest you to rethink this as a method, for instance I am pretty sure
you are looking for something like that: Koha::Serial->items which would return
the items (Koha::Items!) for a given Koha::Serial object (already said, less
explicitly, on comment 32)
2. You do not need to concat with '!' then split, you can pass several times a
parameters (and retrieve them pl side with CGI->multi_param). It will simplify
a lot the javascript code (function deleteIssues).
3. $delete and $confdelete should not be variables, but values of $op (usually
"delete_confirm" and "delete_confirmed", see admin/cities.pl)
4. function generateReceive (serials-collection.tt) re-added, has been deleted
previously by bug 18327.
5. Same for addsubscriptionid, delete by bug 19777.
IMO it would be easier to redo these patches from scratch and abandon the too
long patches history.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 02:06:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 00:06:22 +0000
Subject: [Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix
waiting holds at wrong location bug
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346
--- Comment #17 from Christopher Brannon ---
(In reply to Jonathan Druart from comment #16)
> This is bugfix, not an enhancement, right?
> I would suggest to provide a patch which would not contain the indentation
> changes, that will generate conflicts and make the backport harder.
It is both. Please explain. I don't understand the issue.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 02:07:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 00:07:41 +0000
Subject: [Koha-bugs] [Bug 21437] Switch two-column templates to Bootstrap
grid: Patron lists
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21437
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79574|0 |1
is obsolete| |
--- Comment #3 from Jonathan Druart ---
Created attachment 79683
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79683&action=edit
Bug 21437: Update two-column templates with Bootstrap grid: Patron lists
This patch modifies the patron lists templates to use the Bootstrap grid
instead of YUI.
This patch also removes obsolete "text/javascript" attributes from
' %]
[% x | $Price %]
=> Display '0.00'
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 14:00:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 12:00:57 +0000
Subject: [Koha-bugs] [Bug 21418] Incorrectly filtered markup in staff client
lists
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21418
--- Comment #9 from Owen Leonard ---
Created attachment 79707
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79707&action=edit
Bug 21418: Remove shelfoff which is not used
No need to add a new line to escape this variable that is never used,
better to remove it
`git grep shelfoff` will prove that it is not used anywhere else.
Signed-off-by: Jonathan Druart
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 14:00:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 12:00:52 +0000
Subject: [Koha-bugs] [Bug 21418] Incorrectly filtered markup in staff client
lists
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21418
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79611|0 |1
is obsolete| |
Attachment #79612|0 |1
is obsolete| |
--- Comment #8 from Owen Leonard ---
Created attachment 79706
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79706&action=edit
Bug 21418: Html escape the 2 variables
We should be on the safe side without this patch because shelfnumber and
type comes from the DB and are integer or varchar. It may be better to
show good examples to start, and escape everything anyway.
Signed-off-by: Jonathan Druart
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 14:12:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 12:12:51 +0000
Subject: [Koha-bugs] [Bug 21337] Add Koha::Patrons->delete (trivial wrapper)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21337
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|Trivial patch |Small patch
Status|Failed QA |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 14:12:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 12:12:55 +0000
Subject: [Koha-bugs] [Bug 21337] Add Koha::Patrons->delete (trivial wrapper)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21337
--- Comment #8 from Marcel de Rooy ---
Created attachment 79708
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79708&action=edit
Bug 21337: (QA follow-up) Rollback for partial delete
Puts delete loop in a txn_do.
Raises Koha::Exceptions::Patron::Delete when Patron->delete does not return
true (like 0 or -1).
Unit test adjusted accordingly.
Note: A follow-up report for raising exceptions in Object->delete could well
be considered. Not here please.
Test plan:
Run t/db_dependent/Koha/Patrons.t
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 14:13:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 12:13:20 +0000
Subject: [Koha-bugs] [Bug 21337] Add Koha::Patrons->delete (trivial wrapper)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21337
--- Comment #9 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #7)
> I do not think the implementation is correct. DBIC would execute only 1
> query on Set->delete, which means no entries will be removed if at least one
> cannot be removed.
> I would say we should do the same, i.e. execute in a transaction and
> rollback if something went wrong.
See follow-up.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 14:14:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 12:14:18 +0000
Subject: [Koha-bugs] [Bug 21337] Add Koha::Patrons->delete (trivial wrapper)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21337
--- Comment #10 from Marcel de Rooy ---
Please ignore false message of qa tools about POD coverage. This exception
class is just like all the others.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 14:17:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 12:17:11 +0000
Subject: [Koha-bugs] [Bug 21337] Add Koha::Patrons->delete (trivial wrapper)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21337
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79708|0 |1
is obsolete| |
--- Comment #11 from Marcel de Rooy ---
Created attachment 79709
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79709&action=edit
Bug 21337: (QA follow-up) Rollback for partial delete
Puts delete loop in a txn_do.
Raises Koha::Exceptions::Patron::Delete when Patron->delete does not return
true (like 0 or -1).
Unit test adjusted accordingly.
Note: A follow-up report for raising exceptions in Object->delete could well
be considered. Not here please.
Test plan:
Run t/db_dependent/Koha/Patrons.t
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 14:21:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 12:21:27 +0000
Subject: [Koha-bugs] [Bug 21461] New: Add logging for ILL
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21461
Bug ID: 21461
Summary: Add logging for ILL
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: ILL
Assignee: koha-bugs at lists.koha-community.org
Reporter: magnus at libriotech.no
Should log things like
- End user actions in the OPAC
- Librarian actions in the staff client
- Cron job actions that interact with external APIs (e.g. for collecting new
requests)
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 14:23:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 12:23:41 +0000
Subject: [Koha-bugs] [Bug 21448] Field 606 doesn't add multiple x subfields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21448
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 14:23:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 12:23:45 +0000
Subject: [Koha-bugs] [Bug 21448] Field 606 doesn't add multiple x subfields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21448
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79620|0 |1
is obsolete| |
--- Comment #4 from Jonathan Druart ---
Created attachment 79710
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79710&action=edit
Bug 21448: Fix copy repeated subfields when linking an authority with 6xx
The reported issue was:
On field 606, if I use an Authority with multiple "x" subfields, it will
add just the first "x"
Error in the logs:
Odd number of elements in anonymous hash at
/home/vagrant/kohaclone/authorities/blinddetail-biblio-search.pl line 97.
We should pass a ref (!), caused by
commit a7df1f9f8eb9ed16246964d94dd8a69b756b6551
Bug 18904: (follow-up) Retrieve subfield in the order they are stored
Test plan:
Edit an authority and add several $x to 600
Link this authority to a bibliographic record
=> Without this patch only the first subfield is copied
=> With this patch applied they are all copied
Signed-off-by: Jos? Anjos
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 14:24:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 12:24:19 +0000
Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines
list
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136
Johan Larsson changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |---
Status|RESOLVED |REOPENED
CC| |johan.larsson at ub.gu.se
--- Comment #24 from Johan Larsson ---
After the new column with homebranch was added the button for "filter paid
transactions" does not work.
The code that should be adjusted is:
table_account_fines.fnFilter(filteredValue, 4, true, false);
it should now be
table_account_fines.fnFilter(filteredValue, 5, true, false);
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 14:24:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 12:24:58 +0000
Subject: [Koha-bugs] [Bug 21448] Field 606 doesn't add multiple x subfields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21448
--- Comment #5 from Jonathan Druart ---
Hi Jos?, thanks for testing.
Do not forget to adjust the status, see also
https://wiki.koha-community.org/wiki/Sign_off_on_patches
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 14:24:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 12:24:58 +0000
Subject: [Koha-bugs] [Bug 21461] Add logging for ILL
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21461
--- Comment #1 from Magnus Enger ---
I guess an initial patch for this would just do a few simple things like:
- add ILL as a module in the log viewer
- add a syspref for turning ILL logging on and off
And then a lot of the logging will need to be done by the different
backends/plugins.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 14:31:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 12:31:56 +0000
Subject: [Koha-bugs] [Bug 20356] Add EmailSMSSendDriverFromAddress system
preference for overriding Email SMS send driver from address
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356
Michal Denar changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |black23 at gmail.com
--- Comment #5 from Michal Denar ---
Please rebase on master, I'll test it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 14:42:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 12:42:44 +0000
Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines
list
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136
Johan Larsson changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
--- Comment #25 from Johan Larsson ---
Will open new bug
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 14:43:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 12:43:57 +0000
Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines
list
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136
--- Comment #26 from Nick Clemens ---
Created attachment 79711
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79711&action=edit
Bug 15136: (follow-up) Fix 'Filter paid transactions' button
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 14:45:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 12:45:53 +0000
Subject: [Koha-bugs] [Bug 7088] cannot renew items on hold even with override
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Fiona Borthwick changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fiona.borthwick at ptfs-europe
| |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 14:49:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 12:49:22 +0000
Subject: [Koha-bugs] [Bug 21462] New: "Filter paid transactions" stopped
working after html-table was changed
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21462
Bug ID: 21462
Summary: "Filter paid transactions" stopped working after
html-table was changed
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Fines and fees
Assignee: koha-bugs at lists.koha-community.org
Reporter: johan.larsson at ub.gu.se
QA Contact: testopia at bugs.koha-community.org
Related to 15136
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 14:50:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 12:50:11 +0000
Subject: [Koha-bugs] [Bug 20356] Add EmailSMSSendDriverFromAddress system
preference for overriding Email SMS send driver from address
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356
David Gustafsson changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #72517|0 |1
is obsolete| |
Attachment #75111|0 |1
is obsolete| |
--- Comment #6 from David Gustafsson ---
Created attachment 79712
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79712&action=edit
Bug 20356: Add EmailSMSSendDriverFromAddress system preference
Add EmailSMSSendDriverFromAddress system preference for overriding Email
SMS send driver from address.
How to test:
1) Run tests in t/db_dependent/Letters.t
2) All tests should pass
Sponsored-by: Gothenburg University Library
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 15:01:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 13:01:40 +0000
Subject: [Koha-bugs] [Bug 21462] "Filter paid transactions" stopped working
after html-table was changed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21462
--- Comment #1 from Johan Larsson ---
Created attachment 79713
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79713&action=edit
wrong column was selected for filtering the table. This was caused by changing
the hmtl-structure of the table
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 15:01:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 13:01:51 +0000
Subject: [Koha-bugs] [Bug 21454] Price filtered variables should not need to
be html filtered
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21454
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nick at bywatersolutions.com
Status|Signed Off |Passed QA
--- Comment #7 from Nick Clemens ---
Moving to PQA - reviewed, changes all make sense
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 15:02:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 13:02:35 +0000
Subject: [Koha-bugs] [Bug 21462] "Filter paid transactions" stopped working
after html-table was changed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21462
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |johan.larsson at ub.gu.se
|ity.org |
CC| |nick at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 15:04:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 13:04:48 +0000
Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines
list
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136
Johan Larsson changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |---
--- Comment #27 from Johan Larsson ---
New bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21462
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 15:08:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 13:08:59 +0000
Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines
list
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136
Johan Larsson changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|REOPENED |RESOLVED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 15:10:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 13:10:07 +0000
Subject: [Koha-bugs] [Bug 21462] "Filter paid transactions" stopped working
after html-table was changed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21462
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |15136
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136
[Bug 15136] Display item's homebranch in patron's fines list
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 15:10:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 13:10:07 +0000
Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines
list
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |21462
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21462
[Bug 21462] "Filter paid transactions" stopped working after html-table was
changed
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 15:16:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 13:16:44 +0000
Subject: [Koha-bugs] [Bug 21385] Vendor search: Item count is incorrectly
updated on partial receive
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385
Caroline Cyr La Rose changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--- Comment #16 from Caroline Cyr La Rose ---
The signoff was good. It worked as expected.
The patch was meant to make sure the item count in a basket stayed the same
even when the order was partially received.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 15:21:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 13:21:37 +0000
Subject: [Koha-bugs] [Bug 21174] Change default behavior to open OPAC cart
in one click
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 15:21:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 13:21:41 +0000
Subject: [Koha-bugs] [Bug 21174] Change default behavior to open OPAC cart
in one click
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79647|0 |1
is obsolete| |
--- Comment #21 from Owen Leonard ---
Created attachment 79714
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79714&action=edit
Bug 21174: Open the OPAC cart with one click by default
Feedback from the Koha mailing list in Aug 2018 showed there was
widespread concensus for making the default behaviour of the OPAC cart
to be to open with one click, rather than clicking on the cart icon then
on the dropdown box to load the cart popup.
This commit is a combination of Owen Leonard's alternative patch
(slightly changing the markup in masthead.inc) and my
work to remove the dropdown elements from the template and basket.js
Test plan:
1. In Koha OPAC click on the cart icon (making sure to have items in the
cart and the dropdown box 'Items in your cart:..' appears.
2. Click this dropdown and the cart popup appears.
3. Confirm you can successfully remove items from and empty the
cart
4. Apply patch
5. Restart memcached, and plack
6. Click on the cart icon (making sure to have items in the cart) and
notice no 'Items in your: ..' dropdown appears
instead the cart popup loads straight away.
7. Confirm the items in your cart are displayed by the cart popup
8. Confirm you can remove items from/empty the cart, and that as you do
this the number of cart items shown by the number to the right of the
cart icon changes accordingly
Sponsored-By: Toi Ohomai Institute of Technology, New Zealand
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 15:28:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 13:28:36 +0000
Subject: [Koha-bugs] [Bug 10382] collection not returning to null when
removed from course reserves
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #61 from Caroline Cyr La Rose ---
Created another course, added items (changed collection code), tried disabling
the course
Software error:
Undefined subroutine &C4::Items::ModZebra called at
/inlibro/git/koha-master-dev-inlibro/C4/Items.pm line 606.
Maybe I'll try with a sandbox.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 15:38:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 13:38:05 +0000
Subject: [Koha-bugs] [Bug 17282] Ability to create charts for SQL reports
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282
--- Comment #65 from Nick Clemens ---
(In reply to Jonathan Druart from comment #64)
> (In reply to Nick Clemens from comment #63)
> > I think some of the lines in chart.inc need filters? They are not failing
> > the test but want to make sure before pushing.
>
> Which ones? Did you see the last patch?
/me is embarassed, my bad
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 15:40:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 13:40:18 +0000
Subject: [Koha-bugs] [Bug 21453] blinddetail-biblio-search.pl/.tt use
hardcoded subfield values for MARC21
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21453
Andreas Roussos changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |ASSIGNED
--- Comment #2 from Andreas Roussos ---
A colleague has found a case where the patch does not work as intended
and may break some setups: when the authority finder is used from
within the bibliographic editor (e.g. to link an authority to UNIMARC
tag 700), it will populate field $3 ('Authority Record Number') with
the auth id but not field $9 ('Koha Internal Code') as it did prior to
the patch.
I'll try to revise my patch and provide a more thorough test plan.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 15:40:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 13:40:28 +0000
Subject: [Koha-bugs] [Bug 20563] ILL request list gives no indication of
source and/or target
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563
--- Comment #8 from Andrew Isherwood ---
Rebased and fixed merge conflict
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 15:40:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 13:40:06 +0000
Subject: [Koha-bugs] [Bug 20563] ILL request list gives no indication of
source and/or target
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79523|0 |1
is obsolete| |
--- Comment #7 from Andrew Isherwood ---
Created attachment 79715
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79715&action=edit
Bug 20563: Allow display of requested partners
This patch adds the display of requested partner email addresses when an
ILL backend provides the ability to send requests to partners. Partner
email addresses are displayed in the illlist and illview displays, they
are also included in the 'illrequests' API response.
* api/v1/swagger/paths/illrequests.json:
- Add 'requested_partners' as an 'embed' enum
* Koha/Illrequest.pm:
- Add 'requested_partners' accessor calling optional backend
'get_requested_partners' method.
- Store requested partners upon email send, calling optional backend
'set_requested_partners' method.
- Add 'requested_parners' embed to overloaded TO_JSON method.
* koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt:
- Add 'requested_partners' embed to illrequests API call
- Add render function for "Additional status" datatables column
- Add display of requested partner email addresses to illlist table
- Add display of requested partner email addresses to illview display
To test:
1) Enable Interlibrary loans
2) Add a backend that supports sending requests to partners, e.g.
FreeForm
3) Set up at least one partner
4) Create an ILL request
5) Send request to partner(s)
6) Observe partner(s) email address(es) are displayed in "View ILL
requests" view
7) Observe partner(s) email address(es) are displayed in "Manage ILL
request" view
Signed-off-by: mmg at interleaf.ie
https://bugs.koha-community.org/show_bug.cgi?id=20653
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 15:41:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 13:41:41 +0000
Subject: [Koha-bugs] [Bug 21387] Receive items from - form should include
tax hints the same as the ordering form
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #3 from Owen Leonard ---
We usually use a "hint" class for adding additional information to a form or
similar display. To my eye it looks good inline, so around
the new text.
I think it would be better not to abbreviate "inc" and "exc."
One problem I saw: In my test system I got this:
Retail price:
18.58 Adjusted for , tax exc.
I don't know why it isn't displaying the active currency.
Also: This will require a rebase on top of Bug 21454, Remove html filter for
Price filtered variables.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 15:51:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 13:51:07 +0000
Subject: [Koha-bugs] [Bug 15529] Process Message Queue may send duplicate
emails if process is launched twice
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529
--- Comment #17 from M. Tompsett ---
How about this?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 15:53:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 13:53:09 +0000
Subject: [Koha-bugs] [Bug 10382] collection not returning to null when
removed from course reserves
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #62 from Caroline Cyr La Rose ---
I get the same error message in a sandbox (tried with BibLibre sandbox 5 and
PTFS Europe sandbox 0)
Software error:
Undefined subroutine &C4::Items::ModZebra called at /home/koha/src/C4/Items.pm
line 606.
Here are the exact steps I went through in the sandboxes
1- Go to Administration
2- Search for UseCourseReserves
3- Change UseCourseReserves to "Use"
4- Click on "Save all Circulation preferences"
5- Go to Home > Course reserves
6- Click on "New course"
7- Click on link to add department
8- Click on "New authorized value for DEPARTMENT"
9- Fill in Authorizd value and Description
10- Click on "Save"
11- Go back to More > Course reserves
12- Click on "New Course"
13- Fill in the mandatory info (dept, course number, course name)
14- Leave course "enabled"
15- Click on "Save"
16- Click on "Batch add reserves"
17- Open Item search in another tab
18- Search for all items
19- Copy/Paste barcodes in the course batch add box
20- Change collection code
21- Click "Submit"
22- Click "View course"
23- Open one of the records in another tab
24- Click on "Edit course"
25- Uncheck "Enabled"
26- Click "Save" <- Software Error
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:02:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:02:20 +0000
Subject: [Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584
Cori Lynn Arnold` changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |carnold at dgiinc.com
|ity.org |
CC| |carnold at dgiinc.com
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:03:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:03:27 +0000
Subject: [Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584
Cori Lynn Arnold` changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #20 from Cori Lynn Arnold` ---
Walking through the Koha-how-to
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:06:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:06:27 +0000
Subject: [Koha-bugs] [Bug 20563] ILL request list gives no indication of
source and/or target
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563
--- Comment #9 from Andrew Isherwood ---
Created attachment 79716
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79716&action=edit
Bug 20563: (follow-up) Add unit test
This unit test tests the fetching of the requested_partners embed, if
specified.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:15:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:15:22 +0000
Subject: [Koha-bugs] [Bug 5161] patron attributes clearing if duplicate
warning
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5161
Ray Delahunty changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |r.delahunty at arts.ac.uk
--- Comment #6 from Ray Delahunty ---
Data loss is occurring in quite a number of data fields already keyed
(including what we found here today- the new user's expiry date). There are at
least two other bug reports listing data loss in addition to this one for
attributes. These are 15737 and 20762. Should I open a new bug report or will
the changes being proposed fix all data loss in the various fields? I note that
once the duplicate warning is made, it is possible to go down into the form and
rekey the lost data before returning to the duplicate warning and accepting the
new-user-create, and the data rekeyed remains.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:15:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:15:29 +0000
Subject: [Koha-bugs] [Bug 21426] setting USE_MEMCACHED to "no" in
koha-sites.conf does not have any effect
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426
--- Comment #9 from Andreas Roussos ---
(In reply to Andreas Roussos from comment #0)
> Oddly enough, once my instance was up and running I noticed that a
> memcached process had been started (Home > About Koha in the Staff
> interface also reported memcached as running).
Actually, the memcached process had been there all along. The daemon
is set to start automatically for runlevel 3 ('multi-user.target' in
systemd-speak).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:24:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:24:46 +0000
Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart
location
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355
--- Comment #30 from Jonathan Druart ---
Created attachment 79717
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79717&action=edit
[ALTERNATIVE-PATCH %] Bug 18355: Display permanent location with cart location
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:27:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:27:22 +0000
Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart
location
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |In Discussion
--- Comment #31 from Jonathan Druart ---
Hi Christopher,
I would suggest to move the display logic to the template for several reasons:
- the pl logic from the first patch is not easy to read
- not defined AV are handled properly by the template plugin
(Koha::Template::Plugin::AuthorisedValues)
- as we are going to reuse this logic, we will move it to an include file to
avoid copy/paste
Could you take a look at tell me what you think about it?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:30:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:30:25 +0000
Subject: [Koha-bugs] [Bug 21426] setting USE_MEMCACHED to "no" in
koha-sites.conf does not have any effect
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426
Andreas Roussos changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79660|0 |1
is obsolete| |
--- Comment #10 from Andreas Roussos ---
Created attachment 79718
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79718&action=edit
Bug 21426: Handle USE_MEMCACHED=no in koha-create
Signed-off-by: Andreas Roussos
Works as intended. I've set USE_MEMCACHED to "no" and created a new
Koha instance. Home > About now reports this information: Memcached:
Servers: undefined | Namespace: undefined | Status: unknown | Config
read from: Nowhere [...] | Effective caching method: Cache::Memory
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:30:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:30:20 +0000
Subject: [Koha-bugs] [Bug 21426] setting USE_MEMCACHED to "no" in
koha-sites.conf does not have any effect
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21426
Andreas Roussos changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:32:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:32:16 +0000
Subject: [Koha-bugs] [Bug 15529] Process Message Queue may send duplicate
emails if process is launched twice
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|In Discussion |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:32:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:32:19 +0000
Subject: [Koha-bugs] [Bug 15529] Process Message Queue may send duplicate
emails if process is launched twice
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529
--- Comment #18 from M. Tompsett ---
Created attachment 79719
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79719&action=edit
Bug 15529: Followup to send without more libraries
This uses the letter_code parameter to limit the current
duplicate run of the process_message_queue.pl script to
just this one message.
We don't care about receiving duplicate warning messages
as much as we care about sending patrons duplicate messages.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:32:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:32:51 +0000
Subject: [Koha-bugs] [Bug 15529] Process Message Queue may send duplicate
emails if process is launched twice
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529
--- Comment #19 from M. Tompsett ---
Apply ALL the patches.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:33:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:33:41 +0000
Subject: [Koha-bugs] [Bug 21079] Unify metadata schema across backends
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21079
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #77036|0 |1
is obsolete| |
--- Comment #6 from Andrew Isherwood ---
Created attachment 79720
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79720&action=edit
Bug 21079: Unify metadata schema across backends
This patch contains a database upgrade that takes appropriate metadata
properties relating to articles in the FreeForm backend and creates
metadata that corresponds with the metadata being created by the BLDSS
backend. This enables us to create templates that can display metadata
equally across any backends that contain this metadata;
To test:
- Ensure you have at least one article request created with the FreeForm
backend
- Check the metadata for the request:
=> TEST: You should have properties such as 'article_title', 'article_author'
populated
=> TEST: You should NOT have properties such as 'container_title' &
'pages'
- Run the upgrade
=> TEST: For the same requests you should now have the following
properties:
- container_title (this should correspond with 'title')
- title (this should correspond with 'article_title')
- pages (this should correspond with 'article_pages')
- author (this should correspond with 'article_author')
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:39:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:39:06 +0000
Subject: [Koha-bugs] [Bug 10382] collection not returning to null when
removed from course reserves
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--- Comment #63 from Kyle M Hall ---
I've been completely unable to reproduce those errors on koha-testing-docker.
It seems that either changes in master have obviated the issue or it is a
peculiarity of the test servers used.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:38:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:38:47 +0000
Subject: [Koha-bugs] [Bug 21385] Vendor search: Item count is incorrectly
updated on partial receive
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79365|0 |1
is obsolete| |
--- Comment #17 from Jonathan Druart ---
Created attachment 79721
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79721&action=edit
Bug 21385: Define the Koha object class for orders
It fixes the following issue:
t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t .. 1/40 Can't
locate object method "_new_from_dbic" via package "Koha::Aqorder"
(perhaps you forgot to load "Koha::Aqorder"?) at
/home/vagrant/kohaclone/Koha/Object.pm line 230.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:40:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:40:28 +0000
Subject: [Koha-bugs] [Bug 10382] collection not returning to null when
removed from course reserves
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:40:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:40:33 +0000
Subject: [Koha-bugs] [Bug 10382] collection not returning to null when
removed from course reserves
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79207|0 |1
is obsolete| |
Attachment #79208|0 |1
is obsolete| |
Attachment #79209|0 |1
is obsolete| |
--- Comment #64 from Kyle M Hall ---
Created attachment 79722
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79722&action=edit
Bug 10382: collection not returning to null when removed from course reserves
Test Plan:
1) Create an item, do not set a collection code
2) Add the item to a course, and choose to set a collection code
3) Ensure the course is enabled, and the collection code is now visible
4) Disable the course, ensure the collection code is no longer visible
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:40:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:40:49 +0000
Subject: [Koha-bugs] [Bug 10382] collection not returning to null when
removed from course reserves
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #65 from Kyle M Hall ---
Created attachment 79723
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79723&action=edit
Bug 10382: Add unit tests for course items
Signed-off-by: Josef Moravec
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:40:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:40:55 +0000
Subject: [Koha-bugs] [Bug 10382] collection not returning to null when
removed from course reserves
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #66 from Kyle M Hall ---
Created attachment 79724
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79724&action=edit
Bug 10382: Course reserves: handle empty values
Test Plan:
1) Create an item, do not set a collection code
2) Add the item to a course, and choose to set a collection code
3) Ensure the course is enabled, and the collection code is now visible
4) Disable the course, ensure the collection code is no longer visible
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:43:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:43:30 +0000
Subject: [Koha-bugs] [Bug 21079] Unify metadata schema across backends
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21079
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79720|0 |1
is obsolete| |
--- Comment #7 from Andrew Isherwood ---
Created attachment 79725
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79725&action=edit
Bug 21079: Unify metadata schema across backends
This patch contains a database upgrade that takes appropriate metadata
properties relating to articles in the FreeForm backend and creates
metadata that corresponds with the metadata being created by the BLDSS
backend. This enables us to create templates that can display metadata
equally across any backends that contain this metadata;
To test:
- Ensure you have at least one article request created with the FreeForm
backend
- Check the metadata for the request:
=> TEST: You should have properties such as 'article_title', 'article_author'
populated
=> TEST: You should NOT have properties such as 'container_title' &
'pages'
- Run the upgrade
=> TEST: For the same requests you should now have the following
properties (if their values were originally populated):
- container_title (this should correspond with what *was* 'title')
- title (this should correspond with 'article_title')
- pages (this should correspond with 'article_pages')
- author (this should correspond with 'article_author')
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:46:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:46:00 +0000
Subject: [Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix
waiting holds at wrong location bug
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346
Sally Healey changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sally.healey at cheshireshared
| |services.gov.uk
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:46:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:46:36 +0000
Subject: [Koha-bugs] [Bug 15529] Process Message Queue may send duplicate
emails if process is launched twice
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79719|0 |1
is obsolete| |
--- Comment #20 from M. Tompsett ---
Comment on attachment 79719
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79719
Bug 15529: Followup to send without more libraries
Forgot to git commit changes first. :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:47:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:47:50 +0000
Subject: [Koha-bugs] [Bug 15529] Process Message Queue may send duplicate
emails if process is launched twice
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529
--- Comment #21 from M. Tompsett ---
Created attachment 79726
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79726&action=edit
Bug 15529: Followup to send without more libraries
This uses the letter_code parameter to limit the current
duplicate run of the process_message_queue.pl script to
just this one message.
We don't care about receiving duplicate warning messages
as much as we care about sending patrons duplicate messages.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:56:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:56:14 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #151 from David Gustafsson ---
Sorry about the delay. I have now checked regarding auto-completion. I'm pretty
sure it is not used anywhere in Koha, even though mappings are created. It also
does not matter if the "input" field for suggestion type is repeated or occurs
once with multiple values, both work:
https://www.elastic.co/guide/en/elasticsearch/reference/current/search-suggesters-completion.html
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:59:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:59:05 +0000
Subject: [Koha-bugs] [Bug 21385] Vendor search: Item count is incorrectly
updated on partial receive
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:59:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:59:10 +0000
Subject: [Koha-bugs] [Bug 21385] Vendor search: Item count is incorrectly
updated on partial receive
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79362|0 |1
is obsolete| |
Attachment #79363|0 |1
is obsolete| |
Attachment #79364|0 |1
is obsolete| |
Attachment #79721|0 |1
is obsolete| |
--- Comment #18 from Jonathan Druart ---
Created attachment 79727
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79727&action=edit
Bug 21385: Correctly count all items in basket for booksellers list
To reproduce:
1) Create a basket with 2 biblios, one with 2 items and one with 1 item
2) Search for vendors and note the basket above should contain 'Item
count 3', 'Biblio count 2', 'Items expected 3'
3) Receive shipment, and only receive 1 of the items on the biblio with
2 items above.
4) Search for vendors and note that the 'Item count' for the basket
above is now '2'.
The item count for a closed basket should remain the same and should
differ from the 'items expected' count some items have been recieved.
Signed-off-by: Caroline Cyr La Rose
Signed-off-by: Jonathan Druart
Amended patch:
FAIL C4/Acquisition.pm
FAIL spelling
RECIEVED ==> RECEIVED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:59:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:59:15 +0000
Subject: [Koha-bugs] [Bug 21385] Vendor search: Item count is incorrectly
updated on partial receive
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385
--- Comment #19 from Jonathan Druart ---
Created attachment 79728
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79728&action=edit
Bug 21385: Add Unit Tests
Signed-off-by: Caroline Cyr La Rose
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:59:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:59:19 +0000
Subject: [Koha-bugs] [Bug 21385] Vendor search: Item count is incorrectly
updated on partial receive
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385
--- Comment #20 from Jonathan Druart ---
Created attachment 79729
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79729&action=edit
Bug 21385: (follow-up) make query consistent
The expected items query wasn't consistent with other queries in this
module with regards to identifying cancelled orders
Signed-off-by: Caroline Cyr La Rose
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 16:59:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 14:59:23 +0000
Subject: [Koha-bugs] [Bug 21385] Vendor search: Item count is incorrectly
updated on partial receive
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21385
--- Comment #21 from Jonathan Druart ---
Created attachment 79730
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79730&action=edit
Bug 21385: Define the Koha object class for orders
It fixes the following issue:
t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t .. 1/40 Can't
locate object method "_new_from_dbic" via package "Koha::Aqorder"
(perhaps you forgot to load "Koha::Aqorder"?) at
/home/vagrant/kohaclone/Koha/Object.pm line 230.
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 17:05:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 15:05:13 +0000
Subject: [Koha-bugs] [Bug 21428] Switch two-column templates to Bootstrap
grid: Reports part 1
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21428
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 17:05:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 15:05:39 +0000
Subject: [Koha-bugs] [Bug 21429] Switch two-column templates to Bootstrap
grid: Reports part 2
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21429
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Oct 1 17:05:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Oct 2018 15:05:17 +0000
Subject: [Koha-bugs] [Bug 21428] Switch two-column templates to Bootstrap
grid: Reports part 1
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21428
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79693|0 |1
is obsolete| |
--- Comment #3 from Jonathan Druart ---
Created attachment 79731
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79731&action=edit
Bug 21428: Update two-column templates with Bootstrap grid: Reports part 1
This patch modifies several administration templates to use the
Bootstrap grid instead of YUI.
This patch also removes obsolete "text/javascript" attributes from