[Koha-bugs] [Bug 18355] Permanent location should show with cart location

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Failed QA

--- Comment #32 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Jonathan Druart from comment #31)
> Hi Christopher,
> I would suggest to move the display logic to the template for several
> reasons:
> - the pl logic from the first patch is not easy to read
> - not defined AV are handled properly by the template plugin
> (Koha::Template::Plugin::AuthorisedValues)
> - as we are going to reuse this logic, we will move it to an include file to
> avoid copy/paste
> 
> Could you take a look at tell me what you think about it?

Jonathan,
Thanks for the suggestion.  I have no problem trying to move it to the tt.  I
put it in the pl because that is where it was already being done.

Sorry for the short code.  I opted for short code for efficiency but realize it
isn't efficient for everyone else.  I will work on keeping things more
readable.

Thank you for your input.  I will work on this.

-- 
You are receiving this mail because:
You are watching all bug changes.