[Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #139 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Jonathan Druart from comment #121)
> Several things here:
> 
> 1. I have reattached the patch in the correct order and add the
> signed-off-by lines for Lisette and Jesse (only last patch was signed off)
> 
> 2. (In reply to Josef Moravec from comment #103)
> > Comment on attachment 78744 [details] [review] [review]
> > In the schema files I can see the foreign keys for branchcode, categorycode
> > and itemtype, but they aren't defined in db update nor kohastructure.sql.
> > But I think we want them.
> 
> I have reworked the schema files (md5sum was wrong which caused the script
> to fail). Foreign keys have been added to both kohastructure.sql and atomic
> update file.
> 
> 3. 
> (In reply to Josef Moravec from comment #104)
> > Comment on attachment 78746 [details] [review] [review]
> > > +Koha::Hold - Koha Hold object class
> > 
> > C & P mistake
> 
> Fixed (x2)
> 
> 4.
> > @@ +47,5 @@
> > > +    my $categorycode = $params->{categorycode};
> > > +    my $itemtype     = $params->{itemtype};
> > > +    my $branchcode   = $params->{branchcode};
> > > +
> > > +    croak q{No rule name passed in!} unless $rule_name;
> > 
> > Please use Exception instead of croak
> 
> Removed and exceptions are now thrown
> 
> 5. Tests have been provided, finally!

Great job Jonathan, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.