[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Oct 2 02:21:56 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexbuckley at catalyst.net.nz
             Status|Patch doesn't apply         |ASSIGNED

--- Comment #100 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Hi there

I have gone through and rebased this, master had progressed quite a lot since
this patch was added and so I had to make a few assumptions during the rebase. 

Please let me know if changes need to be made as a result of the rebase. 

I have also corrected the commit messages to the format 'Bug XXXX: '

I have also written two other patches which correct template issues, and remove
the check for the value of the 'ReserveMaxPickupDelay' syspref in Koha/Hold.pm
in the set_waiting() function. 

This check is unneccessary as the main patch on this bug report removes the
ReserveMaxPickupDelay syspref, and so I replaced this with a retrieval of the
appropriate issuingrule and setting the exprationdate = waitingdate +
issuingrule.lastpickupwait 

I am currently working on the unit tests t/db_dependent/Hold.t and so I am
assigning this the status of 'Assigned' until I have attached a commit with the
corrected t/db_dependent/Hold.t

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list