[Koha-bugs] [Bug 21512] New: CalculateFinesOnReturn doesn't work without the syspref finesMode

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21512

            Bug ID: 21512
           Summary: CalculateFinesOnReturn doesn't work without the
                    syspref finesMode
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: olli-antti.kivilahti at helsinki.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Fines are not created for checking in an Item, if the syspref
'CalculateFinesOnReturn' is enabled without the syspref finesMode being in the
'production' -mode (Calculate and charge).


CalculateFinesOnReturn must work without the fines.pl -feature.


The problem is with the subroutine C4::Circulation::_CalculateAndUpdateFine()

Initially it looks like it must be invoked from the fines.pl as well. But that
subroutine is only used within the C4::Circulation module for AddRenew and
AddReturn.
Hence the _CalculateAndUpdateFine() has nothing to do with fines.pl|finesMode.


This patch replaces the finesMode-check with CalculateFinesOnReturn-check.


I am not sure why there needs to be a specific syspref for the fines.pl, or why
CalculateFinesOnReturn is needed, as the fine amounts can be tweaked using the
circulation rules matrix and the fines.pl-cronjob can either be ran, or not,
with an endless possibility of parameters that shouldn't be in the sysprefs.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.