[Koha-bugs] [Bug 20151] Search is broken when stemming has no language

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Oct 9 10:31:38 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20151

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78997|0                           |1
        is obsolete|                            |

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 80253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80253&action=edit
Bug 20151: always use current language for stemming

When stemming is enabled, in catalog searching
"C4::Search::_build_stemmed_operand" will transform query operand into stemmed
operand using stemmer Lingua::Stem::Snowball with a specified language.
This stemmer returns undef stemmed operand if no language is defined.

In main catalog search (catalogue/search.pl) current language is used.
But in other pages "acqui/neworderbiblio.pl" and "cataloguing/addbooks.pl" no
language is defined so stemmed operand is empty and so stemming is not applied.

This patch corrects by returning in "C4::Search::_build_stemmed_operand"
operand without change if no langage is defined.
And uses current langage in pages "acqui/neworderbiblio.pl" and
"cataloguing/addbooks.pl" so all catalog search uses stemming.

Test plan :
1) Enable system preferences QueryStemming and QueryWeightFields
2) Disable system preferences QueryAutoTruncate, QueryFuzzy and UseQueryParser
3) Go to intranet main page and click on "Search the catalog" tab
4) Perform a search (without index) that uses the stemming, for example
searching for "years" will also match "year"
5) Note how many results you get, for example "year" gets 24 results and
"years" gets 24 results
6) Go to "Cataloging" module
7) Perform a search on same word in "Cataloging search" tab
8) Note how many results you get
9) Without patch you get fewer results than first search (step 5) because
stemming is not applied, for example "year" gets 11 results and "years" gets 15
results
10) With patch you get the same results as first search (step 5) because
stemming is applied, for example "year" and "years" gets 24 results
11) Same tests in aquisition module
12) On a basket, click "Add to basket" and perform a search in "From an
existing record"

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list