[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529

--- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 80256
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80256
Bug 15529: Altered logic for lockfile creation

Review of attachment 80256:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15529&attachment=80256)
-----------------------------------------------------------------

Thanks for the super quick followup.. some minor issue which I'm happy to take
care of as a qa followup.

I'm just getting another qa to take a quick look to varify my understanding of
the packages scripts then I'll do the followup and pass.

::: misc/cronjobs/process_message_queue.pl
@@ +40,4 @@
>  my $help = 0;
>  my $verbose = 0;
>  my $type = q{};
> +my $use_flock;

I don't think this is needed.. unless we want to allow optionally falling back
to not using lock files at all.

@@ +96,5 @@
> +    last if defined $LockFH;
> +}
> +if( !defined $LockFH ) {
> +        print "WARNING: Could not create lock file $lockfile: $!\n";
> +        print "Please check your koha-conf.xml for ZEBRA_LOCKDIR.\n";

ZEBRA_LOCKDIR should be cron_lockdir here ;)

@@ +98,5 @@
> +if( !defined $LockFH ) {
> +        print "WARNING: Could not create lock file $lockfile: $!\n";
> +        print "Please check your koha-conf.xml for ZEBRA_LOCKDIR.\n";
> +        print "Verify file permissions for it too.\n";
> +        $use_flock = 0; # we disable file locking now and will continue

As above, we're not intending on allowing use of this script without lock files
after this patch.. I might get a second qa opinion on that, but I can't
currently see a reason why we'd need to support a no-lock version.

-- 
You are receiving this mail because:
You are watching all bug changes.