[Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to code if description doesn't exist

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Oct 12 02:47:51 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Christopher Brannon from comment #6)
> Tomas, I have either failed at writing a good test or failed at my patch. 
> Would you take a look a the test and tell me what you think.  It seems to
> fail where it should with the master, but it is failing in other ways with
> the patch, yet the patch does what it is supposed to.  So, I don't know
> where I have gone astray.

I wrote tests for the existing behavior, trying to cover all the use cases. The
last two tests are for the situation in which the requested av doesn't exist.

What I understand is that you want to change the behavior so those two tests
return the passed value instead of the empty string. So all you need to do (if
I didn't miss something) is change those two tests, so they 'expect' the result
is the passed value.

We can talk about it tomorrow!

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list