[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #184 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:

Great work. Spent whole morning on it so there will be comments (see also
follow-up):

Since you adjust EmbedItemsInMarcBiblio more fundamentally and add a borcat
parameter, I would have at least expected the borcat parameter in the subtest
for this routine. Bad luck however.
Considering the history of this report, and the demonstrated attention for
other tests here, I will not be too strict on that. Knowing that you will
submit them on a new report :)

No blocker but something worth fixing / feature extending ?
Have a book with two items. One item must be hidden. In the OPAC I see:
Availability: Items available for loan: RMA [Call number: 200 P 1] (2). 
This line on opac-search or opac-shelves.pl shows me (in this case) the call
number of the hidden item ! Also the number 2 reveals that there are more items
than shown on opac-detail.
Could imagine that these "hidden books" may stand on a shelf number that you do
not want to display either.. 
When I put the book in the cart and email the cart, I will see both items in
the cart. How about hiding that one ?

Similar point.
Although you could argue that you have a special circ rule for these hidden
items, without such a rule opac-reserve shows me the hidden items if I allow
item holds. Which it should not imo.
Not a blocker for me now, but it feels even a bit more serious than the former
point.

And thinking further: In the staff client the hidden item pops up even if I do
not put the staff category in the new pref. OK, I understand that. But if I
export a biblio with Save to marcxml or export data under tools etc. the item
also pops up everywhere. Certainly not a blocker, but should the feature of
hiding items not have some impact in such things too ? Same for SRU/Z39.50
output (item just there). Etc.

In conclusion: This patch set looks good enough to me. The feature has been
developed (before) picking mostly low fruit. Looking a bit further, items are
not that hidden after all..

-- 
You are receiving this mail because:
You are watching all bug changes.