[Koha-bugs] [Bug 19263] Advanced Editor - Rancor - Add auto control number (001) widget

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Oct 12 12:24:32 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263

--- Comment #17 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 80308
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80308
Bug 19263: 001 widget only for configured client

Review of attachment 80308:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19263&attachment=80308)
-----------------------------------------------------------------

::: installer/data/mysql/mandatory/auth_val_cat.sql
@@ +44,4 @@
>      ('HINGS_C'),
>      ('HINGS_AS'),
>      ('HINGS_RD'),
> +    ('STACK')

There is missing colon

::: koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-widgets-marc21.inc
@@ +127,5 @@
> +                    + _("Control number: ")
> +                    + '<span class="control-number-widget-contents"></span>'
> +                    + '<button class="control-number-widget-assign">' + _("Assign next") + '</button>'
> +                    + '<select class="control-number-widget-sequence"></select>'
> +                    + '<button class="control-number-widget-override">Override</button>'

"Override" is not translatable

@@ +157,5 @@
> +
> +                        if ( result ) widget.setControlNumber( result );
> +                    } ).end();
> +
> +                var sequence_list = $.map( KohaBackend.GetAuthorisedValues( 'CONTROL_NUM_SEQUENCE' ), function( authval ) {

You don't need to fetch authorised values again - you have them in reg001
variable

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list