[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Oct 12 13:00:31 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

--- Comment #57 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 80280
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80280
Bug 20581: Provide status_alias on IllRequest

Review of attachment 80280:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20581&attachment=80280)
-----------------------------------------------------------------

::: Koha/Illrequest.pm
@@ +118,5 @@
> +    return $self->status_alias ?
> +        Koha::AuthorisedValue->_new_from_dbic(
> +            scalar $self->_result->status_alias
> +        ) :
> +        undef;

You shouldn't return explicit undef. And please add to pod information about
return type.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list