[Koha-bugs] [Bug 20563] ILL request list gives no indication of source and/or target

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563

--- Comment #10 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 79715
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79715
Bug 20563: Allow display of requested partners

Review of attachment 79715:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20563&attachment=79715)
-----------------------------------------------------------------

::: Koha/Illrequest.pm
@@ +994,5 @@
> +=head3 requested_partners
> +
> +    my $partners_string = $illRequest->requested_partners;
> +
> +Return the string representing the email addresses of the parters to

typo "parters" ;)

::: koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
@@ +165,5 @@
> +                row.hasOwnProperty('requested_partners') &&
> +                row.requested_partners &&
> +                row.requested_partners.length > 0
> +            ) ?
> +                "Requested from:<br>" +

This is not translatable

@@ +200,5 @@
>              },
> +            additional_status: {
> +                name: _("Additional status"),
> +                func: createAdditional
> +            },

Why do you create new column for this? It duplicates the information that
status is "Requested", You can as well add the partners to the normal status
column IMHO.

@@ +547,5 @@
>                                  <div class="status">
>                                      <span class="label status">Status:</span>
>                                      [% request.capabilities.$req_status.name | html %]
> +                                    [% IF request.requested_partners.length > 0 %]
> +                                        ([% request.requested_partners %])

there is missing filter

-- 
You are receiving this mail because:
You are watching all bug changes.