[Koha-bugs] [Bug 21215] Saved SQL reports code improvements

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21215

paxed <pasi.kallinen at joensuu.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79060|0                           |1
        is obsolete|                            |

--- Comment #6 from paxed <pasi.kallinen at joensuu.fi> ---
Created attachment 80585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80585&action=edit
Bug 21215: Saved SQL reports code improvements


The saved SQL reports code is a bit warty, so improve it:

Instead of using the same code in multiple places to split the SQL
move that code into the Guided.pm module.

Add several tests for parameter substitution and SQL validation.

Make it much easier to add more parameter types for substitution.

Test plan:

1) Run your saved SQL reports and check that they work correctly
2) Create new SQL reports and check that the parameters are queried
   correctly.
3) Prove the t/db_dependent/Reports/Guided.t

-- 
You are receiving this mail because:
You are watching all bug changes.