[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #186 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to M. Tompsett from comment #185)
> Regarding the leak via counting being off. This counting problem already
> leaks and is an issue. Fixing the counting problem is a complex problem,
> which has had recent comments on the mailing list. Given the size and scope
> of testing for this patch, I did not want to keep coding for perfection.
> Perfection is the enemy of good, or some variation thereof. :)

Not sure if we talk about the same counting problem. There is the problem of
leaving a search result out (having 19 hits on a page instead of 20 etc.) but I
was referring to the listing of 2 items where one is hidden. At least we know
that there is one hidden :) But no need to address that here.

> ::: opac/opac-search.pl
> @@ +125,4 @@
> >      authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ),
> >      }
> >  );
> > +my $patron = Koha::Patrons->find( $borrowernumber );
> 
> Not an exact copy of 658 during the optimization. Will this affect things?

Not a problem. We could test on borrowernumber again, but find(undef) will
return nothing either and this is consistent with the common approach.
The line using $patron is testing on $patron. So should be fine.

-- 
You are receiving this mail because:
You are watching all bug changes.