[Koha-bugs] [Bug 21337] Add Koha::Patrons->delete (trivial wrapper)

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Oct 15 19:47:28 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21337

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I have fixed a failing test in Objects.t

IMO the following line is wrong:
  $patron->delete == 1 || Koha::Exceptions::Patron::Delete->throw;

We must follow dbic behaviours and so we must not throw an exception if
something went wrong (what DBIC does)

Then I would not name an exception "Koha::Exceptions::Patron::Delete" but more
something like Koha::Exceptions::Patron::NotDeleted, or CannotDelete,
CannotBeDeleted, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list