[Koha-bugs] [Bug 15774] Additional fields for baskets

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

--- Comment #45 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
* Tests missing for GetHistory
* +    my $rs = Koha::Database->new->schema->resultset('AdditionalFieldValue');
must be Koha::AdditionalFieldValue instead.
I would suggest to have a look at Koha::Patron::Category and how the
'branch_limitation' add/update/remove is done, in order to follow an existing
pattern
* additional_field_values must return a Koha::Objects
* Should not search_additional_fields be more search_*by*_additional_fields?
I think we agreed on "filter_by_*" somewhere else (Martin?)
* +        # TODO Add column additional_field_values.tablename to avoid
subquery ?
I do not think it is relevant, we want the tablename at additional_fields level
* +    for my $field (Koha::AdditionalFields->search({ tablename => 'aqbasket'
})) {
Better to use while ->next instead

These patches are great, please provide a quick follow-up and we will make it
part of 18.11!

-- 
You are receiving this mail because:
You are watching all bug changes.