[Koha-bugs] [Bug 21337] Add Koha::Patrons->delete (trivial wrapper)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21337

--- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #17)
> I have fixed a failing test in Objects.t

Fine, thanks. Note that we must think about returning 0 or 0E0. But note that
DBIx here also depends on the specific SQL backend.


> IMO the following line is wrong:
>   $patron->delete == 1 || Koha::Exceptions::Patron::Delete->throw;
> 
> We must follow dbic behaviours and so we must not throw an exception if
> something went wrong (what DBIC does)

Not sure about that. Will come back later.


> Then I would not name an exception "Koha::Exceptions::Patron::Delete" but
> more something like Koha::Exceptions::Patron::NotDeleted, or CannotDelete,
> CannotBeDeleted, etc.

Always in for a good discussion about names :)

-- 
You are receiving this mail because:
You are watching all bug changes.