[Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is not yet in waiting state

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572

--- Comment #10 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
Created attachment 80714
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80714&action=edit
Bug 21572: Unify checkout policy of reserved items in SIP, SCO, and intranet

Instead of having two different system preferences,
AllowItemsOnHoldCheckout and AllowItemsOnHoldCheckoutSCO, now we have
only the former one. The preference is also moved now in the
C4::Circulation::CanBookBeIssued subroutine so that we have only one
single truth about whether the book can be checked out.

This patch changes the current checkout policy a bit. Without this
patch patron could check out item in Waiting state with the SCO module
but after this patch it is not possible anymore. Only checking out
items in Reserved state is possible. This is how the SIP server
already currently works so now these two would be unified. Allowing to
checkout items in the Waiting state doesn't make any sense because it
would defeat the purpose of holds, therefore the SIP server approach
on only allowing checking out Reserved state items was chosen.

The unwanted message "Item XXXXX / (yyyy) has been on hold for
Joe (yyyy) at My Library since 15.10.2018" on intranet will be gone
now after this patch if AllowItemsOnHoldCheckout is enabled.

To test:

Testing in SCO, SIP, Intranet with AllowItemsOnHoldCheckout set 'Don't allow':
 1. Apply patch
 2. Have a biblio record with one item A
 3. Make a hold on item A for patron Y (bib level or item, doesn't matter)
 4. Try to checkout item A for patron X
 5. It should fail (in case of intranet a warning/confirmation dialog should
come)

Testing in SCO, SIP, Intranet with AllowItemsOnHoldCheckout set 'Allow':
 1. Apply patch
 2. Have a biblio record with one item A
 3. Make a hold on item A for patron Y (bib level or item, doesn't matter)
 4. Try to checkout item A for patron X
 5. It should succeed (in case of intranet there should be no confirmation
dialog)

Testing in SCO, SIP, Intranet with AllowItemsOnHoldCheckout set 'Allow' or
'Don't allow':
 1. Apply patch
 2. Have a biblio record with one item A
 3. Make a hold on item A for patron Y (bib level or item, doesn't matter)
 4. Check in item A in intranet so that it goes to Waiting status
 5. Try to checkout item A for patron X
 6. It should fail (in case of intranet a warning/confirmation dialog should
come)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.