[Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is not yet in waiting state

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572

--- Comment #11 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
Created attachment 80715
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80715&action=edit
Bug 21572: Remove unnecessary SIP checkout code regarding holds

The loop that checks whether "Item is on hold shelf for another patron"
is already done in C4::Circulation::CanBookBeIssued() so we don't have
to do it again but just trust it to tell us the confirmation message
"RESERVE_WAITING" when it is someone else's hold that the patron tries
to checkout.

This removes also the message "Item was reserved for you." since it
could have have never appeared since RESERVED confirmation message comes
only when the item is reserved to another patron.

To test:
 1. Apply patch
 2. Have a biblio record with one item A
 3. Make a hold on item A for patron Y (bib level or item, doesn't matter)
 4. Check in item A in intranet so that it goes to Waiting status
 5. Try to checkout item A for patron X with the SIP server
 6. Checkout should fail with message "Item is on hold shelf for another
    patron."

 1. Apply patch
 2. Have a biblio record with two items A and B
 3. Make a hold on item A for patron Y (bib level or item, doesn't matter)
 4. Check in item A in intranet so that it goes to Waiting status
 5. Try to checkout item B for patron X with the SIP server
 6. Checkout should succeed

 1. Apply patch
 2. Make sure AllowItemsOnHoldCheckout is set "Don't allow"
 3. Have a biblio record with one item A
 4. Make a hold on item A for patron Y (bib level or item, doesn't matter)
 5. Try to checkout item A for patron X with the SIP server
 6. Checkout should fail with message "Item is reserved for another
    patron upon return."

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.