[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Oct 22 15:52:17 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at helsinki.fi

--- Comment #163 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
(In reply to David Gustafsson from comment #160)
> Created attachment 80971 [details] [review]
> Bug 19893: Add pods, remove syspref, add tests for serialization format
> 
> Add missing pods, remove obsolete syspref and add test for serialization
> format for records exceeding max record size

Thanks for the patch! :) Couple comments (I have to go now, continuing review
hopefully later):

1. There is typo databse and missing to. "Using mappings stored in databse
convert" -> "Using mappings stored in database to convert"

2. It appears there are many different changes but they have been put to one
commit. It would make it easier to review if the changes were in their own
commits with their own commit messages.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list