[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

--- Comment #167 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
(In reply to David Gustafsson from comment #165)
> Regarding the other changes, to make review easier, they where mainly:
> 
> Rename marc_records_to_documents to _marc_records_to_documents to make
> "private".
> 
> Split all the index_status_<status> methods into is_index_status_<status>
> (to check whether index has this status), and set_index_status_<status> (to
> set this status for index), since the previous method definition was not
> very intuitive (call without argument to get, call with "1" to set).

Thanks for the description but the problem is I cannot connect these
descriptions to the pieces of code easily. It would be really awesome if you
could split the patch in to as many as required for the patches to do one
thing. Tests should be at least ok to split to its own patch?

However, I keep testing your patch in the current state and will update you if
there is something.

-- 
You are receiving this mail because:
You are watching all bug changes.