[Koha-bugs] [Bug 21584] Wrong offset type for Lost Item

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
The original bug is in:

koha-tmpl/intranet-tmpl/prog/en/includes/account_offset_type.inc

it is not easy to 'reproduce', as the code that should generate credit return
offsets is not working properly (bug 13098). This is my attempt:

- View the following file: installer/data/mysql/account_offset_types.sql
  $ less installer/data/mysql/account_offset_types.sql
- Notice there's 'Lost Item' in line 4
- View koha-tmpl/intranet-tmpl/prog/en/includes/account_offset_type.inc
  $ less koha-tmpl/intranet-tmpl/prog/en/includes/account_offset_type.inc
- Notice it maps the values from the account_offset_types.sql file into english
descriptions.
=> FAIL: There's no mapping for 'Lost Item', but there's a mapping for 'Lost
Item Return', which doesn't really exist in account_offset_types.sql
- Apply the patch
=> SUCCESS: The value <-> description mapping in account_offset_type.inc makes
sense now. It respects the values that would be stored on the DB if the feature
worked correctly.
=> BONUS: Koha/Account.pm gets fixed to generate the right value too. Notice
there's a hash with mappings for some keywords into both account_offset_types
and account types.

-- 
You are receiving this mail because:
You are watching all bug changes.