[Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Oct 23 21:21:54 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

--- Comment #102 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Code review:
1. Not important but the Koha.po file provided for the tests are not taken into
account. Maybe it could be better to generate the .mo from the tests?
2. No tests provided for misc/translator/LangInstaller.pm - I would not
consider it as blocker as it is the current state.
3. The content from the .inc files are added to the .po because they contain TT
blocks on several lines. Maybe we should have a list of files to skip and copy
as it (?)
4. What is done in Koha::I18N::init is weird, but I trust you if you think
everythink is needed.
However: pod Locale::Messages, nl_putenv: "The sole purpose of this function is
to work around some ideosyncrasies in the environment processing of Windows
systems. If you want to portably set or unset environment variables, use this
function instead of directly manipulating %ENV."
So maybe we should use ENV, it will make the line clear about what it does, and
'git grep $ENV' will work

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list