[Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

--- Comment #105 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Jonathan Druart from comment #102)
> Code review:
> 1. Not important but the Koha.po file provided for the tests are not taken
> into account. Maybe it could be better to generate the .mo from the tests?
Or maybe we can simply remove the .po file as it can be easily generated from
the .mo file with msgunfmt ?

> 2. No tests provided for misc/translator/LangInstaller.pm - I would not
> consider it as blocker as it is the current state.
Thanks for not considering it a blocker :)
Testing a module that modifies the filesystem can be a huge pain, especially in
this case where paths are hardcoded and where it modifies files tracked by git.
But I can certainly try to write a test for extract_messages_from_templates
since it doesn't have too many external dependencies and is the most
complicated thing of the whole patch.

> 3. The content from the .inc files are added to the .po because they contain
> TT blocks on several lines. Maybe we should have a list of files to skip and
> copy as it (?)
I don't understand. My .po file is clean after an 'update'. Why would we want
to skip .inc files ? Can you give an example of what gets wrongly added to the
.po ?

> 4. What is done in Koha::I18N::init is weird, but I trust you if you think
> everythink is needed.
I agree that it's weird but I'm pretty sure everything is needed

> However: pod Locale::Messages, nl_putenv: "The sole purpose of this function
> is to work around some ideosyncrasies in the environment processing of
> Windows systems. If you want to portably set or unset environment variables,
> use this function instead of directly manipulating %ENV."
> So maybe we should use ENV, it will make the line clear about what it does,
> and 'git grep $ENV' will work
Ok I'll try without nl_putenv and see if it works

-- 
You are receiving this mail because:
You are watching all bug changes.