[Koha-bugs] [Bug 21299] Move referer code from changelanguage to module in opac and staff

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Oct 25 11:49:17 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78335|0                           |1
        is obsolete|                            |

--- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 81121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81121&action=edit
Bug 21299: Introduce localReferer in [opac-]changelanguage.pl

With the work from the former patch, we now have a nice and easy replace..

NOTE: The additional logic in opac-changelanguage.pl is now also applied
to the intranet counterpart (changelanguage.pl). This effectively makes
changelanguage.pl no longer refer to external URLs (as the opac already
did by testing the referer). Might be just theoretical, but consistent.

Test plan:
Test changing language from various OPAC and staff locations.
Include language=[some_language] in the URL before changing language.
[Bonus] Test calling changelanguage.pl from another server. You should no
longer be referred back to the calling server. (See below.)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Added link <a
href="[mystaffserver]/cgi-bin/koha/changelanguage.pl?language=en">link</a>
somewhere on external server.
Verified that without this patch, it hits the staff server and refers back to
the caller. But with this patch, it refers to staff homepage.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list