[Koha-bugs] [Bug 21641] Software error when checking out an item with a charge associated with it

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21641

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to M. Tompsett from comment #7)
> Also, I've been pondering... shouldn't this getnextacctno be in
> Koha::Account::Line(s)? It is just using the AccountLines table no
> relationships. I think it is a perfect candidate for moving.
> 
> AND... when is getnextacctno called? Almost always in the midst of
> generating a new account line. Why not remove the necessity for accountno
> being passed in a ->new() and determine the account line number id at save
> time? This means some code clean up, but I think it is better in the long
> run than this short term patch.

The accountno field and the associated functions should be removed. I don't
think we should move that anywhere. :-D

-- 
You are receiving this mail because:
You are watching all bug changes.