[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

--- Comment #182 from David Gustafsson <glasklas at gmail.com> ---

(In reply to Joonas Kylmälä from comment #181)
> Hi,
> 
> could you still split the changes to their own commits?

I was considering your previous comment:

(In reply to Joonas Kylmälä from comment #166)
> (In reply to David Gustafsson from comment #164)
> > Created attachment 80983 [details] [review] [review]
> > Bug 19893: Fixed some typos
> 
> Please squash this to the previous patch as a new commit created by it is
> not necessary
> (https://wiki.koha-community.org/wiki/
> Development_IRC_meeting_27_September_2017)

which I interpreted as patch was supposed to be squashed in. As I no longer
have the specific git commits in my local git repo I would have to rebuild them
from the different iterations of patches in this issue and I would rather not
do that due time constrains and risk of screwing things up. I also think there
might be a benefit to review the patch as a whole since you don't have to
account for errors made in previous commits that might have been corrected in a
later one.

-- 
You are receiving this mail because:
You are watching all bug changes.